Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upExtract impl_header_lifetime_elision out of in_band_lifetimes #53016
Conversation
rust-highfive
assigned
pnkfelix
Aug 3, 2018
This comment has been minimized.
This comment has been minimized.
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
label
Aug 3, 2018
This comment was marked as resolved.
This comment was marked as resolved.
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
scottmcm
referenced this pull request
Aug 3, 2018
Open
Tracking issue for RFC 2115: In-band lifetime bindings #44524
This comment has been minimized.
This comment has been minimized.
|
unassigning self as i'm about to go on PTO |
pnkfelix
removed their assignment
Aug 3, 2018
This comment has been minimized.
This comment has been minimized.
|
(who I assume will have good sense to delegate accordingly if necessary) |
rust-highfive
assigned
nikomatsakis
Aug 3, 2018
This comment has been minimized.
This comment has been minimized.
| @@ -718,6 +720,10 @@ impl<'a> LoweringContext<'a> { | |||
| return; | |||
| } | |||
This comment has been minimized.
This comment has been minimized.
nikomatsakis
Aug 6, 2018
Contributor
seems like we could remove this if, as it serves no purpose now
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-bors
and removed
S-waiting-on-review
labels
Aug 6, 2018
This comment has been minimized.
This comment has been minimized.
|
@bors p=1 Giving higher priority because this is an EP2 blocker |
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Aug 6, 2018
This comment has been minimized.
This comment has been minimized.
|
|
bors
merged commit 1c7af27
into
rust-lang:master
Aug 7, 2018
This comment has been minimized.
This comment has been minimized.
|
Tested on commit 45a9d41.
|
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Aug 7, 2018
scottmcm
added a commit
to scottmcm/rust-clippy
that referenced
this pull request
Aug 7, 2018
This was referenced Aug 7, 2018
scottmcm
deleted the
scottmcm:impl-header-lifetime-elision
branch
Aug 7, 2018
pnkfelix
referenced this pull request
Oct 8, 2018
Closed
[1.30 beta] Test suite of the jemalloc-ctl crate is failing #54478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
scottmcm commentedAug 3, 2018
•
edited
This way we can experiment with
impl Debug for &MyTypeseparately fromimpl Debug for &'a MyType.I can't say I know what the code in here is doing, so please let me know if there's a better way🙂
I marked this as enabled in 2018 so that edition code continues to work without another flag.
Actual feature PR #49251; Tracking Issue #15872; In-band lifetimes tracking issue #44524.
cc @aturon, per discussion on discord earlier
cc @cramertj & @nikomatsakis, who actually wrote these features