Remove an unnecessary check in in-band lifetime collecting [53016 followup] #53145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Well maybe it wasn't superfluous after all 🙂 [00:21:41] �[0m�[0m�[1m�[32m Compiling�[0m chalk-engine v0.6.0
[00:21:41] thread 'main' panicked at 'assertion failed: self.lifetimes_to_define.is_empty()', librustc/hir/lowering.rs:658:9
[00:21:41] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:21:41]
[00:21:41] error: internal compiler error: unexpected panic
[00:21:41]
[00:21:41] note: the compiler unexpectedly panicked. this is a bug.
[00:21:41]
[00:21:41] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[00:21:41]
[00:21:41] note: rustc 1.30.0-dev running on x86_64-unknown-linux-gnu
[00:21:41]
[00:21:41] note: compiler flags: -Z force-unstable-if-unmarked -C opt-level=2 -C prefer-dynamic -C debug-assertions=y -C link-args=-Wl,-rpath,$ORIGIN/../lib --crate-type lib
[00:21:41]
[00:21:41] note: some of the compiler flags provided by cargo are hidden
[00:21:41]
[00:21:41] �[0m�[0m�[1m�[31merror:�[0m Could not compile `chalk-engine`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nikomatsakis
Fixing the nit from #53016 (comment)