Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Genesis of Generic Germination #53645

Merged
merged 8 commits into from May 6, 2019
Merged

Conversation

@varkor
Copy link
Member

@varkor varkor commented Aug 23, 2018

Long had its coming been foretold: a collaborative effort with @yodaldevoid, set in motion by @jplatte, to beget a new Kind: one of a very different Sort to those that come before it. Amidst promises of ineffable powers previously thought unobtainable, few dared believe that the prophecies were true. But as they gazed upon that which claimed to be the Beginning, a few gentle sparks of hope fluttered deep within. It was not Time yet. But it was a Sign. And maybe, for some, that was enough.

There's a long way to go, but we're at the point where we would benefit from GitHub's reviewing capabilities.

r? @eddyb

@rust-highfive

This comment was marked as off-topic.

@bors
Copy link
Contributor

@bors bors commented Aug 24, 2018

The latest upstream changes (presumably #53662) made this pull request unmergeable. Please resolve the merge conflicts.

@kennytm
Copy link
Member

@kennytm kennytm commented Aug 28, 2018

(Somehow I read the title as "Genesis of Germanic Germination" and thought why we're adding i18n into rustc itself 😐)

@petrochenkov petrochenkov self-assigned this Aug 28, 2018
src/librustc/hir/mod.rs Outdated Show resolved Hide resolved
// parsing problem. Either mark all const args with const (or
// something else, it doesn't really matter) or merge const args
// and type args together at the AST level and separate them
// later on, probably when lowering to the HIR.

This comment has been minimized.

@petrochenkov

petrochenkov Aug 31, 2018
Contributor

If S<MY_CONST> is supposed to work, then it can use same approach as identifiers in patterns.
In AST it's PatKind::Ident, but in HIR it's turned into a proper pattern based on resolution, for const arguments it would be something like ast::GenericArg::Ident.
I agree this is not necessary to do in this PR though.

@petrochenkov petrochenkov removed their assignment Sep 1, 2018
@varkor
Copy link
Member Author

@varkor varkor commented Sep 6, 2018

(Note for triage: I'm going to get around to addressing these comments and hopefully fixing the existing crashes soon.)

@TimNN
Copy link
Contributor

@TimNN TimNN commented Sep 25, 2018

Ping from triage! Since it's been I while, I was wondering if you could give us a small update on the status of this PR?

@varkor
Copy link
Member Author

@varkor varkor commented Sep 28, 2018

I'm going to start investigating the ICE again soon (been busier than I expected). I think @eddyb's going to be leaving some comments soon as well.

@TimNN
Copy link
Contributor

@TimNN TimNN commented Oct 16, 2018

Ping from triage! Since it's been I while, I was wondering if you could give us a small update on the status of this PR?

@varkor
Copy link
Member Author

@varkor varkor commented Oct 16, 2018

I've made progress in my local branch since last time, though not quite ready to push. I think a full review will be unlikely before the 2018 edition though, as things are getting busy close to the deadline.

@varkor varkor force-pushed the varkor:const-generics-redux branch from f0bae41 to bfc4b41 Oct 16, 2018
@TimNN
Copy link
Contributor

@TimNN TimNN commented Oct 23, 2018

@vakor: Thanks for the update!

varkor and others added 4 commits May 6, 2019
Co-Authored-By: Gabriel Smith <yodaldevoid@users.noreply.github.com>
Co-Authored-By: Gabriel Smith <yodaldevoid@users.noreply.github.com>
Co-Authored-By: Gabriel Smith <yodaldevoid@users.noreply.github.com>
Co-Authored-By: Gabriel Smith <yodaldevoid@users.noreply.github.com>
@varkor varkor force-pushed the varkor:const-generics-redux branch from ed69aa2 to 32965a7 May 6, 2019
@varkor varkor changed the title [WIP] The Genesis of Generic Germination The Genesis of Generic Germination May 6, 2019
@varkor
Copy link
Member Author

@varkor varkor commented May 6, 2019

I've resolved several remaining FIXMEs. Let's leave it there and resolve the remaining issues in separate pull requests.

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned nikomatsakis May 6, 2019
ConstValue::Param(ParamConst { name, .. }) => {
write!(output, "{}", name).unwrap();
ConstValue::Scalar(..) | ConstValue::Slice(..) | ConstValue::ByRef(..) => {
// FIXME(const_generics): we could probably do a better job here.

This comment has been minimized.

@eddyb

eddyb May 6, 2019
Member

This whole infrastructure should be rewritten to use ty::print, can you open an issue about that?

This comment has been minimized.

@varkor

varkor May 6, 2019
Author Member

Opened #60582.

@mark-i-m
Copy link
Member

@mark-i-m mark-i-m commented May 6, 2019

But as they gazed upon that which claimed to be the Beginning,

it was rebased, the inevitable conclusion of all epic journeys in the land of git. And thus concluded the Genesis of Generic Germination.

varkor and others added 2 commits May 6, 2019
Co-Authored-By: Gabriel Smith <yodaldevoid@users.noreply.github.com>
@varkor varkor force-pushed the varkor:const-generics-redux branch from 32965a7 to 9a2772a May 6, 2019
@eddyb
eddyb approved these changes May 6, 2019
@eddyb
Copy link
Member

@eddyb eddyb commented May 6, 2019

@bors r+

@bors
Copy link
Contributor

@bors bors commented May 6, 2019

📌 Commit 9a2772a has been approved by eddyb

@bors
Copy link
Contributor

@bors bors commented May 6, 2019

Testing commit 9a2772a with merge a19cf18...

bors added a commit that referenced this pull request May 6, 2019
The Genesis of Generic Germination

*Long had its coming been foretold: a collaborative effort with @yodaldevoid, set in motion by @jplatte, to beget a new Kind: one of a very different Sort to those that come before it. Amidst promises of ineffable powers previously thought unobtainable, few dared believe that the prophecies were true. But as they gazed upon that which claimed to be the Beginning, a few gentle sparks of hope fluttered deep within. It was not Time yet. But it was a Sign. And maybe, for some, that was enough.*

There's a long way to go, but we're at the point where we would benefit from GitHub's reviewing capabilities.

r? @eddyb
@bors
Copy link
Contributor

@bors bors commented May 6, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: eddyb
Pushing a19cf18 to master...

@bors bors added the merged-by-bors label May 6, 2019
@bors bors merged commit 9a2772a into rust-lang:master May 6, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@rust-highfive
Copy link
Collaborator

@rust-highfive rust-highfive commented May 6, 2019

📣 Toolstate changed by #53645!

Tested on commit a19cf18.
Direct link to PR: #53645

💔 rls on windows: test-pass → test-fail (cc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request May 6, 2019
Tested on commit rust-lang/rust@a19cf18.
Direct link to PR: <rust-lang/rust#53645>

💔 rls on windows: test-pass → test-fail (cc @Xanewok, @rust-lang/infra).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet