Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[WIP] The Genesis of Generic Germination #53645
Conversation
rust-highfive
assigned
eddyb
Aug 23, 2018
rust-highfive
added
the
S-waiting-on-review
label
Aug 23, 2018
This comment was marked as off-topic.
This comment was marked as off-topic.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This comment has been minimized.
This comment has been minimized.
|
|
QuietMisdreavus
referenced this pull request
Aug 27, 2018
Merged
Don't show associated const value anymore #53409
mark-i-m
referenced this pull request
Aug 27, 2018
Open
Tracking issue for const generics (RFC 2000) #44580
This comment has been minimized.
This comment has been minimized.
|
(Somehow I read the title as "Genesis of Germanic Germination" and thought why we're adding i18n into rustc itself |
petrochenkov
self-assigned this
Aug 28, 2018
petrochenkov
reviewed
Aug 31, 2018
src/libsyntax/parse/parser.rs Outdated
petrochenkov
reviewed
Aug 31, 2018
src/libsyntax/parse/parser.rs Outdated
petrochenkov
reviewed
Aug 31, 2018
src/libsyntax/parse/parser.rs Outdated
petrochenkov
reviewed
Aug 31, 2018
| // parsing problem. Either mark all const args with const (or | ||
| // something else, it doesn't really matter) or merge const args | ||
| // and type args together at the AST level and separate them | ||
| // later on, probably when lowering to the HIR. |
This comment has been minimized.
This comment has been minimized.
petrochenkov
Aug 31, 2018
Contributor
If S<MY_CONST> is supposed to work, then it can use same approach as identifiers in patterns.
In AST it's PatKind::Ident, but in HIR it's turned into a proper pattern based on resolution, for const arguments it would be something like ast::GenericArg::Ident.
I agree this is not necessary to do in this PR though.
petrochenkov
reviewed
Sep 1, 2018
src/libsyntax/parse/parser.rs Outdated
petrochenkov
removed their assignment
Sep 1, 2018
This comment has been minimized.
This comment has been minimized.
|
(Note for triage: I'm going to get around to addressing these comments and hopefully fixing the existing crashes soon.) |
TimNN
added
S-waiting-on-author
and removed
S-waiting-on-review
labels
Sep 11, 2018
petrochenkov
referenced this pull request
Sep 20, 2018
Open
Make the turbofish syntax redundant #2544
This comment has been minimized.
This comment has been minimized.
|
Ping from triage! Since it's been I while, I was wondering if you could give us a small update on the status of this PR? |
This comment has been minimized.
This comment has been minimized.
|
I'm going to start investigating the ICE again soon (been busier than I expected). I think @eddyb's going to be leaving some comments soon as well. |
This comment has been minimized.
This comment has been minimized.
|
Ping from triage! Since it's been I while, I was wondering if you could give us a small update on the status of this PR? |
This comment has been minimized.
This comment has been minimized.
|
I've made progress in my local branch since last time, though not quite ready to push. I think a full review will be unlikely before the 2018 edition though, as things are getting busy close to the deadline. |
varkor
force-pushed the
varkor:const-generics-redux
branch
from
f0bae41
to
bfc4b41
Oct 16, 2018
This comment has been minimized.
This comment has been minimized.
|
@vakor: Thanks for the update! |
ExpHP
referenced this pull request
Oct 25, 2018
Closed
False warning with #[warn(unused_imports)] for std::ops::Deref #51556
TimNN
added
the
A-allocators
label
Oct 30, 2018
yodaldevoid
and others
added some commits
Jan 1, 2019
yodaldevoid
force-pushed the
varkor:const-generics-redux
branch
from
42bdd2f
to
bb9fc94
Feb 1, 2019
This comment has been minimized.
This comment has been minimized.
|
Ok, that may have been the most annoying rebase I have had to deal with so far, but it is done. We have a few failing tests outside of the const-generic ones. Most of these tests have to do with catching problems with the order of generics as that has been messed with. |
This comment has been minimized.
This comment has been minimized.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This comment has been minimized.
This comment has been minimized.
|
|
varkor commentedAug 23, 2018
Long had its coming been foretold: a collaborative effort with @yodaldevoid, set in motion by @jplatte, to beget a new Kind: one of a very different Sort to those that come before it. Amidst promises of ineffable powers previously thought unobtainable, few dared believe that the prophecies were true. But as they gazed upon that which claimed to be the Beginning, a few gentle sparks of hope fluttered deep within. It was not Time yet. But it was a Sign. And maybe, for some, that was enough.
There's a long way to go, but we're at the point where we would benefit from GitHub's reviewing capabilities.
r? @eddyb