Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The push_* printing in librustc_monomorphize should use the printing infrastructure #60582

Closed
varkor opened this issue May 6, 2019 · 2 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@varkor
Copy link
Member

varkor commented May 6, 2019

E.g. push_const_name here:

pub fn push_const_name(&self, c: &Const<'tcx>, output: &mut String, debug: bool) {

See #53645 (comment).

@varkor varkor added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-const-generics Area: const generics (parameters and arguments) labels May 6, 2019
@jonas-schievink jonas-schievink added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 6, 2019
@eddyb
Copy link
Member

eddyb commented May 6, 2019

I didn't mean const printing, sorry. But rather that entire push_* stuff, which was hacked together for the monomorphization collector but can now use the printing infrastructure.

@varkor varkor removed the A-const-generics Area: const generics (parameters and arguments) label May 11, 2019
@varkor varkor changed the title Use ty::print infrastructure for const printing The push_* printing in librustc_monomorphize should use the printing infrastructure May 11, 2019
@Mark-Simulacrum
Copy link
Member

This code now lives in https://github.com/rust-lang/rust/blob/929b48ec98aaff2239257574b5897f419cec2647/src/librustc/ty/print/obsolete.rs as far as I can tell, so this is probably a duplicate of #61139 at this point. Closing as such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants