Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic when using mem::uninitialized or mem::zeroed on an uninhabited type #54667

Merged
merged 11 commits into from
Oct 1, 2018
Merged

Panic when using mem::uninitialized or mem::zeroed on an uninhabited type #54667

merged 11 commits into from
Oct 1, 2018

Conversation

RalfJung
Copy link
Member

All code by @japaric. This re-submits one half of #53508. This is likely not the one that introduced the perf regression, but just to be sure I'll do a perf run anyway.

@rust-highfive
Copy link
Collaborator

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 29, 2018
@RalfJung RalfJung mentioned this pull request Sep 29, 2018
Merged
@RalfJung
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Sep 29, 2018

⌛ Trying commit a1a74ab5ad7fae002fe65b388a19be7275536871 with merge cd661db2bccbe284334ee486254891e2858a667a...

@bors
Copy link
Contributor

bors commented Sep 29, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2018
@RalfJung
Copy link
Member Author

It got cancelled by another try build. Try again.

@bors try

@RalfJung
Copy link
Member Author

@bors retry

@bors
Copy link
Contributor

bors commented Sep 29, 2018

⌛ Trying commit a1a74ab5ad7fae002fe65b388a19be7275536871 with merge 31ec4bcad01a3a5f6214474912ec7f53478414d7...

@rust-highfive

This comment has been minimized.

Sign in to view
@RalfJung
Copy link
Member Author

Dang, it's that gdb test again. :/ @japaric any idea?

@RalfJung
Copy link
Member Author

Oh I see. I put all commits related to that test into the other PR because I though it was only about the changed data structures. But it is also about this panic.

@RalfJung RalfJung added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 29, 2018
@RalfJung
Copy link
Member Author

@rust-timer build 31ec4bcad01a3a5f6214474912ec7f53478414d7

@rust-timer
Copy link
Collaborator

Success: Queued 31ec4bcad01a3a5f6214474912ec7f53478414d7 with parent 7e7bc06, comparison URL.

@scottmcm
Copy link
Member

Perf came back; looks clean to me.

@bors

This comment has been minimized.

Sign in to view
@RalfJung RalfJung added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 30, 2018
@oli-obk
Copy link
Contributor

oli-obk commented Oct 1, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Oct 1, 2018

📌 Commit dd65d73 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2018
@bors
Copy link
Contributor

bors commented Oct 1, 2018

⌛ Testing commit dd65d73 with merge 48e45914f2f6dc7499fee2c031c06cf4b4c5ddf7...

@pnkfelix
Copy link
Member

pnkfelix commented Oct 1, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Oct 1, 2018

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.

@bors
Copy link
Contributor

bors commented Oct 1, 2018

📌 Commit dd65d73 has been approved by pnkfelix

@bors
Copy link
Contributor

bors commented Oct 1, 2018

⌛ Testing commit dd65d73 with merge de3d640...

bors added a commit that referenced this pull request Oct 1, 2018
@bors
Auto merge of #54667 - RalfJung:maybe-uninit, r=pnkfelix
de3d640 
Panic when using mem::uninitialized or mem::zeroed on an uninhabited type

All code by @japaric. This re-submits one half of #53508. This is likely not the one that introduced the perf regression, but just to be sure I'll do a perf run anyway.
@bors
Copy link
Contributor

bors commented Oct 1, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: pnkfelix
Pushing de3d640 to master...

@bors bors merged commit dd65d73 into rust-lang:master Oct 1, 2018
This was referenced Oct 1, 2018
Closed
Closed
@RalfJung RalfJung mentioned this pull request Oct 1, 2018
Closed
3 tasks
bors added a commit that referenced this pull request Oct 8, 2018
@bors
Auto merge of #54668 - RalfJung:use-maybe-uninit, r=<try>
d4c1752 
Use MaybeUninit

All code by @japaric. This re-submits the second half of #53508 (the first half is at #54667). This is likely the one containing the perf regression.
bors added a commit that referenced this pull request Oct 10, 2018
@bors
Auto merge of #54668 - RalfJung:use-maybe-uninit, r=<try>
9177334 
Use MaybeUninit in libcore

All code by @japaric. This re-submits the second half of #53508 (the first half is at #54667). This is likely the one containing the perf regression.
@RalfJung RalfJung deleted the maybe-uninit branch November 9, 2018 15:35
bors added a commit that referenced this pull request Nov 26, 2018
@bors
Auto merge of #54668 - RalfJung:use-maybe-uninit, r=SimonSapin
75d937c 
Use MaybeUninit in libcore

All code by @japaric. This re-submits the second half of #53508 (the first half is at #54667). This is likely the one containing the perf regression.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cramertj cramertj

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@RalfJung @rust-highfive @bors @rust-timer @scottmcm @oli-obk @pnkfelix @cramertj @japaric