Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLL says "borrowed content" instead of more precise "dereference of raw pointer" #54825

Merged
merged 1 commit into from Oct 12, 2018

Conversation

Projects
None yet
6 participants
@davidtwco
Copy link
Member

davidtwco commented Oct 4, 2018

Part of #52663.

Previously, move errors involving the dereference of a raw pointer would
say "borrowed content". This commit changes it to say "dereference of
raw pointer".

r? @nikomatsakis
cc @pnkfelix

@bors

This comment was marked as outdated.

Copy link
Contributor

bors commented Oct 5, 2018

☔️ The latest upstream changes (presumably #54703) made this pull request unmergeable. Please resolve the merge conflicts.

@davidtwco davidtwco force-pushed the davidtwco:issue-52663-deref-raw-pointer branch from 0561631 to 9d1b337 Oct 5, 2018

@memoryruins memoryruins added the A-NLL label Oct 6, 2018

Move errors specify "dereference of raw pointer".
Previously, move errors involving the dereference of a raw pointer would
say "borrowed content". This commit changes it to say "dereference of
raw pointer".

@davidtwco davidtwco force-pushed the davidtwco:issue-52663-deref-raw-pointer branch from 9d1b337 to fe8ace8 Oct 8, 2018

@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Oct 11, 2018

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 11, 2018

📌 Commit fe8ace8 has been approved by pnkfelix

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Oct 11, 2018

Rollup merge of rust-lang#54825 - davidtwco:issue-52663-deref-raw-poi…
…nter, r=pnkfelix

NLL says "borrowed content" instead of more precise "dereference of raw pointer"

Part of rust-lang#52663.

Previously, move errors involving the dereference of a raw pointer would
say "borrowed content". This commit changes it to say "dereference of
raw pointer".

r? @nikomatsakis
cc @pnkfelix

bors added a commit that referenced this pull request Oct 11, 2018

Auto merge of #54990 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
Rollup of 14 pull requests

Successful merges:

 - #54755 (Documents reference equality by address (#54197))
 - #54811 (During rustc bootstrap, make default for `optimize` independent of `debug`)
 - #54825 (NLL says "borrowed content" instead of more precise "dereference of raw pointer")
 - #54860 (Add doc comments about safest way to initialize a vector of zeros)
 - #54891 (Fix tracking issue for Once::is_completed)
 - #54913 (doc fix: it's auto traits that make for automatic implementations)
 - #54916 (submodules: update clippy, rls and cargo, fix toolstate)
 - #54917 (Unused result warning: "X which must" ↦ "X that must")
 - #54920 (Fix handling of #[must_use] on unit and uninhabited types)
 - #54932 (A handful of random string-related improvements)
 - #54936 (impl Eq+Hash for TyLayout)
 - #54956 ("(using ..." doesn't have the matching ")")
 - #54958 (add a macro for static (compile-time) assertions)
 - #54967 (Remove incorrect span for second label inner macro invocation)

Failed merges:

r? @ghost

kennytm added a commit to kennytm/rust that referenced this pull request Oct 12, 2018

Rollup merge of rust-lang#54825 - davidtwco:issue-52663-deref-raw-poi…
…nter, r=pnkfelix

NLL says "borrowed content" instead of more precise "dereference of raw pointer"

Part of rust-lang#52663.

Previously, move errors involving the dereference of a raw pointer would
say "borrowed content". This commit changes it to say "dereference of
raw pointer".

r? @nikomatsakis
cc @pnkfelix

bors added a commit that referenced this pull request Oct 12, 2018

Auto merge of #55012 - kennytm:rollup, r=kennytm
Rollup of 16 pull requests

Successful merges:

 - #54755 (Documents reference equality by address (#54197))
 - #54811 (During rustc bootstrap, make default for `optimize` independent of `debug`)
 - #54825 (NLL says "borrowed content" instead of more precise "dereference of raw pointer")
 - #54860 (Add doc comments about safest way to initialize a vector of zeros)
 - #54869 (Fix mobile docs)
 - #54891 (Fix tracking issue for Once::is_completed)
 - #54913 (doc fix: it's auto traits that make for automatic implementations)
 - #54920 (Fix handling of #[must_use] on unit and uninhabited types)
 - #54932 (A handful of random string-related improvements)
 - #54936 (impl Eq+Hash for TyLayout)
 - #54950 (std: Synchronize global allocator on wasm32)
 - #54956 ("(using ..." doesn't have the matching ")")
 - #54958 (add a macro for static (compile-time) assertions)
 - #54967 (Remove incorrect span for second label inner macro invocation)
 - #54983 (Fix slice's benchmarks)
 - #54989 (Fix spelling in the documentation to htmldocck.py)

Failed merges:

r? @ghost

@bors bors merged commit fe8ace8 into rust-lang:master Oct 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davidtwco davidtwco deleted the davidtwco:issue-52663-deref-raw-pointer branch Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.