Fix handling of #[must_use] on unit and uninhabited types #54920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
varkor
force-pushed
the
must_use-unit
branch
2 times, most recently
from
e4dd87a
to
6c785a6
Compare
varkor
commented
Oct 8, 2018
| let ty_warned = match t.sty { | ||
| ty::Tuple(ref tys) if tys.is_empty() => return, | ||
| ty::Never => return, | ||
| // FIXME(varkor): replace with `t.is_unit() || t.conservative_is_uninhabited()`. |
There was a problem hiding this comment.
I'll fix this as part of #54125.
This comment has been minimized.
This comment has been minimized.
|
@bors r+ rollup |
|
📌 Commit be88961 has been approved by |
bors
added
S-waiting-on-bors
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Oct 9, 2018
Fix handling of #[must_use] on unit and uninhabited types Fixes rust-lang#54828.
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Oct 11, 2018
Fix handling of #[must_use] on unit and uninhabited types Fixes rust-lang#54828.
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 12, 2018
Fix handling of #[must_use] on unit and uninhabited types Fixes rust-lang#54828.
bors
added a commit
that referenced
this pull request
Oct 12, 2018
Rollup of 16 pull requests Successful merges: - #54755 (Documents reference equality by address (#54197)) - #54811 (During rustc bootstrap, make default for `optimize` independent of `debug`) - #54825 (NLL says "borrowed content" instead of more precise "dereference of raw pointer") - #54860 (Add doc comments about safest way to initialize a vector of zeros) - #54869 (Fix mobile docs) - #54891 (Fix tracking issue for Once::is_completed) - #54913 (doc fix: it's auto traits that make for automatic implementations) - #54920 (Fix handling of #[must_use] on unit and uninhabited types) - #54932 (A handful of random string-related improvements) - #54936 (impl Eq+Hash for TyLayout) - #54950 (std: Synchronize global allocator on wasm32) - #54956 ("(using ..." doesn't have the matching ")") - #54958 (add a macro for static (compile-time) assertions) - #54967 (Remove incorrect span for second label inner macro invocation) - #54983 (Fix slice's benchmarks) - #54989 (Fix spelling in the documentation to htmldocck.py) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54828.