-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rustc Book] Explain --cfg's arguments #55111
Conversation
“The grain” here isn’t intentional, it’s an artifact of me just trying to get the basics in place, and not having done much else yet.
… On Oct 15, 2018, at 9:40 PM, Ryan Scheel ***@***.***> wrote:
I removed this from the reference since it's rustc specific, and noticed it wasn't well documented on the page that should document it well. It does seem to go against the grain of one line per command line flag though.
r? @GuillaumeGomez
You can view, comment on, or merge this pull request online at:
#55111
Commit Summary
[Rustc Book] Explain --cfg's arguments
File Changes
M src/doc/rustc/src/command-line-arguments.md (5)
Patch Links:
https://github.com/rust-lang/rust/pull/55111.patch
https://github.com/rust-lang/rust/pull/55111.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@@ -10,6 +10,11 @@ This flag will print out help information for `rustc`. | |||
|
|||
This flag can turn on or off various `#[cfg]` settings. | |||
|
|||
The value can either be a single identifier or two identifiers separated by `=`. | |||
|
|||
For examples, `--cfg 'verbose'` or `--cfg 'feature=serde'`. These correspond |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--cfg feature=serde
is incorrect, you need a string literal for the value - --cfg feature = "serde"
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--cfg
argument (after shell preprocessing, etc) is literally a meta-item, same thing as in #[cfg(feature = "serde")]
and with the same restrictions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops. Thought I put those quotes in there. Should have just copy-pasted from the cargo build --verbose
output...
Seems good to me. r=me once CI is green. Thanks! |
Travis is green. @bors r=GuillaumeGomez rollup |
📌 Commit 8c186af has been approved by |
…illaumeGomez [Rustc Book] Explain --cfg's arguments I removed this from the reference since it's rustc specific, and noticed it wasn't well documented on the page that should document it well. It does seem to go against the grain of one line per command line flag though.
Rollup of 18 pull requests Successful merges: - #54646 (improve documentation on std::thread::sleep) - #54933 (Cleanup the rest of codegen_llvm) - #54964 (Run both lldb and gdb tests) - #55016 (Deduplicate some code and compile-time values around vtables) - #55031 (Improve verify_llvm_ir config option) - #55050 (doc std::fmt: the Python inspiration is already mentioned in precedin…) - #55077 (rustdoc: Use dyn keyword when rendering dynamic traits) - #55080 (Detect if access to localStorage is forbidden by the user's browser) - #55090 (regression test for move out of borrow via pattern) - #55102 (resolve: Do not skip extern prelude during speculative resolution) - #55104 (Add test for #34229) - #55111 ([Rustc Book] Explain --cfg's arguments) - #55122 (Cleanup mir/borrowck) - #55127 (Remove HybridBitSet::dummy) - #55128 (Fix LLVMRustInlineAsmVerify return type mismatch) - #55142 (miri: layout should not affect CTFE checks (outside of validation)) - #55151 (Cleanup nll) - #55161 ([librustdoc] Disable spellcheck for search field)
I removed this from the reference since it's rustc specific, and noticed it wasn't well documented on the page that should document it well. It does seem to go against the grain of one line per command line flag though.
r? @GuillaumeGomez