[librustdoc] Disable spellcheck for search field #55161
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @QuietMisdreavus (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Oh nice! This makes perfect sense to me, since the things you type in there wind up being abbreviations, or combinations of words, or something else that's likely to not be in a spellcheck dictionary. I'd like to have @GuillaumeGomez take a look, but otherwise i like this. |
|
Side note: perhaps it would be a good idea to move the HTML to an actual HTML file and use If this is a good idea, I'm happy to submit a separate PR for this. |
|
@akxcv It's currently not really a good idea. We're currently in a (veeeeeery slow) code improvement process in rustdoc. Once done, we'll need to think on a few things like:
It'll come, but we don't know when. :) |
|
And I forgot: thanks for the PR, looks good to me (and I learned something new, didn't know about this option)! @bors: r=QuietMisdreavus,GuillaumeGomez rollup |
|
📌 Commit c55e1e6 has been approved by |
bors
added
S-waiting-on-bors
I'd love to learn more about it! Where can I find a roadmap or something? |
…=QuietMisdreavus,GuillaumeGomez [librustdoc] Disable spellcheck for search field This disables spellchecking for the search field in the rustdoc web interface. As someone who uses Safari to browse through Rust docs, spellchecking gets really annoying.
Rollup of 18 pull requests Successful merges: - #54646 (improve documentation on std::thread::sleep) - #54933 (Cleanup the rest of codegen_llvm) - #54964 (Run both lldb and gdb tests) - #55016 (Deduplicate some code and compile-time values around vtables) - #55031 (Improve verify_llvm_ir config option) - #55050 (doc std::fmt: the Python inspiration is already mentioned in precedin…) - #55077 (rustdoc: Use dyn keyword when rendering dynamic traits) - #55080 (Detect if access to localStorage is forbidden by the user's browser) - #55090 (regression test for move out of borrow via pattern) - #55102 (resolve: Do not skip extern prelude during speculative resolution) - #55104 (Add test for #34229) - #55111 ([Rustc Book] Explain --cfg's arguments) - #55122 (Cleanup mir/borrowck) - #55127 (Remove HybridBitSet::dummy) - #55128 (Fix LLVMRustInlineAsmVerify return type mismatch) - #55142 (miri: layout should not affect CTFE checks (outside of validation)) - #55151 (Cleanup nll) - #55161 ([librustdoc] Disable spellcheck for search field)
|
Euh... @QuietMisdreavus and I are the roadmap? XD |
|
Sadly the roadmap is effectively "what the two of us are most bothered by at the moment". I'd love to get a discussion together to try and focus our development. I haven't taken the opportunity to sketch something out, though. |
|
I'd be happy to participate! I can't promise anything, but I think I might be able to help somewhat. Should I find you on IRC or something? |
|
We're most active on Discord nowadays, if you want to hop on and have a chat. A real roadmap chat will probably happen in a GitHub issue somewhere, but for something slightly more synchronous, that's the current best option. |
This disables spellchecking for the search field in the rustdoc web interface.
As someone who uses Safari to browse through Rust docs, spellchecking gets really annoying.