Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #55710

Merged
merged 42 commits into from
Nov 6, 2018
Merged

Rollup of 11 pull requests #55710

merged 42 commits into from
Nov 6, 2018

Commits on Oct 29, 2018

  1. Configuration menu
    Copy the full SHA
    dd68685 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2018

  1. std: Enable usage of thread_local! through imports

    The `thread_local!` macro delegated to an internal macro but it didn't
    do so in a macros-and-the-module-system compatible fashion, meaning if a
    `#![no_std]` crate imported `std` and tried to use `thread_local!` it
    would fail due to missing a lookup of an internal macro.
    
    This commit switches the macro to instead use `$crate` to invoke other
    macros, ensuring that it'll work when `thread_local!` is imported alone.
    alexcrichton committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    ff5226c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    89cf577 View commit details
    Browse the repository at this point in the history
  3. Remove deprecated unstable #[panic_implementation]

    It was superseded by `#[panic_handler]`
    petrochenkov committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    29d2cea View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2018

  1. Configuration menu
    Copy the full SHA
    e04e5fa View commit details
    Browse the repository at this point in the history
  2. Make "all possible cases" help message uniform with existing help mes…

    …sages
    
    Specifically no capitalisation or trailing full stops.
    varkor committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    8277ba2 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2018

  1. Configuration menu
    Copy the full SHA
    424fecd View commit details
    Browse the repository at this point in the history
  2. Correct indentation on documentation comment.

    This commit adjusts the indentation of code within a documentation
    comment so that it is correctly highlighted as code by rustdoc.
    davidtwco committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    1854dde View commit details
    Browse the repository at this point in the history
  3. Update test to force error under NLL.

    In each of the three cases in this test, there is a mutable borrow
    of some field of the union and then a shared borrow of some other field
    immediately following.
    
    Under NLL, the mutable borrow is killed straight away as it isn't
    used later - therefore not causing a conflict with the shared borrow.
    This commit adds a use of the first mutable borrow to force the intended
    errors to appear under NLL.
    davidtwco committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    ba09ed5 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2018

  1. Configuration menu
    Copy the full SHA
    c905497 View commit details
    Browse the repository at this point in the history
  2. Add test

    Add test for incompleately implemented add trait, see issue rust-lang#31076
    jsirs committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    2a1dc1e View commit details
    Browse the repository at this point in the history
  3. self.associated_item can return none

    self.associated_item can return none, replace unwrap with '?' and bubble up None value instead of panicking
    jsirs committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    4a08333 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9fb2e06 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    87c22f2 View commit details
    Browse the repository at this point in the history
  6. Switch to using revisions in borrowck-lend-flow-loop.rs

    Most of the time we want to robustify tests, but in this case this
    test is deliberately encoding artifacts of AST-borrowck.  So instead
    of adding artificial uses that would obscure the aspects of
    AST-borrowck that are being tests, we instead use revisions and then
    mark the cases that apply to NLL as well as AST-borrowck.
    pnkfelix committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    5f524ed View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cd52b3c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    affddf6 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    9f9bf94 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    6c7d82e View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    9843a38 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    41a1ee9 View commit details
    Browse the repository at this point in the history
  13. Remove println!'s from ui/issues/issue-52126-assign-op-invariance.rs

    This is not strictly necessary to make this test "more robust with
    respect to NLL"; its just an attempt to narrow the scope of the test
    and focus on its core.
    pnkfelix committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    62a2bb1 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    e940801 View commit details
    Browse the repository at this point in the history
  15. Removed overlapping_spans.{rs,stderr,nll.stderr}.

    This is based on the feedback from estebank:
    
    """
    I believe that test can be removed outright. It'd be impossible for a
    new change to go through that breaks this kind of output without it
    being picked up by multiple other `stderr` tests. This is an artifact
    of the transition period to the "new" output style.
    """
    
    see: rust-lang#52663 (comment)
    pnkfelix committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    f7ded5d View commit details
    Browse the repository at this point in the history
  16. Add ui/borrowck/borrowck-closures-mut-of-mut.rs.

    This is a variant of `ui/borrowck/borrowck-closures-mut-of-imm.rs`
    that I used to help identify what changes I needed to make to the
    latter file in order to recover its instances of E0524 under NLL.
    
    (Basically this test includes the changes you'd need to make to
    `ui/borrowck/borrowck-closures-mut-of-imm.rs` in order to get rid of
    occurrences of E0596. And then I realized that one needs to add
    invocations of the closures in order to properly extend the mutable
    reborrows in a manner such that NLL will roughly match AST-borrowck.)
    pnkfelix committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    fe29cd0 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    c25319f View commit details
    Browse the repository at this point in the history
  18. Use // revisions in the dropck-eyepatch tests instead of relying on…

    … compare-mode=nll.
    
    NLL has increased precision in its analysis of drop order, and we want
    the test annotations to deliberately reflect this by having fewer
    ERROR annotations for NLL than for AST-borrowck. The best way to get
    this effect is via `// revisions`.
    
    As a drive-by, also added uses of all the borrows just to make it
    clear that NLL isn't somehow sidestepping things by using shorter
    borrows than you might have otherwise expected. (Of course, the added
    uses do not make all that much difference since the relevant types all
    declare `impl Drop` and thus those drops have implicit uses anyway.)
    pnkfelix committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    cf71582 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    b75fbbf View commit details
    Browse the repository at this point in the history
  20. add call to tcx.sess.delay_span_bug

    add call to tcx.sess.delay_span_bug before returning none to make sure error is presented to user
    jsirs committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    3063977 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    fff9dde View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    034a0eb View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2018

  1. Rollup merge of rust-lang#55490 - petrochenkov:resolveice, r=eddyb

    resolve: Fix ICE in macro import error recovery
    
    Fixes rust-lang#55457
    kennytm committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    1525b0e View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#55597 - alexcrichton:thread-local-inner, r=…

    …KodrAus
    
    std: Enable usage of `thread_local!` through imports
    
    The `thread_local!` macro delegated to an internal macro but it didn't
    do so in a macros-and-the-module-system compatible fashion, meaning if a
    `#![no_std]` crate imported `std` and tried to use `thread_local!` it
    would fail due to missing a lookup of an internal macro.
    
    This commit switches the macro to instead use `$crate` to invoke other
    macros, ensuring that it'll work when `thread_local!` is imported alone.
    kennytm committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    462f63e View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#55601 - petrochenkov:featissue, r=pnkfelix

    Fix tracking issue numbers for some unstable features
    
    And also remove deprecated unstable `#[panic_implementation]` attribute that was superseded by stable `#[panic_handler]` and doesn't have an open tracking issue.
    kennytm committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    6091696 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#55621 - GuillaumeGomez:create-dir, r=QuietM…

    …isdreavus
    
    Add precision for create_dir function
    
    Took me a while to find the other equivalent so it seems to be necessary.
    
    r? @QuietMisdreavus
    kennytm committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    082156b View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#55644 - glaubitz:powerpcspe-linux, r=alexcr…

    …ichton
    
    ci: Add Dockerfile for dist-powerpcspe-linux
    
    This adds the Dockerfile for cross-building Rust for the powerpcspe target. It's currently disabled.
    kennytm committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    225df14 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#55664 - varkor:all-possible-cases-message, …

    …r=zackmdavis
    
    Make "all possible cases" help message uniform with existing help messages
    
    Specifically no capitalisation or trailing full stops.
    kennytm committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    435aca1 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#55689 - RalfJung:miri-immediate, r=oli-obk

    miri: binary_op_val -> binary_op_imm
    
    Seems like this was overlooked during the value -> immediate rename.
    
    r? @oli-obk
    kennytm committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    8b3d9e5 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    54bc9c2 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#55696 - davidtwco:issue-55675, r=pnkfelix

    NLL Diagnostic Review 3: Missing errors for borrows of union fields
    
    Fixes rust-lang#55675.
    
    This PR modifies a test to make it more robust (it also fixes indentation on a doc comment, but that's not the point of the PR). See the linked issue for details.
    
    r? @pnkfelix
    kennytm committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    1ea1a42 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#55700 - pnkfelix:issue-55533-update-ui-test…

    …s-wrt-nll, r=davidtwco
    
    Update ui tests with respect to NLL
    
    Fix rust-lang#55533
    kennytm committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    6231720 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#55703 - pnkfelix:update-configure-help-to-r…

    …eflect-pr-54811, r=Mark-Simulacrum
    
    Update `configure --help` (via configure.py) to reflect decoupling of debug+optimize
    
    This should have been part of PR rust-lang#54811 (my bad).
    kennytm committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    8589ca0 View commit details
    Browse the repository at this point in the history