-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 11 pull requests #55710
Rollup of 11 pull requests #55710
Commits on Oct 29, 2018
-
Configuration menu - View commit details
-
Copy full SHA for dd68685 - Browse repository at this point
Copy the full SHA dd68685View commit details
Commits on Nov 1, 2018
-
std: Enable usage of
thread_local!
through importsThe `thread_local!` macro delegated to an internal macro but it didn't do so in a macros-and-the-module-system compatible fashion, meaning if a `#![no_std]` crate imported `std` and tried to use `thread_local!` it would fail due to missing a lookup of an internal macro. This commit switches the macro to instead use `$crate` to invoke other macros, ensuring that it'll work when `thread_local!` is imported alone.
Configuration menu - View commit details
-
Copy full SHA for ff5226c - Browse repository at this point
Copy the full SHA ff5226cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 89cf577 - Browse repository at this point
Copy the full SHA 89cf577View commit details -
Remove deprecated unstable
#[panic_implementation]
It was superseded by `#[panic_handler]`
Configuration menu - View commit details
-
Copy full SHA for 29d2cea - Browse repository at this point
Copy the full SHA 29d2ceaView commit details
Commits on Nov 3, 2018
-
Configuration menu - View commit details
-
Copy full SHA for e04e5fa - Browse repository at this point
Copy the full SHA e04e5faView commit details -
Make "all possible cases" help message uniform with existing help mes…
…sages Specifically no capitalisation or trailing full stops.
Configuration menu - View commit details
-
Copy full SHA for 8277ba2 - Browse repository at this point
Copy the full SHA 8277ba2View commit details
Commits on Nov 4, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 424fecd - Browse repository at this point
Copy the full SHA 424fecdView commit details -
Correct indentation on documentation comment.
This commit adjusts the indentation of code within a documentation comment so that it is correctly highlighted as code by rustdoc.
Configuration menu - View commit details
-
Copy full SHA for 1854dde - Browse repository at this point
Copy the full SHA 1854ddeView commit details -
Update test to force error under NLL.
In each of the three cases in this test, there is a mutable borrow of some field of the union and then a shared borrow of some other field immediately following. Under NLL, the mutable borrow is killed straight away as it isn't used later - therefore not causing a conflict with the shared borrow. This commit adds a use of the first mutable borrow to force the intended errors to appear under NLL.
Configuration menu - View commit details
-
Copy full SHA for ba09ed5 - Browse repository at this point
Copy the full SHA ba09ed5View commit details
Commits on Nov 5, 2018
-
Configuration menu - View commit details
-
Copy full SHA for c905497 - Browse repository at this point
Copy the full SHA c905497View commit details -
Add test for incompleately implemented add trait, see issue rust-lang#31076
Configuration menu - View commit details
-
Copy full SHA for 2a1dc1e - Browse repository at this point
Copy the full SHA 2a1dc1eView commit details -
self.associated_item can return none
self.associated_item can return none, replace unwrap with '?' and bubble up None value instead of panicking
Configuration menu - View commit details
-
Copy full SHA for 4a08333 - Browse repository at this point
Copy the full SHA 4a08333View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fb2e06 - Browse repository at this point
Copy the full SHA 9fb2e06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87c22f2 - Browse repository at this point
Copy the full SHA 87c22f2View commit details -
Switch to using revisions in borrowck-lend-flow-loop.rs
Most of the time we want to robustify tests, but in this case this test is deliberately encoding artifacts of AST-borrowck. So instead of adding artificial uses that would obscure the aspects of AST-borrowck that are being tests, we instead use revisions and then mark the cases that apply to NLL as well as AST-borrowck.
Configuration menu - View commit details
-
Copy full SHA for 5f524ed - Browse repository at this point
Copy the full SHA 5f524edView commit details -
Configuration menu - View commit details
-
Copy full SHA for cd52b3c - Browse repository at this point
Copy the full SHA cd52b3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for affddf6 - Browse repository at this point
Copy the full SHA affddf6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f9bf94 - Browse repository at this point
Copy the full SHA 9f9bf94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c7d82e - Browse repository at this point
Copy the full SHA 6c7d82eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9843a38 - Browse repository at this point
Copy the full SHA 9843a38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41a1ee9 - Browse repository at this point
Copy the full SHA 41a1ee9View commit details -
Remove
println!
's fromui/issues/issue-52126-assign-op-invariance.rs
This is not strictly necessary to make this test "more robust with respect to NLL"; its just an attempt to narrow the scope of the test and focus on its core.
Configuration menu - View commit details
-
Copy full SHA for 62a2bb1 - Browse repository at this point
Copy the full SHA 62a2bb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for e940801 - Browse repository at this point
Copy the full SHA e940801View commit details -
Removed overlapping_spans.{rs,stderr,nll.stderr}.
This is based on the feedback from estebank: """ I believe that test can be removed outright. It'd be impossible for a new change to go through that breaks this kind of output without it being picked up by multiple other `stderr` tests. This is an artifact of the transition period to the "new" output style. """ see: rust-lang#52663 (comment)
Configuration menu - View commit details
-
Copy full SHA for f7ded5d - Browse repository at this point
Copy the full SHA f7ded5dView commit details -
Add
ui/borrowck/borrowck-closures-mut-of-mut.rs
.This is a variant of `ui/borrowck/borrowck-closures-mut-of-imm.rs` that I used to help identify what changes I needed to make to the latter file in order to recover its instances of E0524 under NLL. (Basically this test includes the changes you'd need to make to `ui/borrowck/borrowck-closures-mut-of-imm.rs` in order to get rid of occurrences of E0596. And then I realized that one needs to add invocations of the closures in order to properly extend the mutable reborrows in a manner such that NLL will roughly match AST-borrowck.)
Configuration menu - View commit details
-
Copy full SHA for fe29cd0 - Browse repository at this point
Copy the full SHA fe29cd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c25319f - Browse repository at this point
Copy the full SHA c25319fView commit details -
Use
// revisions
in the dropck-eyepatch tests instead of relying on…… compare-mode=nll. NLL has increased precision in its analysis of drop order, and we want the test annotations to deliberately reflect this by having fewer ERROR annotations for NLL than for AST-borrowck. The best way to get this effect is via `// revisions`. As a drive-by, also added uses of all the borrows just to make it clear that NLL isn't somehow sidestepping things by using shorter borrows than you might have otherwise expected. (Of course, the added uses do not make all that much difference since the relevant types all declare `impl Drop` and thus those drops have implicit uses anyway.)
Configuration menu - View commit details
-
Copy full SHA for cf71582 - Browse repository at this point
Copy the full SHA cf71582View commit details -
Configuration menu - View commit details
-
Copy full SHA for b75fbbf - Browse repository at this point
Copy the full SHA b75fbbfView commit details -
add call to tcx.sess.delay_span_bug
add call to tcx.sess.delay_span_bug before returning none to make sure error is presented to user
Configuration menu - View commit details
-
Copy full SHA for 3063977 - Browse repository at this point
Copy the full SHA 3063977View commit details -
Configuration menu - View commit details
-
Copy full SHA for fff9dde - Browse repository at this point
Copy the full SHA fff9ddeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 034a0eb - Browse repository at this point
Copy the full SHA 034a0ebView commit details
Commits on Nov 6, 2018
-
Rollup merge of rust-lang#55490 - petrochenkov:resolveice, r=eddyb
resolve: Fix ICE in macro import error recovery Fixes rust-lang#55457
Configuration menu - View commit details
-
Copy full SHA for 1525b0e - Browse repository at this point
Copy the full SHA 1525b0eView commit details -
Rollup merge of rust-lang#55597 - alexcrichton:thread-local-inner, r=…
…KodrAus std: Enable usage of `thread_local!` through imports The `thread_local!` macro delegated to an internal macro but it didn't do so in a macros-and-the-module-system compatible fashion, meaning if a `#![no_std]` crate imported `std` and tried to use `thread_local!` it would fail due to missing a lookup of an internal macro. This commit switches the macro to instead use `$crate` to invoke other macros, ensuring that it'll work when `thread_local!` is imported alone.
Configuration menu - View commit details
-
Copy full SHA for 462f63e - Browse repository at this point
Copy the full SHA 462f63eView commit details -
Rollup merge of rust-lang#55601 - petrochenkov:featissue, r=pnkfelix
Fix tracking issue numbers for some unstable features And also remove deprecated unstable `#[panic_implementation]` attribute that was superseded by stable `#[panic_handler]` and doesn't have an open tracking issue.
Configuration menu - View commit details
-
Copy full SHA for 6091696 - Browse repository at this point
Copy the full SHA 6091696View commit details -
Rollup merge of rust-lang#55621 - GuillaumeGomez:create-dir, r=QuietM…
…isdreavus Add precision for create_dir function Took me a while to find the other equivalent so it seems to be necessary. r? @QuietMisdreavus
Configuration menu - View commit details
-
Copy full SHA for 082156b - Browse repository at this point
Copy the full SHA 082156bView commit details -
Rollup merge of rust-lang#55644 - glaubitz:powerpcspe-linux, r=alexcr…
…ichton ci: Add Dockerfile for dist-powerpcspe-linux This adds the Dockerfile for cross-building Rust for the powerpcspe target. It's currently disabled.
Configuration menu - View commit details
-
Copy full SHA for 225df14 - Browse repository at this point
Copy the full SHA 225df14View commit details -
Rollup merge of rust-lang#55664 - varkor:all-possible-cases-message, …
…r=zackmdavis Make "all possible cases" help message uniform with existing help messages Specifically no capitalisation or trailing full stops.
Configuration menu - View commit details
-
Copy full SHA for 435aca1 - Browse repository at this point
Copy the full SHA 435aca1View commit details -
Rollup merge of rust-lang#55689 - RalfJung:miri-immediate, r=oli-obk
miri: binary_op_val -> binary_op_imm Seems like this was overlooked during the value -> immediate rename. r? @oli-obk
Configuration menu - View commit details
-
Copy full SHA for 8b3d9e5 - Browse repository at this point
Copy the full SHA 8b3d9e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54bc9c2 - Browse repository at this point
Copy the full SHA 54bc9c2View commit details -
Rollup merge of rust-lang#55696 - davidtwco:issue-55675, r=pnkfelix
NLL Diagnostic Review 3: Missing errors for borrows of union fields Fixes rust-lang#55675. This PR modifies a test to make it more robust (it also fixes indentation on a doc comment, but that's not the point of the PR). See the linked issue for details. r? @pnkfelix
Configuration menu - View commit details
-
Copy full SHA for 1ea1a42 - Browse repository at this point
Copy the full SHA 1ea1a42View commit details -
Rollup merge of rust-lang#55700 - pnkfelix:issue-55533-update-ui-test…
…s-wrt-nll, r=davidtwco Update ui tests with respect to NLL Fix rust-lang#55533
Configuration menu - View commit details
-
Copy full SHA for 6231720 - Browse repository at this point
Copy the full SHA 6231720View commit details -
Rollup merge of rust-lang#55703 - pnkfelix:update-configure-help-to-r…
…eflect-pr-54811, r=Mark-Simulacrum Update `configure --help` (via configure.py) to reflect decoupling of debug+optimize This should have been part of PR rust-lang#54811 (my bad).
Configuration menu - View commit details
-
Copy full SHA for 8589ca0 - Browse repository at this point
Copy the full SHA 8589ca0View commit details