Make "all possible cases" help message uniform with existing help messages #55664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @zackmdavis (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit a34b19cd39f70608c4e6056bee55086f2a6217d1 has been approved by |
bors
added
S-waiting-on-bors
zackmdavis
previously requested changes
Nov 3, 2018
| @@ -238,8 +238,8 @@ impl<'a, 'tcx> MatchVisitor<'a, 'tcx> { | |||
| is non-empty", | |||
| pat_ty)); | |||
| span_help!(&mut err, scrut.span, | |||
| "Please ensure that all possible cases are being handled; \ | |||
| possibly adding wildcards or more match arms."); | |||
| "ensure that all possible cases are being handled; \ | |||
There was a problem hiding this comment.
Suggested change
| "ensure that all possible cases are being handled; \ | |
| "ensure that all possible cases are being handled, \ |
Actually, while we're here, could we also change this semicolon to a comma? The "possibly by adding" isn't an independent clause.
|
@bors r- |
bors
added
S-waiting-on-author
…sages Specifically no capitalisation or trailing full stops.
varkor
force-pushed
the
all-possible-cases-message
branch
from
a34b19c
to
8277ba2
Compare
|
@bors r=zackmdavis rollup |
|
📌 Commit 8277ba2 has been approved by |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 6, 2018
…r=zackmdavis Make "all possible cases" help message uniform with existing help messages Specifically no capitalisation or trailing full stops.
bors
added a commit
that referenced
this pull request
Nov 6, 2018
Rollup of 11 pull requests Successful merges: - #55490 (resolve: Fix ICE in macro import error recovery) - #55597 (std: Enable usage of `thread_local!` through imports) - #55601 (Fix tracking issue numbers for some unstable features) - #55621 (Add precision for create_dir function) - #55644 (ci: Add Dockerfile for dist-powerpcspe-linux) - #55664 (Make "all possible cases" help message uniform with existing help messages) - #55689 (miri: binary_op_val -> binary_op_imm) - #55694 (Fixes #31076) - #55696 (NLL Diagnostic Review 3: Missing errors for borrows of union fields) - #55700 (Update ui tests with respect to NLL) - #55703 (Update `configure --help` (via configure.py) to reflect decoupling of debug+optimize)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically no capitalisation or trailing full stops.