Improve docs for collecting into Options
#56342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @bluss (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
killercup
commented
Nov 29, 2018
| /// | ||
| /// let res: Option<Vec<u16>> = items | ||
| /// .iter() | ||
| /// .map(|x| x.checked_add(1)) |
There was a problem hiding this comment.
Not sure if this is an obvious function or should be explain more (or use the explicit impl of checked adding as it did previously)
There was a problem hiding this comment.
It seems fine as it is, maybe it comes best together if we mention that checked_add/_sub returns None on overflow, on this example or the next?
killercup
force-pushed
the
collect-into-option-docs
branch
from
dde0d11
to
a8c3553
Compare
Changes the original example to use more idiomatic formatting as well as `.checked_add`. Also adds a second example to show a case where the `.collect` returns `None`.
killercup
force-pushed
the
collect-into-option-docs
branch
from
a8c3553
to
2c0f011
Compare
|
Sorry, totally missed that comment, @bluss! Added this:
|
|
@bors r+ rollup Thanks! |
|
📌 Commit 2c0f011 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 23, 2018
… r=bluss Improve docs for collecting into `Option`s Changes the original example to use more idiomatic formatting as well as `.checked_add`. Also adds a second example to show a case where the `.collect` returns `None`.
bors
added a commit
that referenced
this pull request
Dec 24, 2018
Rollup of 14 pull requests Successful merges: - #56188 (enum type instead of variant suggestion unification ) - #56342 (Improve docs for collecting into `Option`s) - #56916 (Fix mutable references in `static mut`) - #56917 (Simplify MIR generation for logical operations) - #56939 (Pin stabilization) - #56953 (Mark tuple structs as live if their constructors are used) - #56964 (Remove `TokenStream::JointTree`.) - #56966 (Correct strings for raw pointer deref and array access suggestions) - #57020 (Point to cause of `fn` expected return type) - #57032 (fix deprecation warnings in liballoc benches) - #57053 (Fix alignment for array indexing) - #57062 (Fix a comment) - #57067 (Stabilize min_const_unsafe_fn in 1.33) - #57078 (Ignore two tests on s390x) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the original example to use more idiomatic formatting as well
as
.checked_add. Also adds a second example to show a case where the.collectreturnsNone.