Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo the docs for Vec::set_len #56425

Merged
merged 5 commits into from Jan 12, 2019

Conversation

Reviewers

@nagisa nagisa

@Centril Centril

Assignees

@Centril Centril

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
8 participants
@scottmcm @rust-highfive @Dylan-DPC @Centril @bors @pietroalbini @nagisa @bluss
@scottmcm
Copy link
Member

scottmcm commented Dec 2, 2018

Inspired by the recent conversation on IRLO.

This is just my first stab at this; suggestions welcome.
@scottmcm
Redo the docs for Vec::set_len 
Inspired by the recent conversation on IRLO.
Loading status checks…
5c11392

@rust-highfive rust-highfive assigned bluss Dec 2, 2018

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Dec 2, 2018

r? @bluss

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review label Dec 2, 2018

@Centril

Centril reviewed Dec 2, 2018
View changes

Copy link
Contributor

Centril left a comment

Some improvement suggestions. :)
Show resolved Hide resolved src/liballoc/vec.rs Outdated
Show resolved Hide resolved src/liballoc/vec.rs Outdated
Show resolved Hide resolved src/liballoc/vec.rs
Show resolved Hide resolved src/liballoc/vec.rs Outdated
Show resolved Hide resolved src/liballoc/vec.rs Outdated
Show resolved Hide resolved src/liballoc/vec.rs Outdated
Show resolved Hide resolved src/liballoc/vec.rs Outdated
Show resolved Hide resolved src/liballoc/vec.rs
Show resolved Hide resolved src/liballoc/vec.rs
Show resolved Hide resolved src/liballoc/vec.rs Outdated
@Dylan-DPC

This comment has been minimized.

Sign in to view
Copy link
Member

Dylan-DPC commented Dec 10, 2018

ping from triage @scottmcm can you update this with the changes suggested above?
r?@Centril

@rust-highfive rust-highfive assigned Centril and unassigned bluss Dec 10, 2018

@Centril

Centril reviewed Dec 22, 2018
View changes

Show resolved Hide resolved src/liballoc/vec.rs
@Centril @scottmcm
Update src/liballoc/vec.rs 
Add @Centril's comment

Co-Authored-By: scottmcm <scottmcm@users.noreply.github.com>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
61fb909
@scottmcm

This comment has been minimized.

Sign in to view
Copy link
Member Author

scottmcm commented Jan 3, 2019 •
edited

@Centril I'm still on vacation without access to my computer. Can you make proposed changes here so I can apply them from my phone, like I just did your other one?
@Centril

This comment has been minimized.

Sign in to view
Copy link
Contributor

Centril commented Jan 3, 2019

@scottmcm sure, I'll get to it in a bit.
@Centril

This comment has been minimized.

Sign in to view
Copy link
Contributor

Centril commented Jan 9, 2019

@scottmcm made a PR instead: scottmcm#1

@bors delegate+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jan 9, 2019

✌️ @scottmcm can now approve this pull request
@scottmcm
Merge pull request #1 from Centril/redo-vec-set_len-docs-adjust 
Explain safety for `vec.set_len(0)`
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
986e49d
@Centril

This comment has been minimized.

Sign in to view
Copy link
Contributor

Centril commented Jan 9, 2019

@bors r+ rollup
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jan 9, 2019

📌 Commit 986e49d has been approved by Centril

@bors bors added S-waiting-on-bors and removed S-waiting-on-review labels Jan 9, 2019

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jan 10, 2019

⌛️ Testing commit 986e49d with merge 5d0a33d...

bors added a commit that referenced this pull request Jan 10, 2019

@bors
Auto merge of #56425 - scottmcm:redo-vec-set_len-docs, r=Centril 
Redo the docs for Vec::set_len

Inspired by the [recent conversation on IRLO](https://internals.rust-lang.org/t/make-vec-set-len-enforce-the-len-cap-invariant/8927/23?u=scottmcm).

This is just my first stab at this; suggestions welcome.
Loading status checks…
5d0a33d
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jan 10, 2019

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review and removed S-waiting-on-bors labels Jan 10, 2019

@pietroalbini

This comment has been minimized.

Sign in to view
Copy link
Member

pietroalbini commented Jan 10, 2019

@bors retry
AppVeyor... what's wrong with you today?

@bors bors added S-waiting-on-bors and removed S-waiting-on-review labels Jan 10, 2019

Centril added a commit to Centril/rust that referenced this pull request Jan 10, 2019

@Centril
Rollup merge of rust-lang#56425 - scottmcm:redo-vec-set_len-docs, r=C… 
…entril

Redo the docs for Vec::set_len

Inspired by the [recent conversation on IRLO](https://internals.rust-lang.org/t/make-vec-set-len-enforce-the-len-cap-invariant/8927/23?u=scottmcm).

This is just my first stab at this; suggestions welcome.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
af3e1b7

@Centril Centril referenced this pull request Jan 10, 2019

Closed

Rollup of 19 pull requests #57503

bors added a commit that referenced this pull request Jan 11, 2019

@bors
Auto merge of #57503 - Centril:rollup, r=Centril 
Rollup of 19 pull requests

Successful merges:

 - #56425 (Redo the docs for Vec::set_len)
 - #56906 (Issue #56905)
 - #57042 (Don't call `FieldPlacement::count` when count is too large)
 - #57192 (Change std::error::Error trait documentation to talk about `source` instead of `cause`)
 - #57296 (Fixed the link to the ? operator)
 - #57353 (Optimise floating point `is_finite` (2x) and `is_infinite` (1.6x).)
 - #57368 (Use CMAKE_{C,CXX}_COMPILER_LAUNCHER for ccache)
 - #57400 (Rustdoc: update Source Serif Pro and replace Heuristica italic)
 - #57412 (Improve the wording)
 - #57417 (rustdoc: use text-based doctest parsing if a macro is wrapping main)
 - #57433 (Add link destination for `read-ownership`)
 - #57434 (Remove `CrateNum::Invalid`.)
 - #57441 (Supporting backtrace for x86_64-fortanix-unknown-sgx.)
 - #57450 (actually take a slice in this example)
 - #57454 (Some cleanups for core::fmt)
 - #57459 (Reference tracking issue for inherent associated types in diagnostic)
 - #57463 (docs: Fix some 'second-edition' links)
 - #57466 (Remove outdated comment)
 - #57493 (use structured suggestion when casting a reference)

Failed merges:

r? @ghost
Loading status checks…
8d7aa49

bors added a commit that referenced this pull request Jan 11, 2019

@bors
Auto merge of #57503 - Centril:rollup, r=Centril 
Rollup of 19 pull requests

Successful merges:

 - #56425 (Redo the docs for Vec::set_len)
 - #56906 (Issue #56905)
 - #57042 (Don't call `FieldPlacement::count` when count is too large)
 - #57192 (Change std::error::Error trait documentation to talk about `source` instead of `cause`)
 - #57296 (Fixed the link to the ? operator)
 - #57353 (Optimise floating point `is_finite` (2x) and `is_infinite` (1.6x).)
 - #57368 (Use CMAKE_{C,CXX}_COMPILER_LAUNCHER for ccache)
 - #57400 (Rustdoc: update Source Serif Pro and replace Heuristica italic)
 - #57412 (Improve the wording)
 - #57417 (rustdoc: use text-based doctest parsing if a macro is wrapping main)
 - #57433 (Add link destination for `read-ownership`)
 - #57434 (Remove `CrateNum::Invalid`.)
 - #57441 (Supporting backtrace for x86_64-fortanix-unknown-sgx.)
 - #57450 (actually take a slice in this example)
 - #57454 (Some cleanups for core::fmt)
 - #57459 (Reference tracking issue for inherent associated types in diagnostic)
 - #57463 (docs: Fix some 'second-edition' links)
 - #57466 (Remove outdated comment)
 - #57493 (use structured suggestion when casting a reference)

Failed merges:

r? @ghost
Loading status checks…
35f174f

Centril added a commit to Centril/rust that referenced this pull request Jan 12, 2019

@Centril
Rollup merge of rust-lang#56425 - scottmcm:redo-vec-set_len-docs, r=C… 
…entril

Redo the docs for Vec::set_len

Inspired by the [recent conversation on IRLO](https://internals.rust-lang.org/t/make-vec-set-len-enforce-the-len-cap-invariant/8927/23?u=scottmcm).

This is just my first stab at this; suggestions welcome.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
e69a5cb

@Centril Centril referenced this pull request Jan 12, 2019

Merged

Rollup of 26 pull requests #57542

bors added a commit that referenced this pull request Jan 12, 2019

@bors
Auto merge of #57542 - Centril:rollup, r=Centril 
Rollup of 26 pull requests

Successful merges:

 - #56425 (Redo the docs for Vec::set_len)
 - #56906 (Issue #56905)
 - #57042 (Don't call `FieldPlacement::count` when count is too large)
 - #57175 (Stabilize `let` bindings and destructuring in constants and const fn)
 - #57192 (Change std::error::Error trait documentation to talk about `source` instead of `cause`)
 - #57296 (Fixed the link to the ? operator)
 - #57368 (Use CMAKE_{C,CXX}_COMPILER_LAUNCHER for ccache)
 - #57400 (Rustdoc: update Source Serif Pro and replace Heuristica italic)
 - #57417 (rustdoc: use text-based doctest parsing if a macro is wrapping main)
 - #57433 (Add link destination for `read-ownership`)
 - #57434 (Remove `CrateNum::Invalid`.)
 - #57441 (Supporting backtrace for x86_64-fortanix-unknown-sgx.)
 - #57450 (actually take a slice in this example)
 - #57459 (Reference tracking issue for inherent associated types in diagnostic)
 - #57463 (docs: Fix some 'second-edition' links)
 - #57466 (Remove outdated comment)
 - #57493 (use structured suggestion when casting a reference)
 - #57498 (make note of one more normalization that Paths do)
 - #57499 (note that FromStr does not work for borrowed types)
 - #57505 (Remove submodule step from README)
 - #57510 (Add a profiles section to the manifest)
 - #57511 (Fix undefined behavior)
 - #57519 (Correct RELEASES.md for 1.32.0)
 - #57522 (don't unwrap unexpected tokens in `format!`)
 - #57530 (Fixing a typographical error.)
 - #57535 (Stabilise irrefutable if-let and while-let patterns)

Failed merges:

r? @ghost
Loading status checks…
d6525ef

@bors bors merged commit 986e49d into rust-lang:master Jan 12, 2019
1 of 2 checks passed

1 of 2 checks passed

homu Test failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@scottmcm scottmcm deleted the scottmcm:redo-vec-set_len-docs branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.