New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some unit tests to compiletest #56841

Merged
merged 3 commits into from Dec 15, 2018

Conversation

Projects
None yet
5 participants
@phansch
Copy link
Contributor

phansch commented Dec 15, 2018

Based on #56792, otherwise the tests won't be executed on CI.

Just a small start, I would like to add more testing to compiletest in the future but that will require some refactoring first.

cc #47606

phansch added some commits Dec 13, 2018

Bootstrap: Add testsuite for compiletest tool
The (currently) single unit test of the compiletest tool was never
executed on CI. At least I couldn't find any references of it in the
logs. This adds a test suite for compiletest so that our tester is
tested, too.

The compiletest tests can then also be executed with:

    ./x.py test src/tools/compiletest
compiletest: unit test parse_normalization_string
There is a FIXME inside that function and I think the unit tests can be
helpful to resolve it without breaking anything else.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 15, 2018

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Dec 15, 2018

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 15, 2018

📌 Commit 9637c27 has been approved by oli-obk

@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Dec 15, 2018

@bors rollup

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Dec 15, 2018

Rollup merge of rust-lang#56841 - phansch:add_various_compiletest_uni…
…ttests, r=oli-obk

Add some unit tests to compiletest

Based on rust-lang#56792, otherwise the tests won't be executed on CI.

Just a small start, I would like to add more testing to compiletest in the future but that will require some refactoring first.

cc rust-lang#47606

bors added a commit that referenced this pull request Dec 15, 2018

Auto merge of #56846 - pietroalbini:rollup, r=pietroalbini
Rollup of 7 pull requests

Successful merges:

 - #56677 (#[must_use] on traits in stdlib)
 - #56679 (overhaul external doc attribute diagnostics)
 - #56682 (Update the stdsimd submodule)
 - #56691 (fix install broken link)
 - #56710 (Always set the RDRAND and RDSEED features on SGX)
 - #56713 (Test capacity of ZST vector)
 - #56841 (Add some unit tests to compiletest)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request Dec 15, 2018

Auto merge of #56846 - pietroalbini:rollup, r=pietroalbini
Rollup of 7 pull requests

Successful merges:

 - #56677 (#[must_use] on traits in stdlib)
 - #56679 (overhaul external doc attribute diagnostics)
 - #56682 (Update the stdsimd submodule)
 - #56691 (fix install broken link)
 - #56710 (Always set the RDRAND and RDSEED features on SGX)
 - #56713 (Test capacity of ZST vector)
 - #56841 (Add some unit tests to compiletest)

Failed merges:

r? @ghost

@bors bors merged commit 9637c27 into rust-lang:master Dec 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@phansch phansch deleted the phansch:add_various_compiletest_unittests branch Dec 15, 2018

phansch added a commit to phansch/compiletest-rs that referenced this pull request Dec 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment