New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move glob map use to query and get rid of CrateAnalysis #57476

wants to merge 5 commits into
base: master


None yet
2 participants
Copy link

Xanewok commented Jan 9, 2019

Also includes commits from #57392 and #57436.

With glob map calculated unconditionally in #57392, this PR moves the calculated glob map to GlobalCtxt and exposes a relevant query (as we do with other queries which copy precomputed data over from the Resolver).

This allows us to get rid of the CrateAnalysis struct in an attempt to simplify the compiler interface.
cc @Zoxc

r? @nikomatsakis @Zoxc @petrochenkov

Xanewok added some commits Jan 6, 2019

Always calculate glob map but only for glob uses
Previously calculating glob map was *opt-in*, however it did record
node id -> ident use for every use directive. This aims to see if we
can unconditionally calculate the glob map and not regress performance.

This comment has been minimized.

Copy link

bors commented Jan 13, 2019

☔️ The latest upstream changes (presumably #57568) made this pull request unmergeable. Please resolve the merge conflicts.

@Xanewok Xanewok force-pushed the Xanewok:bye-crate-analysis branch from 675ab08 to b3b85ad Jan 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment