Querify entry_fn
#57573
Merged
Querify entry_fn
#57573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Zoxc
reviewed
Jan 14, 2019
Zoxc
reviewed
Jan 14, 2019
|
r=me with the nit addressed. You'll also need to wait until we can break tools again, since those can't be broken the week before a release. |
Xanewok
force-pushed
the
querify-entry-fn
branch
from
20aff0c
to
cbe8bec
Compare
|
Ah right, makes sense. Gonna wait with this until the release then. |
|
☔ The latest upstream changes (presumably #57607) made this pull request unmergeable. Please resolve the merge conflicts. |
Xanewok
force-pushed
the
querify-entry-fn
branch
from
cbe8bec
to
ff19a53
Compare
|
@bors r+ |
|
📌 Commit b7cd24d has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 19, 2019
Querify `entry_fn` Analogous to rust-lang#57570 but this will also require few fixups in Miri so I decided to separate that (and it seems [CI doesn't let us break tools anymore](rust-lang#57392 (comment))? Or was that because it was a rollup PR?) r? @nikomatsakis
bors
added a commit
that referenced
this pull request
Jan 19, 2019
Rollup of 10 pull requests Successful merges: - #57268 (Add a target option "merge-functions", and a corresponding -Z flag (works around #57356)) - #57476 (Move glob map use to query and get rid of CrateAnalysis) - #57501 (High priority resolutions for associated variants) - #57573 (Querify `entry_fn`) - #57610 (Fix nested `?` matchers) - #57634 (Remove an unused function argument) - #57653 (Make the contribution doc reference the guide more) - #57666 (Generalize `huge-enum.rs` test and expected stderr for more cross platform cases) - #57698 (Fix typo bug in DepGraph::try_mark_green().) - #57746 (Update README.md) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to #57570 but this will also require few fixups in Miri so I decided to separate that (and it seems CI doesn't let us break tools anymore? Or was that because it was a rollup PR?)
r? @nikomatsakis