Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write generics of trait aliases into metadata. #57786

Closed
wants to merge 1 commit into from

Conversation

davidtwco
Copy link
Member

Fixes #57676.

This fixes an ICE where the generics of trait aliases are being read
from metadata when assembling the list of extension candidates and one
such candidate is a trait alias defined in another crate.

This fixes an ICE where the generics of trait aliases are being read
from metadata when assembling the list of extension candidates and one
such candidate is a trait alias defined in another crate.
@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 20, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:1af483e2:start=1548019910234785183,finish=1548019992659487595,duration=82424702412
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:13:56]    Compiling rustc_typeck v0.0.0 (/checkout/src/librustc_typeck)
[00:13:58] error: unreachable pattern
[00:13:58]     --> src/librustc_metadata/encoder.rs:1224:17
[00:13:58]      |
[00:13:58] 1224 |                 hir::ItemKind::TraitAlias(..) => Some(self.encode_generics(def_id)),
[00:13:58]      |
[00:13:58]      = note: `-D unreachable-patterns` implied by `-D warnings`
[00:13:58] 
[00:13:58] error: aborting due to previous error
---
[00:18:32] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json"
[00:18:32] expected success, got: exit code: 101
[00:18:32] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:18:32] Build completed unsuccessfully in 0:15:03
[00:18:32] make: *** [all] Error 1
[00:18:32] Makefile:18: recipe for target 'all' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:08af59c4
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sun Jan 20 21:51:53 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@davidtwco
Copy link
Member Author

Closing, looks like my local build was out-of-date and this had already been fixed in the past day or two.

@davidtwco davidtwco closed this Jan 20, 2019
@davidtwco davidtwco deleted the issue-57676 branch January 20, 2019 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE with trait_alias in Nightly: unwrap None in assemble_extension_candidates_for_trait
3 participants