New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multiple threads by default. Limits tests to one thread. Do some renaming. #57948

Merged
merged 3 commits into from Jan 29, 2019

Conversation

Projects
None yet
6 participants
@Zoxc
Copy link
Contributor

Zoxc commented Jan 28, 2019

r? @michaelwoerister

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Jan 28, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:00e8faaa:start=1548687619942773618,finish=1548687622404067823,duration=2461294205
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:05:25] tidy error: /checkout/src/tools/compiletest/src/runtest.rs:1729: trailing whitespace
[00:05:27] some tidy checks failed
[00:05:27] 
[00:05:27] 
[00:05:27] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:05:27] 
[00:05:27] 
[00:05:27] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:05:27] Build completed unsuccessfully in 0:00:47
[00:05:27] Build completed unsuccessfully in 0:00:47
[00:05:27] make: *** [tidy] Error 1
[00:05:27] Makefile:68: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1d245d16
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Mon Jan 28 15:06:00 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Zoxc Zoxc force-pushed the Zoxc:parallel branch from b3412c6 to 975eb31 Jan 28, 2019

@@ -150,9 +150,9 @@ newtype_index! {
// The interner is pointed to by a thread local value which is only set on the main thread
// with parallelization is disabled. So we don't allow `Symbol` to transfer between threads
// to avoid panics and other errors, even though it would be memory safe to do so.
#[cfg(not(parallel_queries))]

This comment has been minimized.

@nagisa

nagisa Jan 28, 2019

Contributor

CFGs like these seem very prone to invisible breakage (if we end up not running either configuration on CI). Perhaps we should maintain parallel-able code in all configurations?

This comment has been minimized.

@Zoxc

Zoxc Jan 28, 2019

Author Contributor

We do check both on PRs on Travis at least.

@@ -1194,8 +1194,8 @@ options! {DebuggingOptions, DebuggingSetter, basic_debugging_options,
"prints the llvm optimization passes being run"),
ast_json: bool = (false, parse_bool, [UNTRACKED],
"print the AST as JSON and halt"),
query_threads: Option<usize> = (None, parse_opt_uint, [UNTRACKED],
"execute queries on a thread pool with N threads"),
threads: Option<usize> = (None, parse_opt_uint, [UNTRACKED],

This comment has been minimized.

@nagisa

nagisa Jan 28, 2019

Contributor

Is there any support for jobserver or is this a static quantity? Perhaps the documentation should be adjusted either way?

This comment has been minimized.

@Zoxc

Zoxc Jan 28, 2019

Author Contributor

It will use a jobserver once #56946 lands

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Jan 28, 2019

The job mingw-check of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0ace4988:start=1548690154374732301,finish=1548690156663000130,duration=2288267829
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=mingw-check
---
[00:02:44] configure: 
[00:02:44] configure: rust.experimental-parallel-queries := True
[00:02:44] configure: build.configure-args := ['--enable-experimental-parallel-queries']
[00:02:44] Traceback (most recent call last):
[00:02:44]   File "/checkout/src/bootstrap/configure.py", line 442, in <module>
[00:02:44]     configure_section(sections[section_key], section_config)
[00:02:44]   File "/checkout/src/bootstrap/configure.py", line 430, in configure_section
[00:02:44]     raise RuntimeError("failed to find config line for {}".format(key))
travis_time:end:1cf53428:start=1548690166342216943,finish=1548690330794643119,duration=164452426176
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 1.
travis_time:start:000bf602
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:0122b180:start=1548690331489342016,finish=1548690331493576869,duration=4234853
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:00dafe44
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:128d9714
travis_time:start:128d9714
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1fb98aba
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Zoxc added some commits Jan 28, 2019

@wesleywiser

This comment has been minimized.

Copy link
Member

wesleywiser commented Jan 29, 2019

(I'm assuming we will want a perf run here?)

@bors try

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 29, 2019

⌛️ Trying commit fd9d9ee with merge a8571c0...

bors added a commit that referenced this pull request Jan 29, 2019

Auto merge of #57948 - Zoxc:parallel, r=<try>
Use multiple threads by default. Limits tests to one thread. Do some renaming.

r? @michaelwoerister
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 29, 2019

☀️ Test successful - checks-travis
State: approved= try=True

@michaelwoerister

This comment has been minimized.

Copy link
Contributor

michaelwoerister commented Jan 29, 2019

Thanks, @Zoxc! Looks good. We'll still need to validate that running tests in single-threaded mode will give us the testing we want before we make multithreading the default. But for now it's a good start.

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 29, 2019

📌 Commit fd9d9ee has been approved by michaelwoerister

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 29, 2019

⌛️ Testing commit fd9d9ee with merge ae1ba15...

bors added a commit that referenced this pull request Jan 29, 2019

Auto merge of #57948 - Zoxc:parallel, r=michaelwoerister
Use multiple threads by default. Limits tests to one thread. Do some renaming.

r? @michaelwoerister
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 29, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: michaelwoerister
Pushing ae1ba15 to master...

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 29, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: michaelwoerister
Pushing ae1ba15 to master...

@bors bors merged commit fd9d9ee into rust-lang:master Jan 29, 2019

1 check passed

homu Test successful
Details

@Zoxc Zoxc deleted the Zoxc:parallel branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment