New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Make the rustc driver and interface demand driven #56732

Open
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@Zoxc
Copy link
Contributor

Zoxc commented Dec 12, 2018

This introduces a new crate rustc_interface which is the canonical interface for creating and using the compiler. It allows you to access a Compiler type in a closure and that types have methods to run passes on demand. The interesting parts are found here (defining the queries) and here (methods to create a Compiler).

cc @rust-lang/compiler @rust-lang/dev-tools @rust-lang/rustdoc

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 12, 2018

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Dec 12, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:33f8958a:start=1544577176343681956,finish=1544577238683468649,duration=62339786693
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
############################################################              84.5%
######################################################################## 100.0%
[00:01:06] extracting /checkout/obj/build/cache/2018-10-30/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:01:06]     Updating crates.io index
[00:01:14] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:01:14] Build completed unsuccessfully in 0:00:20
[00:01:14] Makefile:81: recipe for target 'prepare' failed
[00:01:14] make: *** [prepare] Error 1
[00:01:15] Command failed. Attempt 2/5:
[00:01:15] Command failed. Attempt 2/5:
[00:01:15] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:01:15] Build completed unsuccessfully in 0:00:00
[00:01:15] Makefile:81: recipe for target 'prepare' failed
[00:01:15] make: *** [prepare] Error 1
[00:01:17] Command failed. Attempt 3/5:
[00:01:17] Command failed. Attempt 3/5:
[00:01:17] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:01:17] Build completed unsuccessfully in 0:00:00
[00:01:17] Makefile:81: recipe for target 'prepare' failed
[00:01:17] make: *** [prepare] Error 1
[00:01:20] Command failed. Attempt 4/5:
[00:01:20] Command failed. Attempt 4/5:
[00:01:21] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:01:21] Build completed unsuccessfully in 0:00:00
[00:01:21] Makefile:81: recipe for target 'prepare' failed
[00:01:21] make: *** [prepare] Error 1
[00:01:25] Command failed. Attempt 5/5:
[00:01:25] Command failed. Attempt 5/5:
[00:01:25] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:01:25] Build completed unsuccessfully in 0:00:00
[00:01:25] make: *** [prepare] Error 1
[00:01:25] Makefile:81: recipe for target 'prepare' failed
[00:01:25] The command has failed after 5 attempts.
---
travis_time:end:0c49a889:start=1544577334744179024,finish=1544577334752233677,duration=8054653
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:33e507e2
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:06d7eeec
travis_time:start:06d7eeec
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0af33ed2
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors

This comment was marked as outdated.

Copy link
Contributor

bors commented Dec 13, 2018

☔️ The latest upstream changes (presumably #56090) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC

This comment was marked as outdated.

Copy link
Member

Dylan-DPC commented Jan 14, 2019

ping from triage @Zoxc can you rebase the PR? will get a review after that

@Zoxc Zoxc force-pushed the Zoxc:rustc-interface branch from 6855c2b to 25847ab Jan 20, 2019

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Jan 20, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:37c80b70:start=1547966657390229262,finish=1547966658368318026,duration=978088764
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---

[00:04:01] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:01] tidy error: /checkout/src/librustc_interface/queries.rs:244: trailing whitespace
[00:04:01] tidy error: /checkout/src/librustc_interface/queries.rs:261: trailing whitespace
[00:04:01] tidy error: /checkout/src/librustc_interface/passes.rs:951: trailing whitespace
[00:04:01] tidy error: /checkout/src/librustc_driver/lib.rs:160: trailing whitespace
[00:04:01] tidy error: /checkout/src/librustc_driver/lib.rs:246: trailing whitespace
[00:04:01] tidy error: /checkout/src/librustc_driver/lib.rs:251: trailing whitespace
[00:04:01] tidy error: /checkout/src/librustc_driver/lib.rs:266: trailing whitespace
[00:04:01] tidy error: /checkout/src/librustc_driver/lib.rs:267: trailing whitespace
[00:04:01] tidy error: /checkout/src/librustc_driver/lib.rs:268: trailing whitespace
[00:04:03] some tidy checks failed
[00:04:03] 
[00:04:03] 
[00:04:03] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:03] 
[00:04:03] 
[00:04:03] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:03] Build completed unsuccessfully in 0:00:48
[00:04:03] Build completed unsuccessfully in 0:00:48
[00:04:03] Makefile:69: recipe for target 'tidy' failed
[00:04:03] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:23615895
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sun Jan 20 06:48:32 UTC 2019
---
travis_time:end:22726568:start=1547966912725033895,finish=1547966912729500783,duration=4466888
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1e39df2f
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0d3b57a8
travis_time:start:0d3b57a8
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:09796b6c
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Zoxc Zoxc force-pushed the Zoxc:rustc-interface branch 2 times, most recently from 6a75222 to 32b4fb5 Jan 20, 2019

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Jan 20, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0fb9ee44:start=1547971373675295725,finish=1547971374697735046,duration=1022439321
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:04:02]    Compiling rustc_lsan v0.0.0 (/checkout/src/librustc_lsan)
[00:04:16] warning: unnecessary `unsafe` block
[00:04:16]    --> src/libcore/num/mod.rs:71:30
[00:04:16]     |
[00:04:16] 33  | / macro_rules! nonzero_integers {
[00:04:16] 34  | |     ( $( $Ty: ident($Int: ty); )+ ) => {
[00:04:16] 36  | |             doc_comment! {
[00:04:16] ...   |
[00:04:16] 71  | |                         Some(unsafe { $Ty(n) })
[00:04:16]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:16]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:16] ...   |
[00:04:16] 97  | |     }
[00:04:16] 98  | | }
[00:04:16]     | |_- in this expansion of `nonzero_integers!`
[00:04:16] 100 | / nonzero_integers! {
[00:04:16] 101 | |     NonZeroU8(u8);
[00:04:16] 102 | |     NonZeroU16(u16);
[00:04:16] 103 | |     NonZeroU32(u32);
---
[00:04:16] 
[00:04:16] warning: unnecessary `unsafe` block
[00:04:16]    --> src/libcore/num/mod.rs:71:30
[00:04:16]     |
[00:04:16] 33  | / macro_rules! nonzero_integers {
[00:04:16] 34  | |     ( $( $Ty: ident($Int: ty); )+ ) => {
[00:04:16] 36  | |             doc_comment! {
[00:04:16] ...   |
[00:04:16] 71  | |                         Some(unsafe { $Ty(n) })
[00:04:16]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:16]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:16] ...   |
[00:04:16] 97  | |     }
[00:04:16] 98  | | }
[00:04:16]     | |_- in this expansion of `nonzero_integers!`
[00:04:16] 100 | / nonzero_integers! {
[00:04:16] 101 | |     NonZeroU8(u8);
[00:04:16] 102 | |     NonZeroU16(u16);
[00:04:16] 103 | |     NonZeroU32(u32);
---
[00:04:16] 
[00:04:17] warning: unused attribute
[00:04:17]    --> src/libcore/num/mod.rs:50:17
[00:04:17]     |
[00:04:17] 33  | / macro_rules! nonzero_integers {
[00:04:17] 34  | |     ( $( $Ty: ident($Int: ty); )+ ) => {
[00:04:17] 36  | |             doc_comment! {
[00:04:17] ...   |
[00:04:17] 50  | |                 #[rustc_layout_scalar_valid_range_start(1)]
[00:04:17]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:17]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:17] ...   |
[00:04:17] 97  | |     }
[00:04:17] 98  | | }
[00:04:17]     | |_- in this expansion of `nonzero_integers!`
[00:04:17] 100 | / nonzero_integers! {
[00:04:17] 101 | |     NonZeroU8(u8);
[00:04:17] 102 | |     NonZeroU16(u16);
[00:04:17] 103 | |     NonZeroU32(u32);
---
[00:04:17] 
[00:04:17] warning: unused attribute
[00:04:17]    --> src/libcore/num/mod.rs:50:17
[00:04:17]     |
[00:04:17] 33  | / macro_rules! nonzero_integers {
[00:04:17] 34  | |     ( $( $Ty: ident($Int: ty); )+ ) => {
[00:04:17] 36  | |             doc_comment! {
[00:04:17] ...   |
[00:04:17] 50  | |                 #[rustc_layout_scalar_valid_range_start(1)]
[00:04:17]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:17]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:17] ...   |
[00:04:17] 97  | |     }
[00:04:17] 98  | | }
[00:04:17]     | |_- in this expansion of `nonzero_integers!`
[00:04:17] 100 | / nonzero_integers! {
[00:04:17] 101 | |     NonZeroU8(u8);
[00:04:17] 102 | |     NonZeroU16(u16);
[00:04:17] 103 | |     NonZeroU32(u32);
---
[00:05:37]    Compiling parking_lot v0.6.4
[00:05:39]    Compiling rustc-rayon v0.1.1
[00:05:42]    Compiling rustc_data_structures v0.0.0 (/checkout/src/librustc_data_structures)
[00:05:42]    Compiling tempfile v3.0.5
[00:05:42] error: trait objects without an explicit `dyn` are deprecated
[00:05:42]  --> src/librustc_data_structures/box_region.rs:6:17
[00:05:42]   |
[00:05:42] 6 |     Access(*mut FnMut()),
[00:05:42]   |                 ^^^^^^^ help: use `dyn`: `dyn FnMut()`
[00:05:42]   |
[00:05:42]   = note: requested on the command line with `-D bare-trait-objects`
[00:05:42] 
[00:05:42] error: trait objects without an explicit `dyn` are deprecated
[00:05:42]  --> src/librustc_data_structures/box_region.rs:6:17
[00:05:42]   |
[00:05:42] 6 |     Access(*mut FnMut()),
[00:05:42]   |                 ^^^^^^^ help: use `dyn`: `dyn FnMut()`
[00:05:44] error: aborting due to 2 previous errors
[00:05:44] 
[00:05:44] error: Could not compile `rustc_data_structures`.
[00:05:44] 
[00:05:44] 
[00:05:44] To learn more, run the command again with --verbose.
[00:05:44] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json"
[00:05:44] expected success, got: exit code: 101
[00:05:44] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:05:44] Build completed unsuccessfully in 0:01:54
[00:05:44] make: *** [all] Error 1
[00:05:44] Makefile:18: recipe for target 'all' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:03071d74
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sun Jan 20 08:08:49 UTC 2019
---
travis_time:end:047ff716:start=1547971730459250604,finish=1547971730463448052,duration=4197448
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:12a202be
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:23c61630
travis_time:start:23c61630
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:003e6980
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Jan 20, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:01070ef8:start=1547999304493609847,finish=1547999399009341518,duration=94515731671
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:03:38]    Compiling rustc_tsan v0.0.0 (/checkout/src/librustc_tsan)
[00:03:55] warning: unnecessary `unsafe` block
[00:03:55]    --> src/libcore/num/mod.rs:71:30
[00:03:55]     |
[00:03:55] 33  | / macro_rules! nonzero_integers {
[00:03:55] 34  | |     ( $( $Ty: ident($Int: ty); )+ ) => {
[00:03:55] 36  | |             doc_comment! {
[00:03:55] ...   |
[00:03:55] 71  | |                         Some(unsafe { $Ty(n) })
[00:03:55]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:03:55]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:03:55] ...   |
[00:03:55] 97  | |     }
[00:03:55] 98  | | }
[00:03:55]     | |_- in this expansion of `nonzero_integers!`
[00:03:55] 100 | / nonzero_integers! {
[00:03:55] 101 | |     NonZeroU8(u8);
[00:03:55] 102 | |     NonZeroU16(u16);
[00:03:55] 103 | |     NonZeroU32(u32);
---
[00:03:55] 
[00:03:55] warning: unnecessary `unsafe` block
[00:03:55]    --> src/libcore/num/mod.rs:71:30
[00:03:55]     |
[00:03:55] 33  | / macro_rules! nonzero_integers {
[00:03:55] 34  | |     ( $( $Ty: ident($Int: ty); )+ ) => {
[00:03:55] 36  | |             doc_comment! {
[00:03:55] ...   |
[00:03:55] 71  | |                         Some(unsafe { $Ty(n) })
[00:03:55]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:03:55]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:03:55] ...   |
[00:03:55] 97  | |     }
[00:03:55] 98  | | }
[00:03:55]     | |_- in this expansion of `nonzero_integers!`
[00:03:55] 100 | / nonzero_integers! {
[00:03:55] 101 | |     NonZeroU8(u8);
[00:03:55] 102 | |     NonZeroU16(u16);
[00:03:55] 103 | |     NonZeroU32(u32);
---
[00:03:55] 
[00:03:55] warning: unused attribute
[00:03:55]    --> src/libcore/num/mod.rs:50:17
[00:03:55]     |
[00:03:55] 33  | / macro_rules! nonzero_integers {
[00:03:55] 34  | |     ( $( $Ty: ident($Int: ty); )+ ) => {
[00:03:55] 36  | |             doc_comment! {
[00:03:55] ...   |
[00:03:55] 50  | |                 #[rustc_layout_scalar_valid_range_start(1)]
[00:03:55]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:03:55]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:03:55] ...   |
[00:03:55] 97  | |     }
[00:03:55] 98  | | }
[00:03:55]     | |_- in this expansion of `nonzero_integers!`
[00:03:55] 100 | / nonzero_integers! {
[00:03:55] 101 | |     NonZeroU8(u8);
[00:03:55] 102 | |     NonZeroU16(u16);
[00:03:55] 103 | |     NonZeroU32(u32);
---
[00:03:55] 
[00:03:55] warning: unused attribute
[00:03:55]    --> src/libcore/num/mod.rs:50:17
[00:03:55]     |
[00:03:55] 33  | / macro_rules! nonzero_integers {
[00:03:55] 34  | |     ( $( $Ty: ident($Int: ty); )+ ) => {
[00:03:55] 36  | |             doc_comment! {
[00:03:55] ...   |
[00:03:55] 50  | |                 #[rustc_layout_scalar_valid_range_start(1)]
[00:03:55]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:03:55]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:03:55] ...   |
[00:03:55] 97  | |     }
[00:03:55] 98  | | }
[00:03:55]     | |_- in this expansion of `nonzero_integers!`
[00:03:55] 100 | / nonzero_integers! {
[00:03:55] 101 | |     NonZeroU8(u8);
[00:03:55] 102 | |     NonZeroU16(u16);
[00:03:55] 103 | |     NonZeroU32(u32);
---
[00:23:02]    Compiling rustc_interface v0.0.0 (/checkout/src/librustc_interface)
[00:23:03] error[E0433]: failed to resolve: use of undeclared type or module `libc`
[00:23:03]    --> src/librustc_interface/util.rs:400:16
[00:23:03]     |
[00:23:03] 400 |             if libc::dladdr(addr, &mut info) == 0 {
[00:23:03]     |                ^^^^ use of undeclared type or module `libc`
[00:23:04] error: aborting due to previous error
[00:23:04] 
[00:23:04] For more information about this error, try `rustc --explain E0433`.
[00:23:04] error: Could not compile `rustc_interface`.
[00:23:04] error: Could not compile `rustc_interface`.
[00:23:04] warning: build failed, waiting for other jobs to finish...
[00:24:18] error: build failed
[00:24:18] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json"
[00:24:18] expected success, got: exit code: 101
[00:24:18] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:24:18] Build completed unsuccessfully in 0:20:53
[00:24:18] make: *** [all] Error 1
[00:24:18] Makefile:18: recipe for target 'all' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:04bb1051
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sun Jan 20 16:14:26 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 20, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0fbf2106:start=1548004425915832733,finish=1548004497689040427,duration=71773207694
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:03:46]    Compiling rustc_msan v0.0.0 (/checkout/src/librustc_msan)
[00:04:02] warning: unnecessary `unsafe` block
[00:04:02]    --> src/libcore/num/mod.rs:71:30
[00:04:02]     |
[00:04:02] 33  | / macro_rules! nonzero_integers {
[00:04:02] 34  | |     ( $( $Ty: ident($Int: ty); )+ ) => {
[00:04:02] 36  | |             doc_comment! {
[00:04:02] ...   |
[00:04:02] 71  | |                         Some(unsafe { $Ty(n) })
[00:04:02]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:02]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:02] ...   |
[00:04:02] 97  | |     }
[00:04:02] 98  | | }
[00:04:02]     | |_- in this expansion of `nonzero_integers!`
[00:04:02] 100 | / nonzero_integers! {
[00:04:02] 101 | |     NonZeroU8(u8);
[00:04:02] 102 | |     NonZeroU16(u16);
[00:04:02] 103 | |     NonZeroU32(u32);
---
[00:04:02] 
[00:04:02] warning: unnecessary `unsafe` block
[00:04:02]    --> src/libcore/num/mod.rs:71:30
[00:04:02]     |
[00:04:02] 33  | / macro_rules! nonzero_integers {
[00:04:02] 34  | |     ( $( $Ty: ident($Int: ty); )+ ) => {
[00:04:02] 36  | |             doc_comment! {
[00:04:02] ...   |
[00:04:02] 71  | |                         Some(unsafe { $Ty(n) })
[00:04:02]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:02]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:02] ...   |
[00:04:02] 97  | |     }
[00:04:02] 98  | | }
[00:04:02]     | |_- in this expansion of `nonzero_integers!`
[00:04:02] 100 | / nonzero_integers! {
[00:04:02] 101 | |     NonZeroU8(u8);
[00:04:02] 102 | |     NonZeroU16(u16);
[00:04:02] 103 | |     NonZeroU32(u32);
---
[00:04:02] 
[00:04:02] warning: unused attribute
[00:04:02]    --> src/libcore/num/mod.rs:50:17
[00:04:02]     |
[00:04:02] 33  | / macro_rules! nonzero_integers {
[00:04:02] 34  | |     ( $( $Ty: ident($Int: ty); )+ ) => {
[00:04:02] 36  | |             doc_comment! {
[00:04:02] ...   |
[00:04:02] 50  | |                 #[rustc_layout_scalar_valid_range_start(1)]
[00:04:02]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:02]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:02] ...   |
[00:04:02] 97  | |     }
[00:04:02] 98  | | }
[00:04:02]     | |_- in this expansion of `nonzero_integers!`
[00:04:02] 100 | / nonzero_integers! {
[00:04:02] 101 | |     NonZeroU8(u8);
[00:04:02] 102 | |     NonZeroU16(u16);
[00:04:02] 103 | |     NonZeroU32(u32);
---
[00:04:02] 
[00:04:02] warning: unused attribute
[00:04:02]    --> src/libcore/num/mod.rs:50:17
[00:04:02]     |
[00:04:02] 33  | / macro_rules! nonzero_integers {
[00:04:02] 34  | |     ( $( $Ty: ident($Int: ty); )+ ) => {
[00:04:02] 36  | |             doc_comment! {
[00:04:02] ...   |
[00:04:02] 50  | |                 #[rustc_layout_scalar_valid_range_start(1)]
[00:04:02]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:02]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:02] ...   |
[00:04:02] 97  | |     }
[00:04:02] 98  | | }
[00:04:02]     | |_- in this expansion of `nonzero_integers!`
[00:04:02] 100 | / nonzero_integers! {
[00:04:02] 101 | |     NonZeroU8(u8);
[00:04:02] 102 | |     NonZeroU16(u16);
[00:04:02] 103 | |     NonZeroU32(u32);
---
[01:01:25]     Checking rustc_asan v0.0.0 (/checkout/src/librustc_asan)
[01:01:25]     Checking rustc_tsan v0.0.0 (/checkout/src/librustc_tsan)
[01:01:25]     Checking panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
[01:01:26]  Documenting std v0.0.0 (/checkout/src/libstd)
[01:01:27] error[E0433]: failed to resolve: could not find `handle` in `sys`
[01:01:27]   --> src/libstd/sys/windows/ext/process.rs:13:27
[01:01:27]    |
[01:01:27] 13 |         let handle = sys::handle::Handle::new(handle as *mut _);
[01:01:27]    |                           ^^^^^^ could not find `handle` in `sys`
[01:01:27] 
[01:01:27] error[E0425]: cannot find function `symlink_inner` in module `sys::fs`
[01:01:27]    --> src/libstd/sys/windows/ext/fs.rs:476:14
[01:01:27]     |
[01:01:27] 476 |     sys::fs::symlink_inner(src.as_ref(), dst.as_ref(), false)
[01:01:27]     |              ^^^^^^^^^^^^^ not found in `sys::fs`
[01:01:27] 
[01:01:27] error[E0425]: cannot find function `symlink_inner` in module `sys::fs`
[01:01:27]    --> src/libstd/sys/windows/ext/fs.rs:497:14
[01:01:27]     |
[01:01:27] 497 |     sys::fs::symlink_inner(src.as_ref(), dst.as_ref(), true)
[01:01:27]     |              ^^^^^^^^^^^^^ not found in `sys::fs`
[01:01:27] error: Compilation failed, aborting rustdoc
[01:01:27] 
[01:01:27] error: aborting due to 4 previous errors
[01:01:27] 
[01:01:27] 
[01:01:27] Some errors occurred: E0425, E0433.
[01:01:27] For more information about an error, try `rustc --explain E0425`.
[01:01:27] error: Could not document `std`.
[01:01:27] 
[01:01:27] Caused by:
[01:01:27]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --crate-name std src/libstd/lib.rs --color always --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/doc --cfg 'feature="backtrace"' --cfg 'feature="backtrace-sys"' --cfg 'feature="compiler_builtins"' --cfg 'feature="compiler_builtins_c"' --cfg 'feature="default"' --cfg 'feature="panic-unwind"' --cfg 'feature="panic_unwind"' --markdown-css rust.css --markdown-no-toc --index-page /checkout/src/doc/index.md -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/release/deps --extern alloc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liballoc-af87d57ed062fc7f.rmeta --extern backtrace_sys=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libbacktrace_sys-c0930d7b9dbd7d13.rmeta --extern compiler_builtins=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libcompiler_builtins-863701a3534445c1.rmeta --extern core=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libcore-f6a1ccb419e02477.rmeta --extern libc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liblibc-85aa98a45625ace7.rmeta --extern panic_abort=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libpanic_abort-a4efbc575de6bc74.rmeta --extern panic_unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libpanic_unwind-9f967884a5a8bc6a.rmeta --extern rustc_demangle=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_demangle-c4e32b3828a741b5.rmeta --extern rustc_asan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_asan-d66cb368c256ed0f.rmeta --extern rustc_lsan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_lsan-2bb94db6f615f759.rmeta --extern rustc_msan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_msan-5735c5dc2cb08018.rmeta --extern rustc_tsan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_tsan-be04ce754dd91366.rmeta --extern unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libunwind-12e2a302e75e0a39.rmeta` (exit code: 1)
[01:01:27] 
[01:01:27] 
[01:01:27] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustdoc" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-Z" "unstable-options" "-p" "std" "--" "--markdown-css" "rust.css" "--markdown-no-toc" "--index-page" "/checkout/src/doc/index.md"
[01:01:27] 
[01:01:27] 
[01:01:27] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap doc
[01:01:27] Build completed unsuccessfully in 0:05:35
[01:01:27] Build completed unsuccessfully in 0:05:35
[01:01:27] make: *** [all] Error 1
[01:01:27] Makefile:18: recipe for target 'all' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:14bc6d08
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sun Jan 20 18:16:35 UTC 2019
---
travis_time:end:0b0ca4b8:start=1548008196153446452,finish=1548008196160370848,duration=6924396
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:157d6958
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0bfe1667
travis_time:start:0bfe1667
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0ee975b5
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Zoxc Zoxc force-pushed the Zoxc:rustc-interface branch from 8be10ad to 69b1f68 Jan 21, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 21, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:00ebbeb8:start=1548061327791666416,finish=1548061330354665378,duration=2562998962
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:04:12]    Compiling rustc_tsan v0.0.0 (/checkout/src/librustc_tsan)
[00:04:28] warning: unnecessary `unsafe` block
[00:04:28]    --> src/libcore/num/mod.rs:71:30
[00:04:28]     |
[00:04:28] 33  | / macro_rules! nonzero_integers {
[00:04:28] 34  | |     ( $( $Ty: ident($Int: ty); )+ ) => {
[00:04:28] 36  | |             doc_comment! {
[00:04:28] ...   |
[00:04:28] 71  | |                         Some(unsafe { $Ty(n) })
[00:04:28]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:28]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:28] ...   |
[00:04:28] 97  | |     }
[00:04:28] 98  | | }
[00:04:28]     | |_- in this expansion of `nonzero_integers!`
[00:04:28] 100 | / nonzero_integers! {
[00:04:28] 101 | |     NonZeroU8(u8);
[00:04:28] 102 | |     NonZeroU16(u16);
[00:04:28] 103 | |     NonZeroU32(u32);
---
[00:04:28] 
[00:04:28] warning: unnecessary `unsafe` block
[00:04:28]    --> src/libcore/num/mod.rs:71:30
[00:04:28]     |
[00:04:28] 33  | / macro_rules! nonzero_integers {
[00:04:28] 34  | |     ( $( $Ty: ident($Int: ty); )+ ) => {
[00:04:28] 36  | |             doc_comment! {
[00:04:28] ...   |
[00:04:28] 71  | |                         Some(unsafe { $Ty(n) })
[00:04:28]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:28]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:28] ...   |
[00:04:28] 97  | |     }
[00:04:28] 98  | | }
[00:04:28]     | |_- in this expansion of `nonzero_integers!`
[00:04:28] 100 | / nonzero_integers! {
[00:04:28] 101 | |     NonZeroU8(u8);
[00:04:28] 102 | |     NonZeroU16(u16);
[00:04:28] 103 | |     NonZeroU32(u32);
---
[00:04:28] 
[00:04:28] warning: unused attribute
[00:04:28]    --> src/libcore/num/mod.rs:50:17
[00:04:28]     |
[00:04:28] 33  | / macro_rules! nonzero_integers {
[00:04:28] 34  | |     ( $( $Ty: ident($Int: ty); )+ ) => {
[00:04:28] 36  | |             doc_comment! {
[00:04:28] ...   |
[00:04:28] 50  | |                 #[rustc_layout_scalar_valid_range_start(1)]
[00:04:28]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:28]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:28] ...   |
[00:04:28] 97  | |     }
[00:04:28] 98  | | }
[00:04:28]     | |_- in this expansion of `nonzero_integers!`
[00:04:28] 100 | / nonzero_integers! {
[00:04:28] 101 | |     NonZeroU8(u8);
[00:04:28] 102 | |     NonZeroU16(u16);
[00:04:28] 103 | |     NonZeroU32(u32);
---
[00:04:28] 
[00:04:28] warning: unused attribute
[00:04:28]    --> src/libcore/num/mod.rs:50:17
[00:04:28]     |
[00:04:28] 33  | / macro_rules! nonzero_integers {
[00:04:28] 34  | |     ( $( $Ty: ident($Int: ty); )+ ) => {
[00:04:28] 36  | |             doc_comment! {
[00:04:28] ...   |
[00:04:28] 50  | |                 #[rustc_layout_scalar_valid_range_start(1)]
[00:04:28]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:28]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:28] ...   |
[00:04:28] 97  | |     }
[00:04:28] 98  | | }
[00:04:28]     | |_- in this expansion of `nonzero_integers!`
[00:04:28] 100 | / nonzero_integers! {
[00:04:28] 101 | |     NonZeroU8(u8);
[00:04:28] 102 | |     NonZeroU16(u16);
[00:04:28] 103 | |     NonZeroU32(u32);
---
[00:54:06]    Compiling rustdoc v0.0.0 (/checkout/src/librustdoc)
[00:54:08] error[E0107]: wrong number of lifetime arguments: expected 1, found 3
[00:54:08]   --> src/librustdoc/passes/check_code_block_syntax.rs:22:28
[00:54:08]    |
[00:54:08] 22 |     cx: &'a DocContext<'a, 'tcx, 'rcx>,
[00:54:08]    |                            ^^^^  ^^^^ unexpected lifetime argument
[00:54:08]    |                            unexpected lifetime argument
[00:54:08] 
[00:54:08] error: aborting due to previous error
[00:54:08] 
---
[00:54:08] 
[00:54:08] 
[00:54:08] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:54:08] Build completed unsuccessfully in 0:50:09
[00:54:08] Makefile:18: recipe for target 'all' failed
[00:54:08] make: *** [all] Error 1
1743320 ./obj
1743280 ./obj/build
1131084 ./src
1078164 ./obj/build/x86_64-unknown-linux-gnu
---
176340 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc
163004 ./obj/build/bootstrap/debug/incremental
153280 ./src/tools/clang
146884 ./obj/build/bootstrap/debug/incremental/bootstrap-1o7ipylf5x405
146880 ./obj/build/bootstrap/debug/incremental/bootstrap-1o7ipylf5x405/s-f8qpmp28c7-1dbnqyb-3v9gdvsuxn2fo
139724 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release
137360 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps
115328 ./src/llvm/test/CodeGen
110548 ./obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib
---
travis_fold:end:after_failure.1
travis_fold:start:after_failure.2
travis_time:start:1552a991
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
ls: cannot access '/home/travis/Library/Lo: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:05cdbb50
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Jan 21, 2019

Since this will impact rls, clippy and miri quite strongly, could you open PRs against them showing how those changes will impact them?

I would assume rls and miri to be easy (since they don't change compilation and just need access to the TyCtxt to start their business), but clippy inserts new lints, which I'm not sure how to do with the new interface (looks to me like rustdoc has the same problem, but the FIXME shows that you are aware of this already).

@Zoxc Zoxc force-pushed the Zoxc:rustc-interface branch from 69b1f68 to 5de65b6 Jan 22, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 22, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0c9433f8:start=1548145540050404650,finish=1548145542226430952,duration=2176026302
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:04:20]    Compiling rustc_msan v0.0.0 (/checkout/src/librustc_msan)
[00:04:36] warning: unnecessary `unsafe` block
[00:04:36]    --> src/libcore/num/mod.rs:71:30
[00:04:36]     |
[00:04:36] 33  | / macro_rules! nonzero_integers {
[00:04:36] 34  | |     ( $( $Ty: ident($Int: ty); )+ ) => {
[00:04:36] 36  | |             doc_comment! {
[00:04:36] ...   |
[00:04:36] 71  | |                         Some(unsafe { $Ty(n) })
[00:04:36]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:36]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:36] ...   |
[00:04:36] 97  | |     }
[00:04:36] 98  | | }
[00:04:36]     | |_- in this expansion of `nonzero_integers!`
[00:04:36] 100 | / nonzero_integers! {
[00:04:36] 101 | |     NonZeroU8(u8);
[00:04:36] 102 | |     NonZeroU16(u16);
[00:04:36] 103 | |     NonZeroU32(u32);
---
[00:04:36] 
[00:04:36] warning: unnecessary `unsafe` block
[00:04:36]    --> src/libcore/num/mod.rs:71:30
[00:04:36]     |
[00:04:36] 33  | / macro_rules! nonzero_integers {
[00:04:36] 34  | |     ( $( $Ty: ident($Int: ty); )+ ) => {
[00:04:36] 36  | |             doc_comment! {
[00:04:36] ...   |
[00:04:36] 71  | |                         Some(unsafe { $Ty(n) })
[00:04:36]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:36]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:36] ...   |
[00:04:36] 97  | |     }
[00:04:36] 98  | | }
[00:04:36]     | |_- in this expansion of `nonzero_integers!`
[00:04:36] 100 | / nonzero_integers! {
[00:04:36] 101 | |     NonZeroU8(u8);
[00:04:36] 102 | |     NonZeroU16(u16);
[00:04:36] 103 | |     NonZeroU32(u32);
---
[00:04:36] 
[00:04:37] warning: unused attribute
[00:04:37]    --> src/libcore/num/mod.rs:50:17
[00:04:37]     |
[00:04:37] 33  | / macro_rules! nonzero_integers {
[00:04:37] 34  | |     ( $( $Ty: ident($Int: ty); )+ ) => {
[00:04:37] 36  | |             doc_comment! {
[00:04:37] ...   |
[00:04:37] 50  | |                 #[rustc_layout_scalar_valid_range_start(1)]
[00:04:37]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:37]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:37] ...   |
[00:04:37] 97  | |     }
[00:04:37] 98  | | }
[00:04:37]     | |_- in this expansion of `nonzero_integers!`
[00:04:37] 100 | / nonzero_integers! {
[00:04:37] 101 | |     NonZeroU8(u8);
[00:04:37] 102 | |     NonZeroU16(u16);
[00:04:37] 103 | |     NonZeroU32(u32);
---
[00:04:37] 
[00:04:37] warning: unused attribute
[00:04:37]    --> src/libcore/num/mod.rs:50:17
[00:04:37]     |
[00:04:37] 33  | / macro_rules! nonzero_integers {
[00:04:37] 34  | |     ( $( $Ty: ident($Int: ty); )+ ) => {
[00:04:37] 36  | |             doc_comment! {
[00:04:37] ...   |
[00:04:37] 50  | |                 #[rustc_layout_scalar_valid_range_start(1)]
[00:04:37]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:37]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:37] ...   |
[00:04:37] 97  | |     }
[00:04:37] 98  | | }
[00:04:37]     | |_- in this expansion of `nonzero_integers!`
[00:04:37] 100 | / nonzero_integers! {
[00:04:37] 101 | |     NonZeroU8(u8);
[00:04:37] 102 | |     NonZeroU16(u16);
[00:04:37] 103 | |     NonZeroU32(u32);
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:16:22] 
[01:16:22] running 118 tests
[01:16:47] .iiiii...i.....i..i...i..i.i..i.ii..i.....i..i....i..........iiii..........i...ii...i.......ii.i.i.i 100/118
[01:16:51] ......iii.i.....ii
[01:16:51] 
[01:16:51]  finished in 28.803
[01:16:51] travis_fold:end:test_debuginfo

---
[01:38:47]    Compiling rustc v0.0.0 (/checkout/src/librustc)
[01:39:09] error[E0308]: mismatched types
[01:39:09]     --> src/librustc/session/config.rs:2589:50
[01:39:09]      |
[01:39:09] 2589 |             let cfg = build_configuration(&sess, cfg);
[01:39:09]      |                                                  ^^^ expected struct `syntax_pos::symbol::Symbol`, found struct `std::string::String`
[01:39:09]      |
[01:39:09]      = note: expected type `std::collections::HashSet<(syntax_pos::symbol::Symbol, std::option::Option<syntax_pos::symbol::Symbol>), std::hash::BuildHasherDefault<rustc_data_structures::fx::FxHasher>>`
[01:39:09]                 found type `std::collections::HashSet<(std::string::String, std::option::Option<std::string::String>), std::collections::hash_map::RandomState>`
[01:39:09] error[E0308]: mismatched types
[01:39:09]     --> src/librustc/session/config.rs:2607:50
[01:39:09]      |
[01:39:09]      |
[01:39:09] 2607 |             let cfg = build_configuration(&sess, cfg);
[01:39:09]      |                                                  ^^^ expected struct `syntax_pos::symbol::Symbol`, found struct `std::string::String`
[01:39:09]      |
[01:39:09]      = note: expected type `std::collections::HashSet<(syntax_pos::symbol::Symbol, std::option::Option<syntax_pos::symbol::Symbol>), std::hash::BuildHasherDefault<rustc_data_structures::fx::FxHasher>>`
[01:39:09]                 found type `std::collections::HashSet<(std::string::String, std::option::Option<std::string::String>), std::collections::hash_map::RandomState>`
[01:39:18] error: aborting due to 2 previous errors
[01:39:18] 
[01:39:18] For more information about this error, try `rustc --explain E0308`.
[01:39:18] error: Could not compile `rustc`.
[01:39:18] error: Could not compile `rustc`.
[01:39:18] 
[01:39:18] To learn more, run the command again with --verbose.
[01:39:18] 
[01:39:18] 
[01:39:18] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "-p" "rustc" "--" "--quiet"
[01:39:18] 
[01:39:18] 
[01:39:18] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:39:18] Build completed unsuccessfully in 0:34:59
[01:39:18] Build completed unsuccessfully in 0:34:59
[01:39:18] make: *** [check] Error 1
[01:39:18] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:04117731
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Jan 22 10:05:12 UTC 2019
---
travis_time:end:0b07b428:start=1548151513550488422,finish=1548151513556065393,duration=5576971
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:19152eb8
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Zoxc added some commits Dec 8, 2018

wip

@Zoxc Zoxc force-pushed the Zoxc:rustc-interface branch from 5de65b6 to bdf4e7e Jan 22, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 22, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0015dcaa:start=1548155298043218202,finish=1548155300191523412,duration=2148305210
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:03:49]    Compiling rustc_tsan v0.0.0 (/checkout/src/librustc_tsan)
[00:04:05] warning: unnecessary `unsafe` block
[00:04:05]    --> src/libcore/num/mod.rs:71:30
[00:04:05]     |
[00:04:05] 33  | / macro_rules! nonzero_integers {
[00:04:05] 34  | |     ( $( #[$stability: meta] $Ty: ident($Int: ty); )+ ) => {
[00:04:05] 36  | |             doc_comment! {
[00:04:05] ...   |
[00:04:05] 71  | |                         Some(unsafe { $Ty(n) })
[00:04:05]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:05]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:05] ...   |
[00:04:05] 97  | |     }
[00:04:05] 98  | | }
[00:04:05]     | |_- in this expansion of `nonzero_integers!`
[00:04:05] 100 | / nonzero_integers! {
[00:04:05] 101 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU8(u8);
[00:04:05] 102 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU16(u16);
[00:04:05] 103 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU32(u32);
---
[00:04:05] 
[00:04:05] warning: unnecessary `unsafe` block
[00:04:05]    --> src/libcore/num/mod.rs:71:30
[00:04:05]     |
[00:04:05] 33  | / macro_rules! nonzero_integers {
[00:04:05] 34  | |     ( $( #[$stability: meta] $Ty: ident($Int: ty); )+ ) => {
[00:04:05] 36  | |             doc_comment! {
[00:04:05] ...   |
[00:04:05] 71  | |                         Some(unsafe { $Ty(n) })
[00:04:05]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:05]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:05] ...   |
[00:04:05] 97  | |     }
[00:04:05] 98  | | }
[00:04:05]     | |_- in this expansion of `nonzero_integers!`
[00:04:05] 100 | / nonzero_integers! {
[00:04:05] 101 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU8(u8);
[00:04:05] 102 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU16(u16);
[00:04:05] 103 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU32(u32);
---
[00:04:05] 
[00:04:05] warning: unused attribute
[00:04:05]    --> src/libcore/num/mod.rs:50:17
[00:04:05]     |
[00:04:05] 33  | / macro_rules! nonzero_integers {
[00:04:05] 34  | |     ( $( #[$stability: meta] $Ty: ident($Int: ty); )+ ) => {
[00:04:05] 36  | |             doc_comment! {
[00:04:05] ...   |
[00:04:05] 50  | |                 #[rustc_layout_scalar_valid_range_start(1)]
[00:04:05]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:05]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:05] ...   |
[00:04:05] 97  | |     }
[00:04:05] 98  | | }
[00:04:05]     | |_- in this expansion of `nonzero_integers!`
[00:04:05] 100 | / nonzero_integers! {
[00:04:05] 101 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU8(u8);
[00:04:05] 102 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU16(u16);
[00:04:05] 103 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU32(u32);
---
[00:04:05] 
[00:04:05] warning: unused attribute
[00:04:05]    --> src/libcore/num/mod.rs:50:17
[00:04:05]     |
[00:04:05] 33  | / macro_rules! nonzero_integers {
[00:04:05] 34  | |     ( $( #[$stability: meta] $Ty: ident($Int: ty); )+ ) => {
[00:04:05] 36  | |             doc_comment! {
[00:04:05] ...   |
[00:04:05] 50  | |                 #[rustc_layout_scalar_valid_range_start(1)]
[00:04:05]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:05]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:05] ...   |
[00:04:05] 97  | |     }
[00:04:05] 98  | | }
[00:04:05]     | |_- in this expansion of `nonzero_integers!`
[00:04:05] 100 | / nonzero_integers! {
[00:04:05] 101 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU8(u8);
[00:04:05] 102 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU16(u16);
[00:04:05] 103 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU32(u32);
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:10:23] 
[01:10:23] running 118 tests
[01:10:47] .iiiii...i.....i..i...i..i.i..i.ii..i.....i..i....i..........iiii..........i...ii...i.......ii.i.i.i 100/118
[01:10:51] ......iii.i.....ii
[01:10:51] 
[01:10:51]  finished in 28.492
[01:10:51] travis_fold:end:test_debuginfo

---
[01:33:19] travis_fold:start:test_stage1-rustc_driver
travis_time:start:test_stage1-rustc_driver
Testing rustc_driver stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:33:20]    Compiling rustc_driver v0.0.0 (/checkout/src/librustc_driver)
[01:33:20] error[E0432]: unresolved import `driver`
[01:33:20]  --> src/librustc_driver/test.rs:3:5
[01:33:20] 3 | use driver;
[01:33:20]   |     ^^^^^^ no `driver` in the root
[01:33:20] 
[01:33:20] error[E0425]: cannot find function `get_codegen_backend` in the crate root
[01:33:20] error[E0425]: cannot find function `get_codegen_backend` in the crate root
[01:33:20]    --> src/librustc_driver/test.rs:115:32
[01:33:20]     |
[01:33:20] 115 |     let cstore = CStore::new(::get_codegen_backend(&sess).metadata_loader());
[01:33:20]     |                                ^^^^^^^^^^^^^^^^^^^ not found in the crate root
[01:33:20]     |
[01:33:20] 3   | use rustc_interface::util::get_codegen_backend;
[01:33:20]     |
[01:33:20] 
[01:33:20] 
[01:33:21] error[E0599]: no function or associated item named `create_and_enter` found for type `rustc::ty::TyCtxt<'_, '_, '_>` in the current scope
[01:33:21]    --> src/librustc_driver/test.rs:152:13
[01:33:21] 152 |     TyCtxt::create_and_enter(
[01:33:21]     |     --------^^^^^^^^^^^^^^^^
[01:33:21]     |     |
[01:33:21]     |     function or associated item not found in `rustc::ty::TyCtxt<'_, '_, '_>`
---
[01:33:21] 
[01:33:21] To learn more, run the command again with --verbose.
[01:33:21] 
[01:33:21] 
[01:33:21] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "-p" "rustc_driver" "--" "--quiet"
[01:33:21] 
[01:33:21] 
[01:33:21] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:33:21] Build completed unsuccessfully in 0:34:36
[01:33:21] Build completed unsuccessfully in 0:34:36
[01:33:21] make: *** [check] Error 1
[01:33:21] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:045777d8
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Jan 22 12:41:51 UTC 2019
---
travis_time:end:05102f2b:start=1548160912801045886,finish=1548160912805487662,duration=4441776
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:027f5132
$ ln -s . checkout && for CORE in obj/cores/core.*; do E

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

wip
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 22, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:013e8b8c:start=1548162957611214602,finish=1548162959848407466,duration=2237192864
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---

[00:04:04] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:04] tidy error: /checkout/src/librustc_driver/test.rs:87: trailing whitespace
[00:04:06] some tidy checks failed
[00:04:06] 
[00:04:06] 
[00:04:06] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:06] 
[00:04:06] 
[00:04:06] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:06] Build completed unsuccessfully in 0:00:46
[00:04:06] Build completed unsuccessfully in 0:00:46
[00:04:06] Makefile:69: recipe for target 'tidy' failed
[00:04:06] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0e84c223
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Jan 22 13:20:17 UTC 2019
---
travis_time:end:24dc6af8:start=1548163217817563439,finish=1548163217822313472,duration=4750033
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0571de36
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1b6f5fda
travis_time:start:1b6f5fda
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:30ab191e
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

wip
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 22, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:3421d456:start=1548163499043994409,finish=1548163501355183476,duration=2311189067
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:04:20]    Compiling rustc_tsan v0.0.0 (/checkout/src/librustc_tsan)
[00:04:38] warning: unnecessary `unsafe` block
[00:04:38]    --> src/libcore/num/mod.rs:71:30
[00:04:38]     |
[00:04:38] 33  | / macro_rules! nonzero_integers {
[00:04:38] 34  | |     ( $( #[$stability: meta] $Ty: ident($Int: ty); )+ ) => {
[00:04:38] 36  | |             doc_comment! {
[00:04:38] ...   |
[00:04:38] 71  | |                         Some(unsafe { $Ty(n) })
[00:04:38]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:38]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:38] ...   |
[00:04:38] 97  | |     }
[00:04:38] 98  | | }
[00:04:38]     | |_- in this expansion of `nonzero_integers!`
[00:04:38] 100 | / nonzero_integers! {
[00:04:38] 101 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU8(u8);
[00:04:38] 102 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU16(u16);
[00:04:38] 103 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU32(u32);
---
[00:04:38] 
[00:04:38] warning: unnecessary `unsafe` block
[00:04:38]    --> src/libcore/num/mod.rs:71:30
[00:04:38]     |
[00:04:38] 33  | / macro_rules! nonzero_integers {
[00:04:38] 34  | |     ( $( #[$stability: meta] $Ty: ident($Int: ty); )+ ) => {
[00:04:38] 36  | |             doc_comment! {
[00:04:38] ...   |
[00:04:38] 71  | |                         Some(unsafe { $Ty(n) })
[00:04:38]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:38]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:04:38] ...   |
[00:04:38] 97  | |     }
[00:04:38] 98  | | }
[00:04:38]     | |_- in this expansion of `nonzero_integers!`
[00:04:38] 100 | / nonzero_integers! {
[00:04:38] 101 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU8(u8);
[00:04:38] 102 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU16(u16);
[00:04:38] 103 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU32(u32);
---
[00:04:38] 
[00:04:38] warning: unused attribute
[00:04:38]    --> src/libcore/num/mod.rs:50:17
[00:04:38]     |
[00:04:38] 33  | / macro_rules! nonzero_integers {
[00:04:38] 34  | |     ( $( #[$stability: meta] $Ty: ident($Int: ty); )+ ) => {
[00:04:38] 36  | |             doc_comment! {
[00:04:38] ...   |
[00:04:38] 50  | |                 #[rustc_layout_scalar_valid_range_start(1)]
[00:04:38]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:38]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:38] ...   |
[00:04:38] 97  | |     }
[00:04:38] 98  | | }
[00:04:38]     | |_- in this expansion of `nonzero_integers!`
[00:04:38] 100 | / nonzero_integers! {
[00:04:38] 101 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU8(u8);
[00:04:38] 102 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU16(u16);
[00:04:38] 103 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU32(u32);
---
[00:04:38] 
[00:04:38] warning: unused attribute
[00:04:38]    --> src/libcore/num/mod.rs:50:17
[00:04:38]     |
[00:04:38] 33  | / macro_rules! nonzero_integers {
[00:04:38] 34  | |     ( $( #[$stability: meta] $Ty: ident($Int: ty); )+ ) => {
[00:04:38] 36  | |             doc_comment! {
[00:04:38] ...   |
[00:04:38] 50  | |                 #[rustc_layout_scalar_valid_range_start(1)]
[00:04:38]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:38]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:38] ...   |
[00:04:38] 97  | |     }
[00:04:38] 98  | | }
[00:04:38]     | |_- in this expansion of `nonzero_integers!`
[00:04:38] 100 | / nonzero_integers! {
[00:04:38] 101 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU8(u8);
[00:04:38] 102 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU16(u16);
[00:04:38] 103 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU32(u32);
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:15:10] 
[01:15:10] running 118 tests
[01:15:35] .iiiii...i.....i..i...i..i.i..i.ii..i.....i..i....i..........iiii..........i...ii...i.......ii.i.i.i 100/118
[01:15:40] ......iii.i.....ii
[01:15:40] 
[01:15:40]  finished in 29.821
[01:15:40] travis_fold:end:test_debuginfo

---

[01:38:47] travis_fold:start:test_stage1-rustc_driver
travis_time:start:test_stage1-rustc_driver
Testing rustc_driver stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:38:48] error[E0432]: unresolved import `driver`
[01:38:48]  --> src/librustc_driver/test.rs:3:5
[01:38:48] 3 | use driver;
[01:38:48]   |     ^^^^^^ no `driver` in the root
[01:38:48] 
[01:38:48] error[E0433]: failed to resolve: use of undeclared type or module `HashSet`
[01:38:48] error[E0433]: failed to resolve: use of undeclared type or module `HashSet`
[01:38:48]    --> src/librustc_driver/test.rs:105:20
[01:38:48]     |
[01:38:48] 105 |         crate_cfg: HashSet::new(),
[01:38:48]     |                    ^^^^^^^ use of undeclared type or module `HashSet`
[01:38:48] 
[01:38:48] error: unused import: `driver`
[01:38:48]  --> src/librustc_driver/test.rs:3:5
[01:38:48] 3 | use driver;
[01:38:48]   |     ^^^^^^
[01:38:48]   |
[01:38:48]   = note: `-D unused-imports` implied by `-D warnings`
[01:38:48]   = note: `-D unused-imports` implied by `-D warnings`
[01:38:48] 
[01:38:48] error: unused import: `errors`
[01:38:48]  --> src/librustc_driver/test.rs:4:5
[01:38:48]   |
[01:38:48] 4 | use errors;
[01:38:48]   |     ^^^^^^
[01:38:48] 
[01:38:48] error: unused import: `rustc::hir::map as hir_map`
[01:38:48]  --> src/librustc_driver/test.rs:8:5
[01:38:48]   |
[01:38:48] 8 | use rustc::hir::map as hir_map;
[01:38:48] 
[01:38:48] 
[01:38:48] error: unused imports: `OutputFilenames`, `OutputTypes`
[01:38:48]   --> src/librustc_driver/test.rs:12:30
[01:38:48]    |
[01:38:48] 12 | use rustc::session::config::{OutputFilenames, OutputTypes};
[01:38:48] 
[01:38:48] error: unused import: `self`
[01:38:48]   --> src/librustc_driver/test.rs:13:22
[01:38:48]    |
[01:38:48]    |
[01:38:48] 13 | use rustc::session::{self, config};
[01:38:48]    |                      ^^^^
[01:38:48] 
[01:38:48] error: unused import: `rustc::ty::query::OnDiskCache`
[01:38:48]   --> src/librustc_driver/test.rs:15:5
[01:38:48]    |
[01:38:48] 15 | use rustc::ty::query::OnDiskCache;
[01:38:48] 
[01:38:48] error: unused import: `Lrc`
[01:38:48]   --> src/librustc_driver/test.rs:18:41
[01:38:48]    |
[01:38:48]    |
[01:38:48] 18 | use rustc_data_structures::sync::{self, Lrc};
[01:38:48] 
[01:38:48] error: unused import: `rustc_lint`
[01:38:48]   --> src/librustc_driver/test.rs:19:5
[01:38:48]    |
---
[01:38:48]    |
[01:38:48] 23 | use syntax;
[01:38:48]    |     ^^^^^^
[01:38:48] 
[01:38:48] error: unused imports: `FilePathMapping`, `SourceMap`
[01:38:48]   --> src/librustc_driver/test.rs:26:36
[01:38:48]    |
[01:38:48] 26 | use syntax::source_map::{FileName, FilePathMapping, SourceMap, RealFileLoader};
[01:38:48] 
[01:38:48] error: unused import: `std::path::PathBuf`
[01:38:48]   --> src/librustc_driver/test.rs:29:5
[01:38:48]    |
---
[01:38:48] 
[01:38:48] error[E0308]: mismatched types
[01:38:48]    --> src/librustc_driver/test.rs:110:22
[01:38:48]     |
[01:38:48] 110 |         file_loader: box RealFileLoader,
[01:38:48]     |                      |
[01:38:48]     |                      expected enum `std::option::Option`, found struct `std::boxed::Box`
[01:38:48]     |                      expected enum `std::option::Option`, found struct `std::boxed::Box`
[01:38:48]     |                      help: try using a variant of the expected type: `Some(box RealFileLoader)`
[01:38:48]     |
[01:38:48]     = note: expected type `std::option::Option<std::boxed::Box<(dyn syntax::source_map::FileLoader + std::marker::Send + std::marker::Sync + 'static)>>`
[01:38:48]                found type `std::boxed::Box<syntax::source_map::RealFileLoader>`
[01:38:49] error[E0308]: mismatched types
[01:38:49]    --> src/librustc_driver/test.rs:111:9
[01:38:49]     |
[01:38:49] 111 |         emitter,
[01:38:49] 111 |         emitter,
[01:38:49]     |         ^^^^^^^ expected enum `std::option::Option`, found struct `std::boxed::Box`
[01:38:49]     |
[01:38:49]     = note: expected type `std::option::Option<std::boxed::Box<(dyn std::io::Write + std::marker::Send + 'static)>>`
[01:38:49]                found type `std::boxed::Box<(dyn errors::emitter::Emitter + rustc_data_structures::sync::Send + 'static)>`
[01:38:49] error[E0308]: mismatched types
[01:38:49]    --> src/librustc_driver/test.rs:113:21
[01:38:49]     |
[01:38:49] 113 |         crate_name: "test".to_owned(),
[01:38:49] 113 |         crate_name: "test".to_owned(),
[01:38:49]     |                     ^^^^^^^^^^^^^^^^^
[01:38:49]     |                     |
[01:38:49]     |                     expected enum `std::option::Option`, found struct `std::string::String`
[01:38:49]     |                     help: try using a variant of the expected type: `Some("test".to_owned())`
[01:38:49]     = note: expected type `std::option::Option<std::string::String>`
[01:38:49]                found type `std::string::String`
[01:38:49] 
[01:38:49] 
[01:38:49] error[E0599]: no method named `enter` found for type `&rustc_interface::queries::Query<rustc_interface::passes::BoxedGlobalCtxt<'_>>` in the current scope
[01:38:49]    --> src/librustc_driver/test.rs:117:41
[01:38:49]     |
[01:38:49] 117 |         compiler.global_ctxt().unwrap().enter(|tcx| {
[01:38:49] 
[01:38:49] error: aborting due to 19 previous errors
[01:38:49] 
[01:38:49] Some errors occurred: E0308, E0432, E0433, E0599.
[01:38:49] Some errors occurred: E0308, E0432, E0433, E0599.
[01:38:49] For more information about an error, try `rustc --explain E0308`.
[01:38:49] error: Could not compile `rustc_driver`.
[01:38:49] 
[01:38:49] To learn more, run the command again with --verbose.
[01:38:49] 
[01:38:49] 
[01:38:49] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "-p" "rustc_driver" "--" "--quiet"
[01:38:49] 
[01:38:49] 
[01:38:49] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:38:49] Build completed unsuccessfully in 0:35:36
[01:38:49] Build completed unsuccessfully in 0:35:36
[01:38:49] Makefile:48: recipe for target 'check' failed
[01:38:49] make: *** [check] Error 1
137388 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps
124936 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu
124932 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release
122028 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps
---
61484 ./obj/build/x86_64-unknown-linux-gnu/stage1-std
59636 ./obj/build/x86_64-unknown-linux-gnu/stage2-tools
56896 ./src/llvm/test/MC
56260 ./.git/modules/src/tools
E=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:089735ea
travis_time:start:089735ea
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:090e7156
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

wip
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 22, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:05b4342c:start=1548180061259790079,finish=1548180136919798086,duration=75660008007
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:03:37]    Compiling rustc_tsan v0.0.0 (/checkout/src/librustc_tsan)
[00:03:54] warning: unnecessary `unsafe` block
[00:03:54]    --> src/libcore/num/mod.rs:71:30
[00:03:54]     |
[00:03:54] 33  | / macro_rules! nonzero_integers {
[00:03:54] 34  | |     ( $( #[$stability: meta] $Ty: ident($Int: ty); )+ ) => {
[00:03:54] 36  | |             doc_comment! {
[00:03:54] ...   |
[00:03:54] 71  | |                         Some(unsafe { $Ty(n) })
[00:03:54]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:03:54]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:03:54] ...   |
[00:03:54] 97  | |     }
[00:03:54] 98  | | }
[00:03:54]     | |_- in this expansion of `nonzero_integers!`
[00:03:54] 100 | / nonzero_integers! {
[00:03:54] 101 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU8(u8);
[00:03:54] 102 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU16(u16);
[00:03:54] 103 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU32(u32);
---
[00:03:54] 
[00:03:54] warning: unnecessary `unsafe` block
[00:03:54]    --> src/libcore/num/mod.rs:71:30
[00:03:54]     |
[00:03:54] 33  | / macro_rules! nonzero_integers {
[00:03:54] 34  | |     ( $( #[$stability: meta] $Ty: ident($Int: ty); )+ ) => {
[00:03:54] 36  | |             doc_comment! {
[00:03:54] ...   |
[00:03:54] 71  | |                         Some(unsafe { $Ty(n) })
[00:03:54]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:03:54]     | |                              ^^^^^^ unnecessary `unsafe` block
[00:03:54] ...   |
[00:03:54] 97  | |     }
[00:03:54] 98  | | }
[00:03:54]     | |_- in this expansion of `nonzero_integers!`
[00:03:54] 100 | / nonzero_integers! {
[00:03:54] 101 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU8(u8);
[00:03:54] 102 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU16(u16);
[00:03:54] 103 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU32(u32);
---
[00:03:54] 
[00:03:54] warning: unused attribute
[00:03:54]    --> src/libcore/num/mod.rs:50:17
[00:03:54]     |
[00:03:54] 33  | / macro_rules! nonzero_integers {
[00:03:54] 34  | |     ( $( #[$stability: meta] $Ty: ident($Int: ty); )+ ) => {
[00:03:54] 36  | |             doc_comment! {
[00:03:54] ...   |
[00:03:54] 50  | |                 #[rustc_layout_scalar_valid_range_start(1)]
[00:03:54]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:03:54]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:03:54] ...   |
[00:03:54] 97  | |     }
[00:03:54] 98  | | }
[00:03:54]     | |_- in this expansion of `nonzero_integers!`
[00:03:54] 100 | / nonzero_integers! {
[00:03:54] 101 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU8(u8);
[00:03:54] 102 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU16(u16);
[00:03:54] 103 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU32(u32);
---
[00:03:54] 
[00:03:54] warning: unused attribute
[00:03:54]    --> src/libcore/num/mod.rs:50:17
[00:03:54]     |
[00:03:54] 33  | / macro_rules! nonzero_integers {
[00:03:54] 34  | |     ( $( #[$stability: meta] $Ty: ident($Int: ty); )+ ) => {
[00:03:54] 36  | |             doc_comment! {
[00:03:54] ...   |
[00:03:54] 50  | |                 #[rustc_layout_scalar_valid_range_start(1)]
[00:03:54]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:03:54]     | |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:03:54] ...   |
[00:03:54] 97  | |     }
[00:03:54] 98  | | }
[00:03:54]     | |_- in this expansion of `nonzero_integers!`
[00:03:54] 100 | / nonzero_integers! {
[00:03:54] 101 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU8(u8);
[00:03:54] 102 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU16(u16);
[00:03:54] 103 | |     #[stable(feature = "nonzero", since = "1.28.0")] NonZeroU32(u32);
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:12:32] 
[01:12:32] running 118 tests
[01:12:57] .iiiii...i.....i..i...i..i.i..i.ii..i.....i..i....i..........iiii..........i...ii...i.......ii.i.i.i 100/118
[01:13:01] ......iii.i.....ii
[01:13:01] 
[01:13:01]  finished in 28.927
[01:13:01] travis_fold:end:test_debuginfo

---
[01:35:17]    Compiling rustc_driver v0.0.0 (/checkout/src/librustc_driver)
[01:35:18] error[E0433]: failed to resolve: use of undeclared type or module `HashSet`
[01:35:18]   --> src/librustc_driver/test.rs:98:20
[01:35:18]    |
[01:35:18] 98 |         crate_cfg: HashSet::new(),
[01:35:18]    |                    ^^^^^^^ use of undeclared type or module `HashSet`
[01:35:18] error: unused import: `rustc_metadata::cstore::CStore`
[01:35:18]   --> src/librustc_driver/test.rs:14:5
[01:35:18]    |
[01:35:18] 14 | use rustc_metadata::cstore::CStore;
---
[01:35:18] 
[01:35:18] error[E0308]: mismatched types
[01:35:18]    --> src/librustc_driver/test.rs:104:23
[01:35:18]     |
[01:35:18] 104 |         emitter: Some(emitter),
[01:35:18]     |                       ^^^^^^^ expected trait `std::io::Write`, found trait `errors::emitter::Emitter`
[01:35:18]     = note: expected type `std::boxed::Box<dyn std::io::Write + std::marker::Send>`
[01:35:18]     = note: expected type `std::boxed::Box<dyn std::io::Write + std::marker::Send>`
[01:35:18]                found type `std::boxed::Box<(dyn errors::emitter::Emitter + rustc_data_structures::sync::Send + 'static)>`
[01:35:19] error: aborting due to 5 previous errors
[01:35:19] 
[01:35:19] Some errors occurred: E0308, E0433.
[01:35:19] For more information about an error, try `rustc --explain E0308`.
[01:35:19] For more information about an error, try `rustc --explain E0308`.
[01:35:19] error: Could not compile `rustc_driver`.
[01:35:19] 
[01:35:19] To learn more, run the command again with --verbose.
[01:35:19] 
[01:35:19] 
[01:35:19] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "-p" "rustc_driver" "--" "--quiet"
[01:35:19] 
[01:35:19] 
[01:35:19] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:35:19] Build completed unsuccessfully in 0:34:22
[01:35:19] Build completed unsuccessfully in 0:34:22
[01:35:19] Makefile:48: recipe for target 'check' failed
[01:35:19] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:02e40a00
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Jan 22 19:37:44 UTC 2019
---
travis_time:end:0f3784d0:start=1548185866388019179,finish=1548185866441094662,duration=53075483
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0046a2c4
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:05e85c3d
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment