Combine all builtin late lints and make lint checking parallel #58019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Zoxc
force-pushed
the
combine-late-lints
branch
from
8d86971
to
c76b767
Compare
|
r=me ++ |
estebank
added
S-blocked
This comment has been minimized.
This comment has been minimized.
Zoxc
force-pushed
the
combine-late-lints
branch
from
c76b767
to
abba103
Compare
This comment has been minimized.
This comment has been minimized.
Zoxc
force-pushed
the
combine-late-lints
branch
from
abba103
to
4b9290d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-bors
bors
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Zoxc
force-pushed
the
combine-late-lints
branch
from
d57f98e
to
4cab76e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Zoxc
force-pushed
the
combine-late-lints
branch
from
4cab76e
to
86d8c49
Compare
This comment has been minimized.
This comment has been minimized.
Zoxc
force-pushed
the
combine-late-lints
branch
from
86d8c49
to
5eb24ed
Compare
|
@bors try |
|
⌛ Trying commit 5eb24edc8d9921231ec8589c1f9d1e16489711a2 with merge eaad254355cc991c01011b6327e9cf27bfad670c... |
|
☀️ Try build successful - checks-travis |
|
@rust-timer build eaad254355cc991c01011b6327e9cf27bfad670c |
|
Success: Queued eaad254355cc991c01011b6327e9cf27bfad670c with parent 0f88167, comparison URL. |
|
Finished benchmarking try commit eaad254355cc991c01011b6327e9cf27bfad670c |
estebank
added
the
S-blocked
Zoxc
force-pushed
the
combine-late-lints
branch
from
5eb24ed
to
dee389f
Compare
|
@bors r=estebank |
|
📌 Commit dee389f has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 29, 2019
Combine all builtin late lints and make lint checking parallel Blocked on rust-lang#57293. Cuts runtime of late lint checking from 3.222s to 0.546s with 8 threads on `winapi` (@retep998 ;) ) r? @estebank
bors
added a commit
that referenced
this pull request
Mar 29, 2019
Rollup of 11 pull requests Successful merges: - #58019 (Combine all builtin late lints and make lint checking parallel) - #59358 (Use `track_errors` instead of hand rolling) - #59394 (warn -> deny duplicate match bindings) - #59401 (bootstrap: build crates under libtest with -Z emit-stack-sizes) - #59423 (Visit path in `walk_mac`) - #59468 (musl: build toolchain libs with -fPIC) - #59476 (Use `SmallVec` in `TokenStreamBuilder`.) - #59496 (Remove unnecessary with_globals calls) - #59498 (Use 'write_all' instead of 'write' in example code) - #59503 (Stablize {f32,f64}::copysign().) - #59511 (Fix missed fn rename in #59284) Failed merges: r? @ghost
bors
added a commit
that referenced
this pull request
Mar 29, 2019
Rollup of 11 pull requests Successful merges: - #58019 (Combine all builtin late lints and make lint checking parallel) - #59358 (Use `track_errors` instead of hand rolling) - #59394 (warn -> deny duplicate match bindings) - #59401 (bootstrap: build crates under libtest with -Z emit-stack-sizes) - #59423 (Visit path in `walk_mac`) - #59468 (musl: build toolchain libs with -fPIC) - #59476 (Use `SmallVec` in `TokenStreamBuilder`.) - #59496 (Remove unnecessary with_globals calls) - #59498 (Use 'write_all' instead of 'write' in example code) - #59503 (Stablize {f32,f64}::copysign().) - #59511 (Fix missed fn rename in #59284) Failed merges: r? @ghost
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on #57293.
Cuts runtime of late lint checking from 3.222s to 0.546s with 8 threads on
winapi(@retep998 ;) )r? @estebank