Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stablize {f32,f64}::copysign(). #59503

Merged
merged 1 commit into from Mar 29, 2019

Conversation

Projects
None yet
7 participants
@crlf0710
Copy link
Contributor

crlf0710 commented Mar 28, 2019

Stablization PR for #55169/#58046. Please check if i'm doing it correctly. Is 1.35.0 good to go?

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Mar 28, 2019

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@crlf0710

This comment has been minimized.

Copy link
Contributor Author

crlf0710 commented Mar 28, 2019

@crlf0710 crlf0710 force-pushed the crlf0710:stablize_copysign branch from 0e7e191 to d9bdd01 Mar 28, 2019

@SimonSapin

This comment has been minimized.

Copy link
Contributor

SimonSapin commented Mar 28, 2019

Yes this is perfect. Thanks!

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 28, 2019

📌 Commit d9bdd01 has been approved by SimonSapin

@Centril Centril added this to the 1.35 milestone Mar 28, 2019

@jethrogb

This comment has been minimized.

Copy link
Contributor

jethrogb commented Mar 29, 2019

Should the names of these methods be copy_sign?

Centril added a commit to Centril/rust that referenced this pull request Mar 29, 2019

Rollup merge of rust-lang#59503 - crlf0710:stablize_copysign, r=Simon…
…Sapin

Stablize {f32,f64}::copysign().

Stablization PR for rust-lang#55169/rust-lang#58046. Please check if i'm doing it correctly. Is 1.35.0 good to go?

bors added a commit that referenced this pull request Mar 29, 2019

Auto merge of #59513 - Centril:rollup, r=Centril
Rollup of 11 pull requests

Successful merges:

 - #58019 (Combine all builtin late lints and make lint checking parallel)
 - #59358 (Use `track_errors` instead of hand rolling)
 - #59394 (warn -> deny duplicate match bindings)
 - #59401 (bootstrap: build crates under libtest with -Z emit-stack-sizes)
 - #59423 (Visit path in `walk_mac`)
 - #59468 (musl: build toolchain libs with -fPIC)
 - #59476 (Use `SmallVec` in `TokenStreamBuilder`.)
 - #59496 (Remove unnecessary with_globals calls)
 - #59498 (Use 'write_all' instead of 'write' in example code)
 - #59503 (Stablize {f32,f64}::copysign().)
 - #59511 (Fix missed fn rename in #59284)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request Mar 29, 2019

Auto merge of #59513 - Centril:rollup, r=Centril
Rollup of 11 pull requests

Successful merges:

 - #58019 (Combine all builtin late lints and make lint checking parallel)
 - #59358 (Use `track_errors` instead of hand rolling)
 - #59394 (warn -> deny duplicate match bindings)
 - #59401 (bootstrap: build crates under libtest with -Z emit-stack-sizes)
 - #59423 (Visit path in `walk_mac`)
 - #59468 (musl: build toolchain libs with -fPIC)
 - #59476 (Use `SmallVec` in `TokenStreamBuilder`.)
 - #59496 (Remove unnecessary with_globals calls)
 - #59498 (Use 'write_all' instead of 'write' in example code)
 - #59503 (Stablize {f32,f64}::copysign().)
 - #59511 (Fix missed fn rename in #59284)

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 29, 2019

☔️ The latest upstream changes (presumably #59513) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors merged commit d9bdd01 into rust-lang:master Mar 29, 2019

@crlf0710 crlf0710 deleted the crlf0710:stablize_copysign branch Mar 29, 2019

matklad added a commit to matklad/rust that referenced this pull request Apr 17, 2019

Auto merge of rust-lang#59513 - Centril:rollup, r=Centril
Rollup of 11 pull requests

Successful merges:

 - rust-lang#58019 (Combine all builtin late lints and make lint checking parallel)
 - rust-lang#59358 (Use `track_errors` instead of hand rolling)
 - rust-lang#59394 (warn -> deny duplicate match bindings)
 - rust-lang#59401 (bootstrap: build crates under libtest with -Z emit-stack-sizes)
 - rust-lang#59423 (Visit path in `walk_mac`)
 - rust-lang#59468 (musl: build toolchain libs with -fPIC)
 - rust-lang#59476 (Use `SmallVec` in `TokenStreamBuilder`.)
 - rust-lang#59496 (Remove unnecessary with_globals calls)
 - rust-lang#59498 (Use 'write_all' instead of 'write' in example code)
 - rust-lang#59503 (Stablize {f32,f64}::copysign().)
 - rust-lang#59511 (Fix missed fn rename in rust-lang#59284)

Failed merges:

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.