Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hir: add more HirId methods #58139

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
4 participants
@ljedrz
Copy link
Contributor

ljedrz commented Feb 4, 2019

Adds a few more methods operating on HirId instead of NodeId with the intention of replacing the old ones in the near future.

r? @Zoxc

@ljedrz ljedrz force-pushed the ljedrz:HirIdification_phase_2.5 branch 3 times, most recently from be75f4e to 26797a5 Feb 4, 2019

@ljedrz ljedrz force-pushed the ljedrz:HirIdification_phase_2.5 branch from 26797a5 to 927614f Feb 4, 2019

@ljedrz ljedrz referenced this pull request Feb 4, 2019

Merged

Partially HirId-ify rustc #58151

@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Feb 4, 2019

@bors r+

This was referenced Feb 4, 2019

@ljedrz

This comment has been minimized.

Copy link
Contributor Author

ljedrz commented Feb 4, 2019

@Zoxc somehing's off; has @bors noticed the approval?

@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Feb 4, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 4, 2019

📌 Commit 927614f has been approved by Zoxc

@ljedrz ljedrz referenced this pull request Feb 4, 2019

Merged

HirId-ify hir::BodyId #58167

kennytm added a commit to kennytm/rust that referenced this pull request Feb 5, 2019

Rollup merge of rust-lang#58139 - ljedrz:HirIdification_phase_2.5, r=…
…Zoxc

hir: add more HirId methods

Adds a few more methods operating on `HirId` instead of `NodeId` with the intention of replacing the old ones in the near future.

r? @Zoxc

bors added a commit that referenced this pull request Feb 5, 2019

Auto merge of #58189 - kennytm:rollup, r=kennytm
Rollup of 23 pull requests

Successful merges:

 - #58001 (proc_macro: make `TokenStream::from_streams` pre-allocate its vector.)
 - #58096 (Transition linkchecker to 2018 edition)
 - #58097 (Transition remote test to Rust 2018)
 - #58106 (libfmt_macros => 2018)
 - #58107 (libgraphviz => 2018)
 - #58108 (Add NVPTX target to a build manifest)
 - #58109 (librustc_privacy => 2018)
 - #58112 (libpanic_abort => 2018)
 - #58113 (Transition build-manifest to 2018 edition)
 - #58114 (Transition tidy and unstable-book-gen to 2018 edition)
 - #58116 (Include the span of attributes of the lhs to the span of the assignment expression)
 - #58117 (Transition rustdoc-theme to 2018 edition)
 - #58128 (libunwind => 2018)
 - #58138 (Fix #58101)
 - #58139 (hir: add more HirId methods)
 - #58141 (Remove weasel word in docs for iter's take_while())
 - #58142 (Remove stray FIXME)
 - #58145 (Add #[must_use] to core::task::Poll)
 - #58162 (Add more debugging code to track down appveyor 259 exit code)
 - #58169 (Update contributor name in .mailmap)
 - #58172 (update split docs)
 - #58182 (SGX target: handle empty user buffers correctly)
 - #58186 (Add Rustlings to the doc index)

Failed merges:

r? @ghost

@bors bors merged commit 927614f into rust-lang:master Feb 5, 2019

@ljedrz ljedrz deleted the ljedrz:HirIdification_phase_2.5 branch Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.