Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #[must_use] to core::task::Poll #58145

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
5 participants
@taiki-e
Copy link
Contributor

taiki-e commented Feb 4, 2019

@withoutboats

This comment has been minimized.

Copy link
Contributor

withoutboats commented Feb 4, 2019

I'm a big +1 on this; going to hand it off to cramertj to r plus in case he has an objection.

r? @cramertj

@cramertj

This comment has been minimized.

Copy link
Member

cramertj commented Feb 5, 2019

@bors r+ rollup

Yup, seems great to me

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 5, 2019

📌 Commit 4847c09 has been approved by cramertj

kennytm added a commit to kennytm/rust that referenced this pull request Feb 5, 2019

bors added a commit that referenced this pull request Feb 5, 2019

Auto merge of #58189 - kennytm:rollup, r=kennytm
Rollup of 23 pull requests

Successful merges:

 - #58001 (proc_macro: make `TokenStream::from_streams` pre-allocate its vector.)
 - #58096 (Transition linkchecker to 2018 edition)
 - #58097 (Transition remote test to Rust 2018)
 - #58106 (libfmt_macros => 2018)
 - #58107 (libgraphviz => 2018)
 - #58108 (Add NVPTX target to a build manifest)
 - #58109 (librustc_privacy => 2018)
 - #58112 (libpanic_abort => 2018)
 - #58113 (Transition build-manifest to 2018 edition)
 - #58114 (Transition tidy and unstable-book-gen to 2018 edition)
 - #58116 (Include the span of attributes of the lhs to the span of the assignment expression)
 - #58117 (Transition rustdoc-theme to 2018 edition)
 - #58128 (libunwind => 2018)
 - #58138 (Fix #58101)
 - #58139 (hir: add more HirId methods)
 - #58141 (Remove weasel word in docs for iter's take_while())
 - #58142 (Remove stray FIXME)
 - #58145 (Add #[must_use] to core::task::Poll)
 - #58162 (Add more debugging code to track down appveyor 259 exit code)
 - #58169 (Update contributor name in .mailmap)
 - #58172 (update split docs)
 - #58182 (SGX target: handle empty user buffers correctly)
 - #58186 (Add Rustlings to the doc index)

Failed merges:

r? @ghost

@bors bors merged commit 4847c09 into rust-lang:master Feb 5, 2019

@taiki-e taiki-e deleted the taiki-e:poll branch Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.