Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NLL] Type check operations with pointer types #58673

Merged
merged 2 commits into from Mar 3, 2019

Conversation

Projects
None yet
4 participants
@matthewjasper
Copy link
Contributor

matthewjasper commented Feb 23, 2019

It seems these were forgotten about. Moving to Rvalue::AddressOf simplifies the coercions from references, but I want this to be fixed as soon as possible.

r? @pnkfelix

@matthewjasper matthewjasper changed the title [NLL] Type check coercions to pointer types [NLL] Type check operations with pointer types Feb 24, 2019

@matthewjasper matthewjasper force-pushed the matthewjasper:typeck-ptr-coercions branch from 2867db7 to 19a54e8 Feb 24, 2019

}
}

Rvalue::Ref(region, _borrow_kind, borrowed_place) => {
self.add_reborrow_constraint(location, region, borrowed_place);
}

// FIXME: These other cases have to be implemented in future PRs

This comment has been minimized.

@pnkfelix
@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Feb 27, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 27, 2019

📌 Commit 19a54e8 has been approved by pnkfelix

@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Feb 27, 2019

Important detail which might get overlooked since I don't see a bug associated with this PR: the problem here is only exposed via #![feature(nll)] (or -Z borrowck=mir). It does not affect borrowck=migrate and thus does not affect the 2018 edition stable/beta. The only people who might get impacted by this in the same manner that rustc did are those opting into #![feature(nll)] on nightly.

cc #58781

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 3, 2019

⌛️ Testing commit 19a54e8 with merge 2cfd644...

bors added a commit that referenced this pull request Mar 3, 2019

Auto merge of #58673 - matthewjasper:typeck-ptr-coercions, r=pnkfelix
[NLL] Type check operations with pointer types

It seems these were forgotten about. Moving to `Rvalue::AddressOf` simplifies the coercions from references, but I want this to be fixed as soon as possible.

r? @pnkfelix
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 3, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: pnkfelix
Pushing 2cfd644 to master...

@bors bors added the merged-by-bors label Mar 3, 2019

@bors bors merged commit 19a54e8 into rust-lang:master Mar 3, 2019

1 check passed

homu Test successful
Details

@matthewjasper matthewjasper deleted the matthewjasper:typeck-ptr-coercions branch Mar 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.