[NLL] Type check operations with pointer types #58673
Conversation
rust-highfive
added
the
S-waiting-on-review
matthewjasper
changed the title
matthewjasper
force-pushed
the
typeck-ptr-coercions
branch
from
2867db7
to
19a54e8
Compare
| } | ||
| } | ||
|
|
||
| Rvalue::Ref(region, _borrow_kind, borrowed_place) => { | ||
| self.add_reborrow_constraint(location, region, borrowed_place); | ||
| } | ||
|
|
||
| // FIXME: These other cases have to be implemented in future PRs |
|
@bors r+ |
|
📌 Commit 19a54e8 has been approved by |
bors
added
S-waiting-on-bors
|
Important detail which might get overlooked since I don't see a bug associated with this PR: the problem here is only exposed via cc #58781 Update: My claim here was false due to flawed reasoning on my part. There are examples where AST-borrowck rejects the code but the previous version of NLL accepts it, which then causes changes like this to be hard errors under migrate mode. See for example #60927 (comment) |
[NLL] Type check operations with pointer types It seems these were forgotten about. Moving to `Rvalue::AddressOf` simplifies the coercions from references, but I want this to be fixed as soon as possible. r? @pnkfelix
|
☀️ Test successful - checks-travis, status-appveyor |
It seems these were forgotten about. Moving to
Rvalue::AddressOfsimplifies the coercions from references, but I want this to be fixed as soon as possible.r? @pnkfelix