Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcore => 2018 #58702

Merged
merged 2 commits into from
Apr 18, 2019
Merged

libcore => 2018 #58702

merged 2 commits into from
Apr 18, 2019

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Feb 24, 2019

Transitions libcore to Rust 2018; cc #58099

r? @Centril

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 24, 2019
@gnzlbg

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@taiki-e taiki-e force-pushed the libcore-2018 branch 2 times, most recently from 8674a12 to ec2305e Compare February 27, 2019 05:40
@taiki-e taiki-e marked this pull request as ready for review February 27, 2019 05:40
@taiki-e taiki-e changed the title [WIP] libcore => 2018 libcore => 2018 Feb 27, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@taiki-e
Copy link
Member Author

taiki-e commented Mar 1, 2019 •
edited
Loading 

[00:04:33] error[E0433]: failed to resolve: could not find `ops` in `{{root}}`
[00:04:33] 
[00:04:33] error[E0433]: failed to resolve: could not find `option` in `{{root}}`
[00:04:33] 
[00:04:33] error[E0433]: failed to resolve: could not find `iter` in `{{root}}`
[00:04:33] 
[00:04:33] error[E0433]: failed to resolve: could not find `result` in `{{root}}`
[00:04:33] 
[00:04:33] error[E0433]: failed to resolve: could not find `convert` in `{{root}}`

I don't know where these errors came from...

@rust-highfive

This comment has been minimized.

Sign in to view
@Centril Centril mentioned this pull request Mar 26, 2019
Closed
78 tasks
@Centril
Copy link
Contributor

Centril commented Mar 26, 2019

@taiki-e Could you try to limit this PR to just the bare minimum that is needed to get core into 2018? Maybe that will weed out the cause of the failure...

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
travis_time:end:1c2b4fa0:start=1553630486191812076,finish=1553630488653152030,duration=2461339954
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---
[00:04:02]    Compiling libc v0.2.50
[00:04:02]    Compiling core v0.0.0 (/checkout/src/libcore)
[00:04:02]    Compiling unwind v0.0.0 (/checkout/src/libunwind)
[00:04:02]    Compiling build_helper v0.1.0 (/checkout/src/build_helper)
[00:04:07] error[E0433]: failed to resolve: could not find `ops` in `{{root}}`
[00:04:07] 
[00:04:07] error[E0433]: failed to resolve: could not find `option` in `{{root}}`
[00:04:07] 
[00:04:07] error[E0433]: failed to resolve: could not find `iter` in `{{root}}`
[00:04:07] 
[00:04:07] error[E0433]: failed to resolve: could not find `result` in `{{root}}`
[00:04:07] 
[00:04:07] error[E0433]: failed to resolve: could not find `convert` in `{{root}}`
[00:04:07]    Compiling compiler_builtins v0.1.5
[00:04:07]    Compiling cmake v0.1.33
[00:04:07]    Compiling backtrace-sys v0.1.27
[00:04:10]    Compiling std v0.0.0 (/checkout/src/libstd)
---
[00:04:16]     |
[00:04:16] 492 |         for entry in entries {
[00:04:16]     |             ^^^^^ doesn't have a size known at compile-time
[00:04:16]     |
[00:04:16]     = help: the trait `marker::Sized` is not implemented for `dyn fmt::Debug`
[00:04:16]     = note: to learn more, visit <https://doc.rust-lang.org/book/ch19-04-advanced-types.html#dynamically-sized-types-and-the-sized-trait>
[00:04:16]     = note: the left-hand-side of an assignment must have a statically known size
[00:04:16] error[E0277]: the size for values of type `dyn fmt::Debug` cannot be known at compilation time
[00:04:16]    --> src/libcore/fmt/builders.rs:630:13
[00:04:16]     |
[00:04:16] 630 |         for entry in entries {
[00:04:16] 630 |         for entry in entries {
[00:04:16]     |             ^^^^^ doesn't have a size known at compile-time
[00:04:16]     |
[00:04:16]     = help: the trait `marker::Sized` is not implemented for `dyn fmt::Debug`
[00:04:16]     = note: to learn more, visit <https://doc.rust-lang.org/book/ch19-04-advanced-types.html#dynamically-sized-types-and-the-sized-trait>
[00:04:16]     = note: the left-hand-side of an assignment must have a statically known size
[00:04:16] error[E0277]: the size for values of type `dyn fmt::Debug` cannot be known at compilation time
[00:04:16]    --> src/libcore/fmt/builders.rs:791:13
[00:04:16]     |
[00:04:16]     |
[00:04:16] 791 |         for (k, v) in entries {
[00:04:16]     |
[00:04:16]     |
[00:04:16]     = help: within `(dyn fmt::Debug, dyn fmt::Debug)`, the trait `marker::Sized` is not implemented for `dyn fmt::Debug`
[00:04:16]     = note: to learn more, visit <https://doc.rust-lang.org/book/ch19-04-advanced-types.html#dynamically-sized-types-and-the-sized-trait>
[00:04:16]     = note: required because it appears within the type `(dyn fmt::Debug, dyn fmt::Debug)`
[00:04:16]     = note: the left-hand-side of an assignment must have a statically known size
[00:04:18] error: aborting due to 8 previous errors
[00:04:18] 
[00:04:18] Some errors occurred: E0277, E0433.
[00:04:18] For more information about an error, try `rustc --explain E0277`.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@taiki-e taiki-e mentioned this pull request Mar 27, 2019
Merged
@taiki-e
Copy link
Member Author

taiki-e commented Mar 27, 2019

Blocked on #59462

@Centril Centril added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2019
This was referenced Mar 28, 2019
Closed
Closed
@bors
Copy link
Contributor

bors commented Apr 17, 2019

⌛ Testing commit 34fe661214ed7e30c92981c50fee8bb3e73bd519 with merge 2d7caed375e2ab99e5f03e1e4bc991d622979f6d...

@bors
Copy link
Contributor

bors commented Apr 17, 2019

💔 Test failed - checks-travis

@rust-highfive
Copy link
Collaborator

The job dist-arm-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:25:54]    Compiling unwind v0.0.0 (/checkout/src/libunwind)
[00:25:56] error[E0433]: failed to resolve: use of undeclared type or module `core_arch`
[00:25:56]   --> src/libcore/../stdsimd/crates/core_arch/src/acle/simd32.rs:69:5
[00:25:56]    |
[00:25:56] 69 | use core_arch::acle::dsp::int16x2_t;
[00:25:56]    |     ^^^^^^^^^ use of undeclared type or module `core_arch`
[00:25:56] 
[00:25:57] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 191 | pub unsafe fn __qsub16(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:57] help: a struct with a similar name exists
[00:25:57]     |
[00:25:57]     |
[00:25:57] 191 | pub unsafe fn __qsub16(a: int8x4_t, b: int16x2_t) -> int16x2_t {
[00:25:57] help: possible candidate is found in another module, you can import it into scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:57] 
[00:25:57] 
[00:25:57] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 191 | pub unsafe fn __qsub16(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:57] help: a struct with a similar name exists
[00:25:57]     |
[00:25:57]     |
[00:25:57] 191 | pub unsafe fn __qsub16(a: int16x2_t, b: int8x4_t) -> int16x2_t {
[00:25:57] help: possible candidate is found in another module, you can import it into scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:57] 
[00:25:57] 
[00:25:57] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 191 | pub unsafe fn __qsub16(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:57] help: a struct with a similar name exists
[00:25:57]     |
[00:25:57]     |
[00:25:57] 191 | pub unsafe fn __qsub16(a: int16x2_t, b: int16x2_t) -> int8x4_t {
[00:25:57] help: possible candidate is found in another module, you can import it into scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:57] 
[00:25:57] 
[00:25:57] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 203 | pub unsafe fn __qadd16(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:57] help: a struct with a similar name exists
[00:25:57]     |
[00:25:57]     |
[00:25:57] 203 | pub unsafe fn __qadd16(a: int8x4_t, b: int16x2_t) -> int16x2_t {
[00:25:57] help: possible candidate is found in another module, you can import it into scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:57] 
[00:25:57] 
[00:25:57] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 203 | pub unsafe fn __qadd16(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:57] help: a struct with a similar name exists
[00:25:57]     |
[00:25:57]     |
[00:25:57] 203 | pub unsafe fn __qadd16(a: int16x2_t, b: int8x4_t) -> int16x2_t {
[00:25:57] help: possible candidate is found in another module, you can import it into scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:57] 
[00:25:57] 
[00:25:57] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 203 | pub unsafe fn __qadd16(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:57] help: a struct with a similar name exists
[00:25:57]     |
[00:25:57]     |
[00:25:57] 203 | pub unsafe fn __qadd16(a: int16x2_t, b: int16x2_t) -> int8x4_t {
[00:25:57] help: possible candidate is found in another module, you can import it into scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:57] 
[00:25:57] 
[00:25:57] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 213 | pub unsafe fn __qasx(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:57] help: a struct with a similar name exists
[00:25:57]     |
[00:25:57]     |
[00:25:57] 213 | pub unsafe fn __qasx(a: int8x4_t, b: int16x2_t) -> int16x2_t {
[00:25:57] help: possible candidate is found in another module, you can import it into scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:57] 
[00:25:57] 
[00:25:57] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 213 | pub unsafe fn __qasx(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:57] help: a struct with a similar name exists
[00:25:57]     |
[00:25:57]     |
[00:25:57] 213 | pub unsafe fn __qasx(a: int16x2_t, b: int8x4_t) -> int16x2_t {
[00:25:57] help: possible candidate is found in another module, you can import it into scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:57] 
[00:25:57] 
[00:25:57] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 213 | pub unsafe fn __qasx(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:57] help: a struct with a similar name exists
[00:25:57]     |
[00:25:57]     |
[00:25:57] 213 | pub unsafe fn __qasx(a: int16x2_t, b: int16x2_t) -> int8x4_t {
[00:25:57] help: possible candidate is found in another module, you can import it into scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:57] 
[00:25:57] 
[00:25:57] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 223 | pub unsafe fn __qsax(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:57] help: a struct with a similar name exists
[00:25:57]     |
[00:25:57]     |
[00:25:57] 223 | pub unsafe fn __qsax(a: int8x4_t, b: int16x2_t) -> int16x2_t {
[00:25:57] help: possible candidate is found in another module, you can import it into scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:57] 
[00:25:57] 
[00:25:57] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 223 | pub unsafe fn __qsax(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:57] help: a struct with a similar name exists
[00:25:57]     |
[00:25:57]     |
[00:25:57] 223 | pub unsafe fn __qsax(a: int16x2_t, b: int8x4_t) -> int16x2_t {
[00:25:57] help: possible candidate is found in another module, you can import it into scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:57] 
[00:25:57] 
[00:25:57] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 223 | pub unsafe fn __qsax(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:57] help: a struct with a similar name exists
[00:25:57]     |
[00:25:57]     |
[00:25:57] 223 | pub unsafe fn __qsax(a: int16x2_t, b: int16x2_t) -> int8x4_t {
[00:25:57] help: possible candidate is found in another module, you can import it into scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:57] 
[00:25:57] 
[00:25:57] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 235 | pub unsafe fn __sadd16(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:57] help: a struct with a similar name exists
[00:25:57]     |
[00:25:57]     |
[00:25:57] 235 | pub unsafe fn __sadd16(a: int8x4_t, b: int16x2_t) -> int16x2_t {
[00:25:57] help: possible candidate is found in another module, you can import it into scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:57] 
[00:25:57] 
[00:25:57] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 235 | pub unsafe fn __sadd16(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:57] help: a struct with a similar name exists
[00:25:57]     |
[00:25:57]     |
[00:25:57] 235 | pub unsafe fn __sadd16(a: int16x2_t, b: int8x4_t) -> int16x2_t {
[00:25:57] help: possible candidate is found in another module, you can import it into scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:57] 
[00:25:57] 
[00:25:57] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 235 | pub unsafe fn __sadd16(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:57] help: a struct with a similar name exists
[00:25:57]     |
[00:25:57]     |
[00:25:57] 235 | pub unsafe fn __sadd16(a: int16x2_t, b: int16x2_t) -> int8x4_t {
[00:25:57] help: possible candidate is found in another module, you can import it into scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:57] 
[00:25:57] 
[00:25:57] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 260 | pub unsafe fn __smlad(a: int16x2_t, b: int16x2_t, c: i32) -> i32 {
[00:25:57] help: a struct with a similar name exists
[00:25:57]     |
[00:25:57]     |
[00:25:57] 260 | pub unsafe fn __smlad(a: int8x4_t, b: int16x2_t, c: i32) -> i32 {
[00:25:57] help: possible candidate is found in another module, you can import it into scope
[00:25:57]     |
[00:25:57]     |
[00:25:57] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:57] 
[00:25:57] 
[00:25:58] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 260 | pub unsafe fn __smlad(a: int16x2_t, b: int16x2_t, c: i32) -> i32 {
[00:25:58] help: a struct with a similar name exists
[00:25:58]     |
[00:25:58]     |
[00:25:58] 260 | pub unsafe fn __smlad(a: int16x2_t, b: int8x4_t, c: i32) -> i32 {
[00:25:58] help: possible candidate is found in another module, you can import it into scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:58] 
[00:25:58] 
[00:25:58] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 271 | pub unsafe fn __smlsd(a: int16x2_t, b: int16x2_t, c: i32) -> i32 {
[00:25:58] help: a struct with a similar name exists
[00:25:58]     |
[00:25:58]     |
[00:25:58] 271 | pub unsafe fn __smlsd(a: int8x4_t, b: int16x2_t, c: i32) -> i32 {
[00:25:58] help: possible candidate is found in another module, you can import it into scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:58] 
[00:25:58] 
[00:25:58] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 271 | pub unsafe fn __smlsd(a: int16x2_t, b: int16x2_t, c: i32) -> i32 {
[00:25:58] help: a struct with a similar name exists
[00:25:58]     |
[00:25:58]     |
[00:25:58] 271 | pub unsafe fn __smlsd(a: int16x2_t, b: int8x4_t, c: i32) -> i32 {
[00:25:58] help: possible candidate is found in another module, you can import it into scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:58] 
[00:25:58] 
[00:25:58] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 283 | pub unsafe fn __sasx(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:58] help: a struct with a similar name exists
[00:25:58]     |
[00:25:58]     |
[00:25:58] 283 | pub unsafe fn __sasx(a: int8x4_t, b: int16x2_t) -> int16x2_t {
[00:25:58] help: possible candidate is found in another module, you can import it into scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:58] 
[00:25:58] 
[00:25:58] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 283 | pub unsafe fn __sasx(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:58] help: a struct with a similar name exists
[00:25:58]     |
[00:25:58]     |
[00:25:58] 283 | pub unsafe fn __sasx(a: int16x2_t, b: int8x4_t) -> int16x2_t {
[00:25:58] help: possible candidate is found in another module, you can import it into scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:58] 
[00:25:58] 
[00:25:58] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 283 | pub unsafe fn __sasx(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:58] help: a struct with a similar name exists
[00:25:58]     |
[00:25:58]     |
[00:25:58] 283 | pub unsafe fn __sasx(a: int16x2_t, b: int16x2_t) -> int8x4_t {
[00:25:58] help: possible candidate is found in another module, you can import it into scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:58] 
[00:25:58] 
[00:25:58] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 325 | pub unsafe fn __shadd16(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:58] help: a struct with a similar name exists
[00:25:58]     |
[00:25:58]     |
[00:25:58] 325 | pub unsafe fn __shadd16(a: int8x4_t, b: int16x2_t) -> int16x2_t {
[00:25:58] help: possible candidate is found in another module, you can import it into scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:58] 
[00:25:58] 
[00:25:58] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 325 | pub unsafe fn __shadd16(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:58] help: a struct with a similar name exists
[00:25:58]     |
[00:25:58]     |
[00:25:58] 325 | pub unsafe fn __shadd16(a: int16x2_t, b: int8x4_t) -> int16x2_t {
[00:25:58] help: possible candidate is found in another module, you can import it into scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:58] 
[00:25:58] 
[00:25:58] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 325 | pub unsafe fn __shadd16(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:58] help: a struct with a similar name exists
[00:25:58]     |
[00:25:58]     |
[00:25:58] 325 | pub unsafe fn __shadd16(a: int16x2_t, b: int16x2_t) -> int8x4_t {
[00:25:58] help: possible candidate is found in another module, you can import it into scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:58] 
[00:25:58] 
[00:25:58] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 385 | pub unsafe fn __shsub16(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:58] help: a struct with a similar name exists
[00:25:58]     |
[00:25:58]     |
[00:25:58] 385 | pub unsafe fn __shsub16(a: int8x4_t, b: int16x2_t) -> int16x2_t {
[00:25:58] help: possible candidate is found in another module, you can import it into scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:58] 
[00:25:58] 
[00:25:58] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 385 | pub unsafe fn __shsub16(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:58] help: a struct with a similar name exists
[00:25:58]     |
[00:25:58]     |
[00:25:58] 385 | pub unsafe fn __shsub16(a: int16x2_t, b: int8x4_t) -> int16x2_t {
[00:25:58] help: possible candidate is found in another module, you can import it into scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:58] 
[00:25:58] 
[00:25:58] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 385 | pub unsafe fn __shsub16(a: int16x2_t, b: int16x2_t) -> int16x2_t {
[00:25:58] help: a struct with a similar name exists
[00:25:58]     |
[00:25:58]     |
[00:25:58] 385 | pub unsafe fn __shsub16(a: int16x2_t, b: int16x2_t) -> int8x4_t {
[00:25:58] help: possible candidate is found in another module, you can import it into scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:58] 
[00:25:58] 
[00:25:58] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 398 | pub unsafe fn __smuad(a: int16x2_t, b: int16x2_t) -> i32 {
[00:25:58] help: a struct with a similar name exists
[00:25:58]     |
[00:25:58]     |
[00:25:58] 398 | pub unsafe fn __smuad(a: int8x4_t, b: int16x2_t) -> i32 {
[00:25:58] help: possible candidate is found in another module, you can import it into scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:58] 
[00:25:58] 
[00:25:58] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 398 | pub unsafe fn __smuad(a: int16x2_t, b: int16x2_t) -> i32 {
[00:25:58] help: a struct with a similar name exists
[00:25:58]     |
[00:25:58]     |
[00:25:58] 398 | pub unsafe fn __smuad(a: int16x2_t, b: int8x4_t) -> i32 {
[00:25:58] help: possible candidate is found in another module, you can import it into scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:58] 
[00:25:58] 
[00:25:58] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 411 | pub unsafe fn __smuadx(a: int16x2_t, b: int16x2_t) -> i32 {
[00:25:58] help: a struct with a similar name exists
[00:25:58]     |
[00:25:58]     |
[00:25:58] 411 | pub unsafe fn __smuadx(a: int8x4_t, b: int16x2_t) -> i32 {
[00:25:58] help: possible candidate is found in another module, you can import it into scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:58] 
[00:25:58] 
[00:25:58] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 411 | pub unsafe fn __smuadx(a: int16x2_t, b: int16x2_t) -> i32 {
[00:25:58] help: a struct with a similar name exists
[00:25:58]     |
[00:25:58]     |
[00:25:58] 411 | pub unsafe fn __smuadx(a: int16x2_t, b: int8x4_t) -> i32 {
[00:25:58] help: possible candidate is found in another module, you can import it into scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:58] 
[00:25:58] 
[00:25:58] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 424 | pub unsafe fn __smusd(a: int16x2_t, b: int16x2_t) -> i32 {
[00:25:58] help: a struct with a similar name exists
[00:25:58]     |
[00:25:58]     |
[00:25:58] 424 | pub unsafe fn __smusd(a: int8x4_t, b: int16x2_t) -> i32 {
[00:25:58] help: possible candidate is found in another module, you can import it into scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:58] 
[00:25:58] 
[00:25:58] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 424 | pub unsafe fn __smusd(a: int16x2_t, b: int16x2_t) -> i32 {
[00:25:58] help: a struct with a similar name exists
[00:25:58]     |
[00:25:58]     |
[00:25:58] 424 | pub unsafe fn __smusd(a: int16x2_t, b: int8x4_t) -> i32 {
[00:25:58] help: possible candidate is found in another module, you can import it into scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:58] 
[00:25:58] 
[00:25:58] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 437 | pub unsafe fn __smusdx(a: int16x2_t, b: int16x2_t) -> i32 {
[00:25:58] help: a struct with a similar name exists
[00:25:58]     |
[00:25:58]     |
[00:25:58] 437 | pub unsafe fn __smusdx(a: int8x4_t, b: int16x2_t) -> i32 {
[00:25:58] help: possible candidate is found in another module, you can import it into scope
[00:25:58]     |
[00:25:58]     |
[00:25:58] 68  | use crate::core_arch::acle::dsp::int16x2_t;
[00:25:58] 
[00:25:58] 
[00:25:58] error[E0412]: cannot find type `int16x2_t` in this scope
[00:25:58]     |
[00:25:58]     |
---
travis_time:end:0289e250:start=1555507538235621285,finish=1555507538242653468,duration=7032183
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:01219dc9
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:22783df4
travis_time:start:22783df4
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:114d3ffe
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 17, 2019
@Centril
Copy link
Contributor

Centril commented Apr 17, 2019

cc @gnzlbg ^---

@gnzlbg gnzlbg mentioned this pull request Apr 17, 2019
Merged
@gnzlbg
Copy link
Contributor

gnzlbg commented Apr 17, 2019 •
edited
Loading

So I've opened rust-lang/stdarch#725 to set the edition of core::arch to 2018 unconditionally, and will hold all contributions to stdsimd until that PR and this PR are merged, because ensuring that the core::arch module remains compatible for both editions for all tier1 and tier2 targets is just too much of a pain.

(EDIT: I've just done a release of core_arch and std_detect so that if somebody hits any temporary issues they can use those from crates.io instead until this PR is merged).

@Centril
Copy link
Contributor

Centril commented Apr 18, 2019

@bors r+ p=10

@bors
Copy link
Contributor

bors commented Apr 18, 2019

📌 Commit e28bce7 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2019
@bors
Copy link
Contributor

bors commented Apr 18, 2019

⌛ Testing commit e28bce7 with merge 5d20ff4...

bors added a commit that referenced this pull request Apr 18, 2019
@bors
Auto merge of #58702 - taiki-e:libcore-2018, r=Centril
5d20ff4 
libcore => 2018

Transitions `libcore` to Rust 2018; cc #58099

r? @Centril
@bors bors mentioned this pull request Apr 18, 2019
Merged
@bors
Copy link
Contributor

bors commented Apr 18, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Centril
Pushing 5d20ff4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 18, 2019
@bors bors merged commit e28bce7 into rust-lang:master Apr 18, 2019
@Centril
Copy link
Contributor

Centril commented Apr 18, 2019

Yay!

@bors bors mentioned this pull request Apr 18, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Apr 18, 2019

I'll prepare a PR for the #[allow(...)] bits :)

This was referenced Apr 18, 2019
Closed
Closed
@Centril Centril mentioned this pull request Apr 18, 2019
Closed
@taiki-e taiki-e deleted the libcore-2018 branch April 18, 2019 21:11
@Nemo157 Nemo157 mentioned this pull request Apr 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees

@Centril Centril

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@taiki-e @gnzlbg @bors @rust-highfive @Centril @mati865 @RalfJung