Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Implement Needle API (RFC 2500) #59591

Closed
wants to merge 18 commits into from
Closed

[WIP] Implement Needle API (RFC 2500) #59591

wants to merge 18 commits into from

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Mar 31, 2019 •
edited
Loading

cc #56345

Insta-stable changes:

  • impl Index<Range***> for OsStr cannot be gated and is insta-stable.

I'll add more comments after the crater run.

@kennytm kennytm added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. needs-fcp This change is insta-stable, so needs a completed FCP to proceed. labels Mar 31, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@kennytm

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@kennytm kennytm force-pushed the needle-api branch 2 times, most recently from 1c7d426 to c8eda73 Compare April 5, 2019 18:17
@rust-highfive

This comment has been minimized.

Sign in to view
@kennytm kennytm force-pushed the needle-api branch 3 times, most recently from daa335e to 56e8108 Compare April 5, 2019 18:30
@rust-highfive

This comment has been minimized.

Sign in to view
@kennytm kennytm force-pushed the needle-api branch 3 times, most recently from 6741b10 to 91d0201 Compare April 5, 2019 18:47
@kennytm

This comment has been minimized.

Sign in to view
@kennytm
Implemented the Needle API (RFC 2500).
175d8e8
@kennytm
Migrate the existing string pattern APIs to use the new Needle API.
a795af0
@kennytm
Generalize the slice methods to use the Needle API.
3be85df 
Known issue: will require additional type annotations.
@kennytm
Implement slicing operators on OsStr and OsString.
58e8735
@kennytm
Delegate Eq/PartialEq/Ord/PartialOrd/Hash of OsStr to their internal …
18a59c0 
…impl.

This is required to make OsStr on Windows behaves as expected.
@kennytm
Implement the Needle API for OsStr.
602da5c
@kennytm
Added str::{find_range, rfind_range, match_ranges, rmatch_ranges}.
f1bedc3
@kennytm
Added the str::*_mut methods using Needle API.
a10c43a
@kennytm
Added needle methods for slices
d118cd0
@kennytm
Added needle methods for OsStr
eba3253
@kennytm
Brings back Wtf8Buf
f9fece2
@kennytm
Fix build and test failure
d38b8e6
@kennytm
Removed all intra-doc-links from the needle docs.
a8bc182 
They are not resolving (perhaps due to re-export) and causing CI failure.
@kennytm
bless some UI changes
f4ad8c4
@kennytm
Convert slice::split and friends back to taking FnMut only.
9dc2d70 
The inference breakage is too strong. Instead, introduced slice::split_match and
friends as the needle-taking methods.
@kennytm
impl Needle<&[T]> for &&[T], &Box<[T]>.
f1f34fa
@rust-highfive

This comment has been minimized.

Sign in to view
@kennytm
Copy link
Member Author

kennytm commented Apr 20, 2019

@bors try

@bors
Copy link
Contributor

bors commented Apr 20, 2019

⌛ Trying commit 6cc67c7 with merge 521aacb...

bors added a commit that referenced this pull request Apr 20, 2019
@bors
Auto merge of #59591 - kennytm:needle-api, r=<try>
521aacb 
[WIP] Implement Needle API (RFC 2500)

cc #56345

----

Insta-stable changes:

* `impl Index<Range***> for OsStr` cannot be gated and is insta-stable.

I'll add more comments after the crater run.
@bors
Copy link
Contributor

bors commented Apr 20, 2019

☀️ Try build successful - checks-travis
Build commit: 521aacb

@jonas-schievink
Copy link
Contributor

Ping from triage @kennytm, the last try build is done, but there are now quite a lot of merge conflicts that need to be solved.

Also there's no assignee for some reason, so:

r? @SimonSapin

@Dylan-DPC-zz
Copy link

ping from triage @kennytm any updates?

@SimonSapin
Copy link
Contributor

Sorry, I don’t have bandwidth for such a large review.

@SimonSapin SimonSapin removed their assignment Jun 24, 2019
@kennytm kennytm closed this Jul 2, 2019
@crlf0710 crlf0710 mentioned this pull request Sep 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-fcp This change is insta-stable, so needs a completed FCP to proceed. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@kennytm @rust-highfive @bors @rust-timer @craterbot @jonas-schievink @Dylan-DPC-zz @SimonSapin