Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add as_slice() to slice::IterMut and vec::Drain #58924

Merged
merged 4 commits into from
Mar 9, 2019
Merged

Add as_slice() to slice::IterMut and vec::Drain #58924

merged 4 commits into from
Mar 9, 2019

Commits on Mar 4, 2019

  1. Add as_slice() to slice::IterMut and vec::Drain 

    In indexmap-rs/indexmap#88, we found that there was no easy way to implement
`Debug` for our `IterMut` and `Drain` iterators. Those are built on
`slice::IterMut` and `vec::Drain`, which implement `Debug` themselves,
but have no other way to access their data. With a new `as_slice()`
method, we can read the data and customize its presentation.
    @cuviper
    cuviper committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    538a096 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2019

  1. Apply suggestions from code review 

    Co-Authored-By: cuviper <cuviper@gmail.com>
    @Centril @cuviper
    Centril and cuviper committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    5384a11 View commit details
    Browse the repository at this point in the history

  2. Clean up the example on slice::IterMut::as_slice()

    @cuviper
    cuviper committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    51e0d1c View commit details
    Browse the repository at this point in the history

  3. Add a tracking issue for new as_slice methods

    @cuviper
    cuviper committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    e478cad View commit details
    Browse the repository at this point in the history