Consistent naming for duration_float methods and additional f32 methods #59102

newpavlov · 2019-03-11T14:56:47Z

duration_float tracking issue: #54361

New list of methods:

as_secs_f64(&self) -> f64
as_secs_f32(&self) -> f32
from_secs_f64(secs: f64) -> Duration
from_secs_f32(secs: f32) -> Duration
mul_f64(self, rhs: f64) -> Duration
mul_f32(self, rhs: f32) -> Duration
div_f64(self, rhs: f64) -> Duration
div_f32(self, rhs: f64) -> Duration
div_duration_f64(self, rhs: Duration) -> f64
div_duration_f32(self, rhs: Duration) -> f32

With num_traits::Float we could've reduced number of methods by factor of two, but unfortunately it's not part of std.

rust-highfive · 2019-03-11T14:56:52Z

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2019-03-11T15:05:12Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:18f49e97:start=1552316415530568828,finish=1552316418193880191,duration=2663311363
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-03-11T16:44:27Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:1a41cc24:start=1552316849853629163,finish=1552316850759161663,duration=905532500
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:19:57] 
[01:19:57] running 120 tests
[01:20:23] .iiiii...i.....i..i...i..i.i...i.ii...i.....i..i....i..........iiii..........i...ii...i.......ii.i.i 100/120
[01:20:27] .i......iii.i.....ii
[01:20:27] 
[01:20:27]  finished in 30.098
[01:20:27] travis_fold:end:test_debuginfo

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-03-11T18:34:00Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0e3a0cba:start=1552323551164601104,finish=1552323553676602783,duration=2512001679
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:18:24] 
[01:18:24] running 120 tests
[01:18:49] .iiiii...i.....i..i...i..i.i...i.ii...i.....i..i....i..........iiii..........i...ii...i.......ii.i.i 100/120
[01:18:53] .i......iii.i.....ii
[01:18:53] 
[01:18:53]  finished in 28.838
[01:18:53] travis_fold:end:test_debuginfo

---
[01:33:31] .................................................................................................... 1900/2293
[01:33:44] .................................................................................................... 2000/2293
[01:33:59] .................................................................................................... 2100/2293
[01:34:17] .................................................................................................... 2200/2293
[01:34:30] i.....................................................................................F......
[01:34:30] 
[01:34:30] ---- time.rs - time::Duration::mul_f32 (line 636) stdout ----
[01:34:30] thread 'time.rs - time::Duration::mul_f32 (line 636)' panicked at 'test executable failed:
[01:34:30] 
[01:34:30] 
[01:34:30] thread 'main' panicked at 'assertion failed: `(left == right)`
[01:34:30]   left: `847799.969120256s`,
[01:34:30]  right: `847800.064s`', time.rs:11:1
[01:34:30] 
[01:34:30] ', src/librustdoc/test.rs:332:17
[01:34:30] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:34:30] 
---
[01:34:30] 
[01:34:30] error: test failed, to rerun pass '--doc'
[01:34:30] 
[01:34:30] 
[01:34:30] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "core" "--" "--quiet"
[01:34:30] 
[01:34:30] 
[01:34:30] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:34:30] Build completed unsuccessfully in 0:27:27
[01:34:30] Build completed unsuccessfully in 0:27:27
[01:34:30] make: *** [check] Error 1
[01:34:30] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:01014330
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Mon Mar 11 18:33:54 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2019-03-12T05:25:03Z

r? @alexcrichton

alexcrichton · 2019-03-12T14:17:13Z

@bors: r+

All the changes look great to me here and I agree this seems like the direction to go in, thanks @newpavlov!

bors · 2019-03-12T14:17:18Z

📌 Commit 78b248d has been approved by alexcrichton

…chton Consistent naming for duration_float methods and additional f32 methods `duration_float` tracking issue: rust-lang#54361 New list of methods: - `as_secs_f64(&self) -> f64` - `as_secs_f32(&self) -> f32` - `from_secs_f64(secs: f64) -> Duration` - `from_secs_f32(secs: f32) -> Duration` - `mul_f64(self, rhs: f64) -> Duration` - `mul_f32(self, rhs: f32) -> Duration` - `div_f64(self, rhs: f64) -> Duration` - `div_f32(self, rhs: f64) -> Duration` - `div_duration_f64(self, rhs: Duration) -> f64` - `div_duration_f32(self, rhs: Duration) -> f32` With [`num_traits::Float`](https://docs.rs/num-traits/0.2.6/num_traits/float/trait.Float.html) we could've reduced number of methods by factor of two, but unfortunately it's not part of `std`.

Rollup of 37 pull requests Successful merges: - #58854 (appveyor: Use VS2017 for all our images) - #58855 (std: Spin for a global malloc lock on wasm32) - #58873 (Fix "Auto-hide item methods documentation" setting) - #58901 (Change `std::fs::copy` to use `copyfile` on MacOS and iOS) - #58933 (Move alloc::prelude::* to alloc::prelude::v1, make alloc a subset of std) - #58938 (core: ensure VaList passes improper_ctypes lint) - #58941 (MIPS: add r6 support) - #58949 (SGX target: Expose thread id function in os module) - #58959 (Add release notes for PR #56243) - #58976 (Default to integrated `rust-lld` linker for UEFI targets) - #59009 (Fix SGX implementations of read/write_vectored.) - #59025 (Fix generic argument lookup for Self) - #59036 (Fix ICE in MIR pretty printing) - #59037 (Avoid some common false positives in intra doc link checking) - #59072 (we can now skip should_panic tests with the libtest harness) - #59079 (add suggestions to invalid macro item error) - #59082 (A few improvements to comments in user-facing crates) - #59102 (Consistent naming for duration_float methods and additional f32 methods) - #59118 (rustc: fix ICE when trait alias has bare Self) - #59139 (Unregress using scalar unions in constants.) - #59146 (Suggest return lifetime when there's only one named lifetime) - #59147 (Make std time tests more robust for platform differences) - #59152 (Stabilize Range*::contains.) - #59156 ([wg-async-await] Add regression test for #55809.) - #59158 (Revert "Don't generate minification variable if minification disabled") - #59169 (Add `-Z allow_features=...` flag) - #59173 (bootstrap: Default to a sensible llvm-suffix.) - #59175 (Don't run test launching `echo` since that doesn't exist on Windows) - #59180 (Use try blocks in rustc_codegen_ssa) - #59185 (No old chestnuts in iter::repeat docs) - #59201 (Remove restriction on isize/usize in repr(simd)) - #59204 (Output diagnostic information for rustdoc) - #59206 (Improved test output) - #59208 (Reduce a Code Repetition Related to Bit Operation) - #59212 (Add x86_64 musl host to the manifest) - #59221 (Option and Result: Add references to documentation of as_ref and as_mut) - #59231 (Stabilize Option::copied)

consistent naming for duration_float methods and additional f32 methods

e25df32

rust-highfive assigned kennytm Mar 11, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 11, 2019

move MAX_NANOS_F64/32 to methods

35c19c5

fix tests

980871a

kennytm added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 11, 2019

fix test

197efb0

rust-highfive assigned alexcrichton and unassigned kennytm Mar 12, 2019

fix typo

78b248d

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2019

newpavlov mentioned this pull request Mar 13, 2019

Tracking issue for duration_float #54361

Closed

pietroalbini mentioned this pull request Mar 13, 2019

Rollup of 18 pull requests #59161

Closed

Centril mentioned this pull request Mar 13, 2019

Rollup of 9 pull requests #59165

Closed

Mark-Simulacrum mentioned this pull request Mar 14, 2019

Rollup of 16 pull requests #59183

Closed

kennytm mentioned this pull request Mar 15, 2019

Rollup of 31 pull requests #59207

Closed

kennytm mentioned this pull request Mar 16, 2019

Rollup of 37 pull requests #59226

Merged

bors merged commit 78b248d into rust-lang:master Mar 16, 2019

newpavlov deleted the duration_float branch March 16, 2019 18:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consistent naming for duration_float methods and additional f32 methods #59102

Consistent naming for duration_float methods and additional f32 methods #59102

newpavlov commented Mar 11, 2019 •

edited

Loading

rust-highfive commented Mar 11, 2019

rust-highfive commented Mar 11, 2019

rust-highfive commented Mar 11, 2019

rust-highfive commented Mar 11, 2019

kennytm commented Mar 12, 2019

alexcrichton commented Mar 12, 2019

bors commented Mar 12, 2019

Consistent naming for duration_float methods and additional f32 methods #59102

Consistent naming for duration_float methods and additional f32 methods #59102

Conversation

newpavlov commented Mar 11, 2019 • edited Loading

rust-highfive commented Mar 11, 2019

rust-highfive commented Mar 11, 2019

rust-highfive commented Mar 11, 2019

rust-highfive commented Mar 11, 2019

kennytm commented Mar 12, 2019

alexcrichton commented Mar 12, 2019

bors commented Mar 12, 2019

newpavlov commented Mar 11, 2019 •

edited

Loading