Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce a Code Repetition Related to Bit Operation #59208

Merged
merged 3 commits into from
Mar 16, 2019
Merged

Reduce a Code Repetition Related to Bit Operation #59208

merged 3 commits into from
Mar 16, 2019

Conversation

kenta7777
Copy link
Contributor

This PR is related to #49937.
Should I do more commits about FIXME(49937) in this PR?

@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 15, 2019
@kenta7777
Copy link
Contributor Author

Could you review this PR? @oli-obk
r? @oli-obk

@oli-obk
Copy link
Contributor

oli-obk commented Mar 15, 2019

Should I do more commits

If you want. But we can also just rollup these PRs. Whatever suits you best

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 15, 2019

📌 Commit 12e3e84 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Mar 15, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 15, 2019

📌 Commit 50af62d has been approved by oli-obk

@kenta7777
Copy link
Contributor Author

I don't know how to refactor this. Prease give me some hints to resolve it.

@oli-obk
Copy link
Contributor

oli-obk commented Mar 15, 2019

Good question. I think those are already pretty ideal. As long as there aren't any other computations like these (in which case we should create new functions that deduplicate the code) we should just keep the code. At best you can rewrite the max computation as let max = min - 1;

@kenta7777
Copy link
Contributor Author

Thank you for answering.
Then, I'll rewrite let max = (1u128 << (bits - 1)) - 1; as let max = min - 1; and remove the comment.

@oli-obk
Copy link
Contributor

oli-obk commented Mar 15, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 15, 2019

📌 Commit a8fa1a1 has been approved by oli-obk

@kenta7777
Copy link
Contributor Author

I think there might be more code should be refactored, but I want to merge these commits because all the codes marked as FIXME(49937) were fixed.

Centril added a commit to Centril/rust that referenced this pull request Mar 16, 2019
@Centril
Rollup merge of rust-lang#59208 - kenta7777:reduce-code-repetition, r…
cc028e2 
…=oli-obk

Reduce a Code Repetition Related to Bit Operation

This PR is related to [rust-lang#49937](rust-lang#49937).
Should I do more commits about [`FIXME(49937)`](https://github.com/rust-lang/rust/search?q=FIXME%2849937%29&unscoped_q=FIXME%2849937%29) in this PR?
@Centril Centril mentioned this pull request Mar 16, 2019
Closed
@kennytm kennytm mentioned this pull request Mar 16, 2019
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Mar 16, 2019
@kennytm
Rollup merge of rust-lang#59208 - kenta7777:reduce-code-repetition, r…
6779b7f 
…=oli-obk

Reduce a Code Repetition Related to Bit Operation

This PR is related to [rust-lang#49937](rust-lang#49937).
Should I do more commits about [`FIXME(49937)`](https://github.com/rust-lang/rust/search?q=FIXME%2849937%29&unscoped_q=FIXME%2849937%29) in this PR?
bors added a commit that referenced this pull request Mar 16, 2019
@bors
Auto merge of #59226 - kennytm:rollup, r=kennytm
2c8bbf5 
Rollup of 37 pull requests

Successful merges:

 - #58854 (appveyor: Use VS2017 for all our images)
 - #58855 (std: Spin for a global malloc lock on wasm32)
 - #58873 (Fix "Auto-hide item methods documentation" setting)
 - #58901 (Change `std::fs::copy` to use `copyfile` on MacOS and iOS)
 - #58933 (Move alloc::prelude::* to alloc::prelude::v1, make alloc a subset of std)
 - #58938 (core: ensure VaList passes improper_ctypes lint)
 - #58941 (MIPS: add r6 support)
 - #58949 (SGX target: Expose thread id function in os module)
 - #58959 (Add release notes for PR #56243)
 - #58976 (Default to integrated `rust-lld` linker for UEFI targets)
 - #59009 (Fix SGX implementations of read/write_vectored.)
 - #59025 (Fix generic argument lookup for Self)
 - #59036 (Fix ICE in MIR pretty printing)
 - #59037 (Avoid some common false positives in intra doc link checking)
 - #59072 (we can now skip should_panic tests with the libtest harness)
 - #59079 (add suggestions to invalid macro item error)
 - #59082 (A few improvements to comments in user-facing crates)
 - #59102 (Consistent naming for duration_float methods and additional f32 methods)
 - #59118 (rustc: fix ICE when trait alias has bare Self)
 - #59139 (Unregress using scalar unions in constants.)
 - #59146 (Suggest return lifetime when there's only one named lifetime)
 - #59147 (Make std time tests more robust for platform differences)
 - #59152 (Stabilize Range*::contains.)
 - #59156 ([wg-async-await] Add regression test for #55809.)
 - #59158 (Revert "Don't generate minification variable if minification disabled")
 - #59169 (Add `-Z allow_features=...` flag)
 - #59173 (bootstrap: Default to a sensible llvm-suffix.)
 - #59175 (Don't run test launching `echo` since that doesn't exist on Windows)
 - #59180 (Use try blocks in rustc_codegen_ssa)
 - #59185 (No old chestnuts in iter::repeat docs)
 - #59201 (Remove restriction on isize/usize in repr(simd))
 - #59204 (Output diagnostic information for rustdoc)
 - #59206 (Improved test output)
 - #59208 (Reduce a Code Repetition Related to Bit Operation)
 - #59212 (Add x86_64 musl host to the manifest)
 - #59221 (Option and Result: Add references to documentation of as_ref and as_mut)
 - #59231 (Stabilize Option::copied)
@bors bors merged commit a8fa1a1 into rust-lang:master Mar 16, 2019
@kenta7777
Copy link
Contributor Author

thanks!

@kenta7777 kenta7777 deleted the reduce-code-repetition branch March 16, 2019 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kenta7777 @rust-highfive @oli-obk @bors @michaelwoerister