Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visit impl Trait for dead_code lint #59129

Merged
merged 1 commit into from Mar 13, 2019
Merged

Visit impl Trait for dead_code lint #59129

merged 1 commit into from Mar 13, 2019

Conversation

sanxiyn
Copy link
Member

@sanxiyn sanxiyn commented Mar 12, 2019

Fix #59085.

@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 12, 2019
@varkor
Copy link
Member

varkor commented Mar 12, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 12, 2019

📌 Commit 2027459 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2019
@sanxiyn sanxiyn mentioned this pull request Mar 12, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 13, 2019
@Centril
Rollup merge of rust-lang#59129 - sanxiyn:visit-impl-trait, r=varkor
b70a98f 
Visit impl Trait for dead_code lint

Fix rust-lang#59085.
@Centril Centril mentioned this pull request Mar 13, 2019
Merged
bors added a commit that referenced this pull request Mar 13, 2019
@bors
Auto merge of #59151 - Centril:rollup, r=Centril
aa97448 
Rollup of 16 pull requests

Successful merges:

 - #58829 (librustc_interface: Update scoped-tls to 1.0)
 - #58876 (Parse lifetimes that start with a number and give specific error)
 - #58908 (Update rand version)
 - #58998 (Fix documentation of from_ne_bytes and from_le_bytes)
 - #59056 (Use lifetime contravariance to elide more lifetimes in core+alloc+std)
 - #59057 (Standardize `Range*` documentation)
 - #59080 (Fix incorrect links in librustc_codegen_llvm documentation)
 - #59083 (Fix #54822 and associated faulty tests)
 - #59093 (Remove precompute_in_scope_traits_hashes)
 - #59101 (Reduces Code Repetitions like `!n >> amt`)
 - #59121 (impl FromIterator for Result: Use assert_eq! instead of assert!)
 - #59124 (Replace assert with assert_eq)
 - #59129 (Visit impl Trait for dead_code lint)
 - #59130 (Note that NonNull does not launder shared references for mutation)
 - #59132 (ignore higher-ranked object bound conditions created by WF)
 - #59138 (Simplify Iterator::{min, max})

Failed merges:

r? @ghost
@bors bors merged commit 2027459 into rust-lang:master Mar 13, 2019
@sanxiyn sanxiyn deleted the visit-impl-trait branch March 13, 2019 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sanxiyn @rust-highfive @varkor @bors @michaelwoerister