Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Implement Needle API (RFC 2500) #59591

Closed
wants to merge 18 commits into from
Closed

[WIP] Implement Needle API (RFC 2500) #59591

wants to merge 18 commits into from

Commits on Apr 19, 2019

  1. Support OMG-WTF-8 in wtf8.rs.

    @kennytm
    kennytm committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    fcd71f6 View commit details
    Browse the repository at this point in the history

  2. Implemented the Needle API (RFC 2500).

    @kennytm
    kennytm committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    175d8e8 View commit details
    Browse the repository at this point in the history

  3. Migrate the existing string pattern APIs to use the new Needle API.

    @kennytm
    kennytm committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    a795af0 View commit details
    Browse the repository at this point in the history

  4. Generalize the slice methods to use the Needle API. 

    Known issue: will require additional type annotations.
    @kennytm
    kennytm committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    3be85df View commit details
    Browse the repository at this point in the history

  5. Implement slicing operators on OsStr and OsString.

    @kennytm
    kennytm committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    58e8735 View commit details
    Browse the repository at this point in the history

  6. Delegate Eq/PartialEq/Ord/PartialOrd/Hash of OsStr to their internal … 

    …impl.

This is required to make OsStr on Windows behaves as expected.
    @kennytm
    kennytm committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    18a59c0 View commit details
    Browse the repository at this point in the history

  7. Implement the Needle API for OsStr.

    @kennytm
    kennytm committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    602da5c View commit details
    Browse the repository at this point in the history

  8. Added str::{find_range, rfind_range, match_ranges, rmatch_ranges}.

    @kennytm
    kennytm committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    f1bedc3 View commit details
    Browse the repository at this point in the history

  9. Added the str::*_mut methods using Needle API.

    @kennytm
    kennytm committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    a10c43a View commit details
    Browse the repository at this point in the history

  10. Added needle methods for slices

    @kennytm
    kennytm committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    d118cd0 View commit details
    Browse the repository at this point in the history

  11. Added needle methods for OsStr

    @kennytm
    kennytm committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    eba3253 View commit details
    Browse the repository at this point in the history

  12. Brings back Wtf8Buf

    @kennytm
    kennytm committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    f9fece2 View commit details
    Browse the repository at this point in the history

  13. Fix build and test failure

    @kennytm
    kennytm committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    d38b8e6 View commit details
    Browse the repository at this point in the history

  14. Removed all intra-doc-links from the needle docs. 

    They are not resolving (perhaps due to re-export) and causing CI failure.
    @kennytm
    kennytm committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    a8bc182 View commit details
    Browse the repository at this point in the history

  15. bless some UI changes

    @kennytm
    kennytm committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    f4ad8c4 View commit details
    Browse the repository at this point in the history

  16. Convert slice::split and friends back to taking FnMut only. 

    The inference breakage is too strong. Instead, introduced slice::split_match and
friends as the needle-taking methods.
    @kennytm
    kennytm committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    9dc2d70 View commit details
    Browse the repository at this point in the history

  17. impl Needle<&[T]> for &&[T], &Box<[T]>.

    @kennytm
    kennytm committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    f1f34fa View commit details
    Browse the repository at this point in the history

  18. Fix 2018 edition fallout.

    @kennytm
    kennytm committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    6cc67c7 View commit details
    Browse the repository at this point in the history