Added an explanation for the E0704 error. #59634

DevQps · 2019-04-02T13:52:20Z

Description

Adds an explanation on the E0704 error. I tried to stick as closely to the message that the compiler generates. It's the first time I am fixing error messages here, so if there is something I did wrong or should improve, please let me know.

closes #55398

rust-highfive · 2019-04-02T13:52:24Z

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

DevQps · 2019-04-02T15:36:58Z

@eddyb I am trying to understand the error that Travis gives me, but I am failing to understand what went wrong. When I search the project for "E0704", the only things come up are:

src\test\ui\pub\pub-restricted.stderr (of which I do not truly understand it's purpose, it seems like a template for error messages?)
src\libsyntax\diagnostic_list.rs (to which I added the error explanation)
src\libsyntax\parse\parser.rs (which seems to reference the error)

Hope you can give me a pointer :)

DevQps · 2019-04-09T13:57:50Z

@eddyb Could you maybe respond to my previous questions?

estebank · 2019-04-18T18:37:52Z

@DevQps tidy is complaining that the same error code appears twice, once in the placeholder list and once with a description. As you have a description, just remove line 443 and it will satisfy tidy. That list is only for error codes that do not have a description, but that we want to statically check for creation somewhere.

You will also need to rebase due to a recently merged PR introducing conflicts.

src/libsyntax/diagnostic_list.rs

estebank · 2019-04-20T21:40:30Z

Need to run ./x.py test src/test/ui --stage 1 --bless

estebank · 2019-04-24T17:26:45Z

r? @estebank

estebank · 2019-04-24T17:32:12Z

@DevQps great work! It seems like the code should work well now. Would you mind squashing your commits? I feel this can be merged then, gated on Travis being happy.

DevQps · 2019-04-24T19:28:22Z

@estebank I squashed them! I just saw that my IDE includes the description of each commit though. Hope that's not too much of a problem! Otherwise I will go try and fix it somehow :)

EDIT: I don't understand what went wrong. I checked it on the playground and there it works: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=a15911ab678f31233b9d06fa62e47095

estebank · 2019-04-24T22:10:20Z

I'm not sure why it fails. @QuietMisdreavus, would you know what in rustdoc's world could cause the error we're seeing here?

QuietMisdreavus · 2019-04-29T17:44:53Z

Rustdoc is probably wrapping that code in a main function, which hides the module. You probably need to add an empty fn main to the sample to prevent that. (Doing that on the playground seems to give the same error, at least.)

src/libsyntax/error_codes.rs

DevQps · 2019-05-01T10:03:13Z

@estebank I squashed them! Bors succeeded last time, so I guess it will be good this way as well. Thanks a lot for all your help. I sometimes miss the small parts here and there :) Glad you're here help me catch them.

estebank · 2019-05-01T15:15:45Z

@bors r+ rollup

bors · 2019-05-01T15:15:46Z

📌 Commit 2be37ad has been approved by estebank

Added an explanation for the E0704 error. # Description Adds an explanation on the E0704 error. I tried to stick as closely to the message that the compiler generates. It's the first time I am fixing error messages here, so if there is something I did wrong or should improve, please let me know. closes rust-lang#55398

@ghost

Rollup of 7 pull requests Successful merges: - #59634 (Added an explanation for the E0704 error.) - #60348 (move some functions from parser.rs to diagostics.rs) - #60385 (Emit metadata files earlier) - #60428 (Refactor `eval_body_using_ecx` so that it doesn't need to query for MIR) - #60437 (Ensure that drop order of `async fn` matches `fn` and that users cannot refer to generated arguments.) - #60439 (doc: Warn about possible zombie apocalypse) - #60452 (Remove Context and ContextKind) Failed merges: r? @ghost

rust-highfive assigned eddyb Apr 2, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 2, 2019