Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Context and ContextKind #60452

Merged
merged 1 commit into from
May 2, 2019
Merged

Remove Context and ContextKind #60452

merged 1 commit into from
May 2, 2019

Conversation

JohnTitor
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 1, 2019
matthewjasper
matthewjasper reviewed May 1, 2019
View reviewed changes
Copy link
Contributor

@matthewjasper matthewjasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few places that have been changed that shouldn't be. Otherwise this looks good.

src/librustc_mir/borrow_check/mod.rs Outdated Show resolved Hide resolved
src/librustc_mir/borrow_check/mod.rs Outdated Show resolved Hide resolved
src/librustc_mir/borrow_check/mod.rs Outdated Show resolved Hide resolved
@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 1, 2019

📌 Commit 99ebb7a has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2019
Centril added a commit to Centril/rust that referenced this pull request May 1, 2019
@Centril
Rollup merge of rust-lang#60452 - JohnTitor:remove-context, r=matthew…
4ff1234 
…jasper

Remove Context and ContextKind

Fixes rust-lang#60421

r? @matthewjasper
@Centril Centril mentioned this pull request May 1, 2019
Merged
bors added a commit that referenced this pull request May 2, 2019
@bors
Auto merge of #60460 - Centril:rollup-gz5bc8i, r=Centril
767f594 
Rollup of 7 pull requests

Successful merges:

 - #59634 (Added an explanation for the E0704 error.)
 - #60348 (move some functions from parser.rs to diagostics.rs)
 - #60385 (Emit metadata files earlier)
 - #60428 (Refactor `eval_body_using_ecx` so that it doesn't need to query for MIR)
 - #60437 (Ensure that drop order of `async fn` matches `fn` and that users cannot refer to generated arguments.)
 - #60439 (doc: Warn about possible zombie apocalypse)
 - #60452 (Remove Context and ContextKind)

Failed merges:

r? @ghost
@bors bors merged commit 99ebb7a into rust-lang:master May 2, 2019
@JohnTitor JohnTitor deleted the remove-context branch May 2, 2019 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewjasper matthewjasper matthewjasper left review comments

Assignees

@matthewjasper matthewjasper

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove rustc_mir::borrow_check::{Context, ContextKind}
4 participants
@JohnTitor @matthewjasper @bors @rust-highfive