Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: Remove dylib crate type from most rustc crates #59800

Merged
merged 4 commits into from
Jul 7, 2019
Merged

rustc: Remove dylib crate type from most rustc crates #59800

merged 4 commits into from
Jul 7, 2019

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Apr 8, 2019

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 8, 2019
@alexcrichton
Copy link
Member

r=me on this, sorry I was never able to get to the bottom of the issues!

@rust-highfive

This comment has been minimized.

Sign in to view
@michaelwoerister
Copy link
Member

Thanks for looking into this, @Zoxc!
r? @alexcrichton

@rust-highfive

This comment has been minimized.

Sign in to view
@Zoxc Zoxc force-pushed the less-dylibs branch 2 times, most recently from 1e51c9b to 581705d Compare April 10, 2019 14:53
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@Zoxc Zoxc force-pushed the less-dylibs branch 2 times, most recently from e38953e to 535f9e7 Compare April 11, 2019 09:31
@Zoxc
Copy link
Contributor Author

Zoxc commented Apr 11, 2019

Blocked on #59752 landing in beta.

@Zoxc Zoxc added the S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. label Apr 11, 2019
@Zoxc Zoxc changed the title [WIP] rustc: Remove dylib crate type from most rustc crates rustc: Remove dylib crate type from most rustc crates Apr 11, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@Dylan-DPC-zz Dylan-DPC-zz removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@Zoxc
Copy link
Contributor Author

Zoxc commented Jun 15, 2019

This is now unblocked.

@Zoxc Zoxc added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Jun 15, 2019
alexcrichton and others added 4 commits July 7, 2019 03:23
@alexcrichton @Zoxc
rustc: Remove dylib crate type from most rustc crates
345ba50 
Now that procedural macros no longer link transitively to libsyntax,
this shouldn't be needed any more! This commit is an experiment in
removing all dynamic libraries from rustc except for librustc_driver
itself. Let's see how far we can get with that!
@Zoxc
Remove some dummy dependencies
60c49bc
@Zoxc
Update Cargo.lock
2caf5d9
@Zoxc
Link compiler plugins to rustc_driver
7198687
@Zoxc
Copy link
Contributor Author

Zoxc commented Jul 7, 2019

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Jul 7, 2019

📌 Commit 7198687 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 7, 2019
@bors
Copy link
Contributor

bors commented Jul 7, 2019

⌛ Testing commit 7198687 with merge dd2e804...

bors added a commit that referenced this pull request Jul 7, 2019
@bors
Auto merge of #59800 - Zoxc:less-dylibs, r=alexcrichton
dd2e804 
rustc: Remove `dylib` crate type from most rustc crates

Revival of #56987

cc @alexcrichton
r? @michaelwoerister
@bors
Copy link
Contributor

bors commented Jul 7, 2019

☀️ Test successful - checks-azure, checks-travis, status-appveyor
Approved by: alexcrichton
Pushing dd2e804 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 7, 2019
@bors bors merged commit 7198687 into rust-lang:master Jul 7, 2019
@bors bors mentioned this pull request Jul 7, 2019
Merged
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #59800!

Tested on commit dd2e804.
Direct link to PR: #59800

💔 rls on linux: test-pass → test-fail (cc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jul 7, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#59800!
c9ef370 
Tested on commit rust-lang/rust@dd2e804.
Direct link to PR: <rust-lang/rust#59800>

💔 rls on linux: test-pass → test-fail (cc @Xanewok, @rust-lang/infra).
@Zoxc Zoxc deleted the less-dylibs branch July 7, 2019 15:36
@mati865
Copy link
Contributor

mati865 commented Jul 7, 2019

Final perf results: https://perf.rust-lang.org/compare.html?start=dbeed58adee2ef046b46b252980f86672f9bfc4c&end=dd2e8040a35883574ae0c4cc7a4e887ecb66469c&stat=instructions%3Au

@tesuji tesuji mentioned this pull request Jul 8, 2019
Closed
@SimonSapin SimonSapin mentioned this pull request Jul 16, 2019
Closed
@SimonSapin SimonSapin mentioned this pull request Jul 16, 2019
Merged
SimonSapin added a commit to SimonSapin/rust that referenced this pull request Aug 19, 2019
@SimonSapin
Deprecate using rustc_plugin without the rustc_driver dylib.
d0bbc60 
CC rust-lang#59800
rust-lang@7198687

Fix rust-lang#62717
bors added a commit that referenced this pull request Aug 20, 2019
@bors
Auto merge of #62727 - SimonSapin:plugins-tls-dylib, r=petrochenkov
d8d99ba 
Deprecate using rustc_plugin without the rustc_driver dylib.

CC #59800, 7198687

Fix #62717
@est31 est31 mentioned this pull request Oct 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

@bjorn3 bjorn3 bjorn3 left review comments

Assignees

@alexcrichton alexcrichton

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet