Fix broken links on std::boxed doc page #59814
Conversation
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit d6fd57a has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 15, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
…sdreavus Fix broken links on std::boxed doc page r? @QuietMisdreavus
src/liballoc/lib.rs
Outdated
| @@ -65,7 +65,7 @@ | |||
| #![allow(explicit_outlives_requirements)] | |||
|
|
|||
| #![warn(deprecated_in_future)] | |||
| #![warn(intra_doc_link_resolution_failure)] | |||
| #![deny(intra_doc_link_resolution_failure)] | |||
There was a problem hiding this comment.
We compile with -D warnings, why does this even make a difference?
I remember trying this locally, and #![warn] things turned into errors as expected.
There was a problem hiding this comment.
We don't yet pass -D warnings to rustdoc when building the docs unfortunately.
There was a problem hiding this comment.
Ah I see. When/if you change this next time, please add a comment explaining that. :)
ollie27
force-pushed
the
dead_boxed_links
branch
from
d6fd57a
to
ae2a68b
Compare
|
Looks like I was premature with changing |
|
@bors r=QuietMisdreavus |
|
📌 Commit ae2a68b has been approved by |
…sdreavus Fix broken links on std::boxed doc page r? @QuietMisdreavus
Rollup of 15 pull requests Successful merges: - #59680 (Document the -Z flag to the rustc book) - #59711 (Add back the substring test) - #59806 (compiletest: Improve no_prefer_dynamic docs) - #59809 (Make trait_methods_not_found use a lock) - #59811 (Kill dead code dominator code.) - #59814 (Fix broken links on std::boxed doc page) - #59821 (improve unknown enum variant errors) - #59831 (Remove strange formatting in `Ordering` docs.) - #59836 (std::ops::Div examples: correct nominator to numerator) - #59857 (SGX target: fix cfg(test) build) - #59876 (Update TRPL to use mdbook 0.2) - #59880 (Remove note about transmute for float bitpatterns.) - #59889 (Update diagnostics.rs) - #59891 (Fix the link to sort_by_cached_key) - #59894 (save-analysis: Pull associated type definition using `qpath_def`) Failed merges: r? @ghost
r? @QuietMisdreavus