Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the link to sort_by_cached_key #59891

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Fix the link to sort_by_cached_key #59891

merged 1 commit into from
Apr 12, 2019

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Apr 11, 2019

It's a primitive slice method, not a standalone function.

@cuviper
Fix the link to sort_by_cached_key
90d9727 
It's a primitive slice method, not a standalone function.
@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 11, 2019
@jonas-schievink
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 11, 2019

📌 Commit 90d9727 has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2019
@jonas-schievink jonas-schievink added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Apr 11, 2019
@cuviper
Copy link
Member Author

cuviper commented Apr 12, 2019

Oops, I just realized that I made this branch on the rust-lang repo (through the GitHub editor). Should I close and redo this PR using my own fork, or just let it be?

@jonas-schievink
Copy link
Contributor

@cuviper should be fine, people do that from time to time

@jonas-schievink
Copy link
Contributor

Also marking this for backport discussion. If there ever is a 1.34.1, would be nice to get this in as well.

@jonas-schievink jonas-schievink added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Apr 12, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 12, 2019
@Centril
Rollup merge of rust-lang#59891 - rust-lang:sort_by_cached_key, r=jon…
dddcd92 
…as-schievink

Fix the link to sort_by_cached_key

It's a primitive slice method, not a standalone function.
@Centril Centril mentioned this pull request Apr 12, 2019
Merged
bors added a commit that referenced this pull request Apr 12, 2019
@bors
Auto merge of #59910 - Centril:rollup-yjv7b06, r=Centril
5b96425 
Rollup of 15 pull requests

Successful merges:

 - #59680 (Document the -Z flag to the rustc book)
 - #59711 (Add back the substring test)
 - #59806 (compiletest: Improve no_prefer_dynamic docs)
 - #59809 (Make trait_methods_not_found use a lock)
 - #59811 (Kill dead code dominator code.)
 - #59814 (Fix broken links on std::boxed doc page)
 - #59821 (improve unknown enum variant errors)
 - #59831 (Remove strange formatting in `Ordering` docs.)
 - #59836 (std::ops::Div examples: correct nominator to numerator)
 - #59857 (SGX target: fix cfg(test) build)
 - #59876 (Update TRPL to use mdbook 0.2)
 - #59880 (Remove note about transmute for float bitpatterns.)
 - #59889 (Update diagnostics.rs)
 - #59891 (Fix the link to sort_by_cached_key)
 - #59894 (save-analysis: Pull associated type definition using `qpath_def`)

Failed merges:

r? @ghost
@bors bors merged commit 90d9727 into master Apr 12, 2019
@pietroalbini pietroalbini deleted the sort_by_cached_key branch April 12, 2019 18:46
@pietroalbini
Copy link
Member

@rustbot modify labels: beta-accepted stable-accepted

@rustbot rustbot added beta-accepted Accepted for backporting to the compiler in the beta channel. stable-accepted Accepted for backporting to the compiler in the stable channel. labels Apr 12, 2019
@jonas-schievink jonas-schievink mentioned this pull request Apr 23, 2019
Merged
@pietroalbini pietroalbini added stable-accepted Accepted for backporting to the compiler in the stable channel. and removed stable-accepted Accepted for backporting to the compiler in the stable channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Apr 23, 2019
bors added a commit that referenced this pull request Apr 24, 2019
@bors
Auto merge of #60198 - pietroalbini:stable-next, r=Mark-Simulacrum
3ea00c5 
[stable] 1.34.1 point release

The release date is April 25th.

Included in this point release:

* #59891: Fix the link to sort_by_cached_key
* #59989: Fix links to Atomic* in RELEASES.md
* rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747
* rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow...
* rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives
bors added a commit that referenced this pull request Apr 24, 2019
@bors
Auto merge of #60198 - pietroalbini:stable-next, r=Mark-Simulacrum
89a3797 
[stable] 1.34.1 point release

The release date is April 25th.

Included in this point release:

* #59891: Fix the link to sort_by_cached_key
* #59989: Fix links to Atomic* in RELEASES.md
* rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747
* rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow...
* rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives
bors added a commit that referenced this pull request Apr 24, 2019
@bors
Auto merge of #60198 - pietroalbini:stable-next, r=Mark-Simulacrum
fc50f32 
[stable] 1.34.1 point release

The release date is April 25th.

Included in this point release:

* #59891: Fix the link to sort_by_cached_key
* #59989: Fix links to Atomic* in RELEASES.md
* rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747
* rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow...
* rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives
@pietroalbini pietroalbini mentioned this pull request Apr 26, 2019
Merged
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 26, 2019
bors added a commit that referenced this pull request Apr 27, 2019
@bors
Auto merge of #60311 - pietroalbini:beta-rollup, r=pietroalbini
c13114d 
[beta] Rollup backports

Cherry-picked:

* #59886:  musl: do not compress debug section
* #59891:  Fix the link to sort_by_cached_key
* #59911: Revert "compile crates under test w/ -Zemit-stack-sizes"
* #59978: rustdoc: Remove default keyword from re-exported trait methods
* #59989: Fix links to Atomic* in RELEASES.md
* #60186: Temporarily accept [i|u][32|size] suffixes on a tuple index and warn
* #60309: Add 1.34.1 release notes

Rolled up:

* #60273: [beta] bootstrap; remove redundant imports.

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. stable-accepted Accepted for backporting to the compiler in the stable channel. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cuviper @rust-highfive @jonas-schievink @bors @pietroalbini @alexcrichton @rustbot