Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize the type_name intrinsic in core::any #60066

Merged
merged 1 commit into from
Jul 26, 2019
Merged

Stabilize the type_name intrinsic in core::any #60066

merged 1 commit into from
Jul 26, 2019

Conversation

sfackler
Copy link
Member

@sfackler sfackler commented Apr 18, 2019 •
edited by Centril
Loading

Stabilize type_name in core::any.

Closes rust-lang/rfcs#1428

FCP completed over there.

RELEASES.md: Prefer T-libs for categorization.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 18, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@Centril Centril added relnotes Marks issues that should be documented in the release notes of the next release. S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. T-lang Relevant to the language team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2019
@Centril

This comment has been minimized.

Sign in to view
@alexcrichton

This comment has been minimized.

Sign in to view
@sfackler

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
oli-obk
oli-obk previously requested changes Apr 20, 2019
View reviewed changes
src/libcore/any.rs Outdated Show resolved Hide resolved
src/libcore/any.rs Show resolved Hide resolved
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@Centril

This comment has been minimized.

Sign in to view
@pnkfelix pnkfelix mentioned this pull request Jun 20, 2019
Closed
@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Jul 3, 2019
@azriel91 azriel91 mentioned this pull request Jul 10, 2019
Closed
@Centril Centril added this to the 1.38 milestone Jul 21, 2019
@sfackler sfackler mentioned this pull request Jul 24, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Jul 25, 2019

To reduce Alex's review backlog... :)

r? @Centril

Centril
Centril reviewed Jul 25, 2019
View reviewed changes
src/libcore/any.rs Outdated Show resolved Hide resolved
src/libcore/any.rs Outdated Show resolved Hide resolved
src/libcore/any.rs Outdated Show resolved Hide resolved
Centril
Centril reviewed Jul 25, 2019
View reviewed changes
src/libcore/any.rs Outdated Show resolved Hide resolved
@sfackler
Copy link
Member Author

Rebased!

Centril
Centril approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me rollup when green

@Mark-Simulacrum
Copy link
Member

@bors r=Centril rollup

@bors
Copy link
Contributor

bors commented Jul 25, 2019

📌 Commit 91fa898 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 25, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 25, 2019
@Centril
Rollup merge of rust-lang#60066 - sfackler:type-name, r=Centril
3b19dc9 
Stabilize the type_name intrinsic in core::any

Stabilize `type_name` in `core::any`.

Closes rust-lang/rfcs#1428

FCP completed over there.

`RELEASES.md`: Prefer T-libs for categorization.
@Centril Centril mentioned this pull request Jul 25, 2019
Merged
bors added a commit that referenced this pull request Jul 25, 2019
@bors
Auto merge of #62990 - Centril:rollup-k9n0hvs, r=Centril
1863067 
Rollup of 15 pull requests

Successful merges:

 - #60066 (Stabilize the type_name intrinsic in core::any)
 - #60938 (rustdoc: make #[doc(include)] relative to the containing file)
 - #61884 (Stablize Euclidean Modulo (feature euclidean_division))
 - #61890 (Fix some sanity checks)
 - #62528 (Add joining slices of slices with a slice separator, not just a single item)
 - #62707 (Add tests for overlapping explicitly dropped locals in generators)
 - #62735 (Turn `#[global_allocator]` into a regular attribute macro)
 - #62822 (Improve some pointer-related documentation)
 - #62887 (Make the parser TokenStream more resilient after mismatched delimiter recovery)
 - #62921 (Add method disambiguation help for trait implementation)
 - #62930 (Add test for #51559)
 - #62942 (Use match ergonomics in Condvar documentation)
 - #62977 (Fix inconsistent highlight blocks.)
 - #62978 (Remove `cfg(bootstrap)` code for array implementations)
 - #62981 (Add note suggesting to borrow a String argument to find)

Failed merges:

 - #62964 (clarify and unify some type test names)

r? @ghost
@bors bors merged commit 91fa898 into rust-lang:master Jul 26, 2019
@Aaron1011
Copy link
Member

Could this be a const fn?

@sfackler sfackler deleted the type-name branch July 27, 2019 17:53
@SimonSapin
Copy link
Contributor

Probably? But since this PR is merged, please open a separate issue (or PR) for that.

@Centril
Copy link
Contributor

Centril commented Jul 28, 2019

I think it is way premature to make type_name a const fn as that would cause problems for ensuring referential transparency when combined with &mut T.

@SimonSapin
Copy link
Contributor

I’m not quite sure what that means, but it’s still better discussed in its own thread than in the comments of a merged PR.

@oli-obk
Copy link
Contributor

oli-obk commented Jul 28, 2019

I opened a tracking issue #63084 so we have a discussion point. Not saying we ever want to stabilize this.

@Centril Centril mentioned this pull request Sep 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

@Centril Centril Centril approved these changes

Assignees

@Centril Centril

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-lang Relevant to the language team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.38
Development

Successfully merging this pull request may close these issues.

Expose the type_name intrinsic
9 participants
@sfackler @rust-highfive @Centril @alexcrichton @bors @Mark-Simulacrum @Aaron1011 @SimonSapin @oli-obk