refactor uses of freevars to use the upvar list #60227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
csmoe
force-pushed
the
upvar
branch
3 times, most recently
from
52173d5
to
4d33df4
Compare
nikomatsakis
approved these changes
Apr 30, 2019
| .upvar_list[&def_id] | ||
| .iter() | ||
| .zip(substs.upvar_tys(def_id, cx.tcx)) | ||
| .enumerate() |
There was a problem hiding this comment.
this looks about right =)
| let upvar_capture = cx.tables().upvar_capture(upvar_id); | ||
| let temp_lifetime = cx.region_scope_tree.temporary_scope(closure_expr.hir_id.local_id); | ||
| let var_ty = cx.tables().node_type(var_hir_id); | ||
| let var_ty = cx.tables().node_type(upvar_id.var_path.hir_id); |
There was a problem hiding this comment.
I wonder if it'd be better to pass the var_ty in as a parameter -- but this seems ok too
|
☔ The latest upstream changes (presumably #60462) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #61276) made this pull request unmergeable. Please resolve the merge conflicts. |
Mark-Simulacrum
added
S-inactive
and removed
S-waiting-on-review
|
I'm going to close this PR -- @csmoe let's discuss later restarting this effort :) |
|
@rustbot modify labels to -S-inactive +S-inactive-closed |
rustbot
added
S-inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #60205