Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Disable big-endian simd in swap_nonoverlapping_bytes" #60588

Merged
merged 1 commit into from
May 10, 2019
Merged

Revert "Disable big-endian simd in swap_nonoverlapping_bytes" #60588

merged 1 commit into from
May 10, 2019

Commits on May 6, 2019

  1. Revert "Disable big-endian simd in swap_nonoverlapping_bytes" 

    This reverts commit 77bd4dc.

Issue rust-lang#42778 was formerly easy to reproduce on two big-endian targets,
`powerpc64` and `s390x`, so we disabled SIMD on this function for all
big-endian targets as a workaround.

I have re-tested this code on `powerpc64` and `s390x`, each with the
bundled LLVM 8 and with external LLVM 7 and LLVM 6, and the problems no
longer appear. So it seems safe to remove this workaround, although I'm
still a little uncomfortable that we never found a root-cause...
    @cuviper
    cuviper committed May 6, 2019
    Configuration menu
    Copy the full SHA
    9a0a87a View commit details
    Browse the repository at this point in the history