Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare DefIndex with the newtype_index macro #60934

Merged
merged 1 commit into from May 19, 2019
Merged

Declare DefIndex with the newtype_index macro #60934

merged 1 commit into from May 19, 2019

Conversation

fabric-and-ink
Copy link
Contributor

See #60666

@Centril
Copy link
Contributor

Centril commented May 18, 2019

r? @petrochenkov

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 18, 2019

📌 Commit b18de52 has been approved by petrochenkov

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 18, 2019
Centril added a commit to Centril/rust that referenced this pull request May 19, 2019
@Centril
Rollup merge of rust-lang#60934 - fabric-and-ink:defindex_with_newtyp…
7cbca59 
…e_macro, r=petrochenkov

Declare DefIndex with the newtype_index macro

See rust-lang#60666
@Centril Centril mentioned this pull request May 19, 2019
Merged
bors added a commit that referenced this pull request May 19, 2019
@bors
Auto merge of #60949 - Centril:rollup-f918e1v, r=Centril
26ab324 
Rollup of 8 pull requests

Successful merges:

 - #60370 (Mark core::alloc::Layout::from_size_align_unchecked const)
 - #60678 (Stabilize vecdeque_rotate)
 - #60924 (Explain that ? converts the error type using From)
 - #60931 (Use iter() for iterating arrays by slice)
 - #60934 (Declare DefIndex with the newtype_index macro)
 - #60943 (fix copy-paste typo in docs for ptr::read_volatile)
 - #60945 (Simplify BufRead::fill_buf doc example using NLL)
 - #60947 (Fix typos in docs of GlobalAlloc)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented May 19, 2019

☔ The latest upstream changes (presumably #60949) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 19, 2019
@bors bors merged commit b18de52 into rust-lang:master May 19, 2019
@fabric-and-ink fabric-and-ink deleted the defindex_with_newtype_macro branch May 19, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fabric-and-ink @Centril @petrochenkov @bors @zackmdavis