Make eval_place_to_op iterate instead of recurse #61104

spastorino · 2019-05-23T23:29:45Z

rust-highfive · 2019-05-23T23:49:39Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:2b113177:start=1558654245412215864,finish=1558654246202213229,duration=789997365
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:15:39]    Compiling rustc_typeck v0.0.0 (/checkout/src/librustc_typeck)
[00:15:52] error[E0282]: type annotations needed
[00:15:52]    --> <::rustc::mir::interpret::err macros>:2:1
[00:15:52]     |
[00:15:52] 1   | / ( $ ( $ tt : tt ) * ) => {
[00:15:52] 2   | | Err ( $ crate :: mir :: interpret :: InterpError :: $ ( $ tt ) * . into (  ) )
[00:15:52]     | | ^^^
[00:15:52]     | | cannot infer type for `E`
[00:15:52] 3   | | } ;
[00:15:52]     | |___- in this expansion of `err!`
[00:15:52]     | 
[00:15:52]     | 
[00:15:52]    ::: src/librustc_mir/interpret/operand.rs:474:63
[00:15:52]     |
[00:15:52] 474 |                   PlaceBase::Local(mir::RETURN_PLACE) => return err!(ReadFromReturnPointer),
[00:15:52] 
[00:15:55] error: aborting due to previous error
[00:15:55] 
[00:15:55] For more information about this error, try `rustc --explain E0282`.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

oli-obk · 2019-05-24T16:09:20Z

@bors r+ rollup

bors · 2019-05-24T16:09:22Z

📌 Commit 3dccf83 has been approved by oli-obk

@oli-obk

…, r=oli-obk Make eval_place_to_op iterate instead of recurse r? @oli-obk

@oli-obk

…, r=oli-obk Make eval_place_to_op iterate instead of recurse r? @oli-obk

@ghost

Rollup of 13 pull requests Successful merges: - #61077 (Don't arena-allocate static symbols.) - #61094 (Make find_local iterate instead of recurse) - #61095 (Update cargo) - #61096 (tidy: don't short-circuit on license error) - #61103 (Make find iterate instead of recurse) - #61104 (Make eval_place_to_op iterate instead of recurse) - #61107 (Fix a couple docs typos) - #61110 (Revert edition-guide toolstate override) - #61111 (Fixed type-alias-bounds lint doc) - #61113 (Deprecate `FnBox`. `Box<dyn FnOnce()>` can be called directly, since 1.35) - #61116 (Remove the incorrect warning from README.md) - #61118 (Dont ICE on an attempt to use GAT without feature gate) - #61125 (Updated my mailmap entry) Failed merges: r? @ghost

rust-highfive · 2019-05-24T17:49:57Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:1d5dae18:start=1558715726227385302,finish=1558715816043126635,duration=89815741333
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[01:10:54] .................................................................................................... 2700/5578
[01:10:58] .................................................................................................... 2800/5578
[01:11:02] .................................................................................................... 2900/5578
[01:11:06] .................................................................................................... 3000/5578
[01:11:10] .....................F.............................................................................. 3100/5578
[01:11:17] .................................................................................................... 3300/5578
[01:11:20] ...........i........................................................................................ 3400/5578
[01:11:24] .....................................................................................ii...i..ii..... 3500/5578
[01:11:28] .................................................................................................... 3600/5578
---
[01:12:46] failures:
[01:12:46] 
[01:12:46] ---- [ui] ui/issues/issue-6991.rs stdout ----
[01:12:46] 
[01:12:46] error: test compilation failed although it shouldn't!
[01:12:46] status: exit code: 101
[01:12:46] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-6991.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-6991" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-6991/auxiliary" "-A" "unused"
[01:12:46] ------------------------------------------
[01:12:46] 
[01:12:46] ------------------------------------------
[01:12:46] stderr:
[01:12:46] stderr:
[01:12:46] ------------------------------------------
[01:12:46] error: internal compiler error: src/librustc_mir/interpret/place.rs:604: eval_place_to_mplace called on (*(x: &usize))
[01:12:46] thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:637:9
[01:12:46] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:12:46] error: aborting due to previous error
[01:12:46] 
[01:12:46] 
[01:12:46] 
[01:12:46] note: the compiler unexpectedly panicked. this is a bug.
[01:12:46] 
[01:12:46] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:12:46] 
[01:12:46] note: rustc 1.36.0-dev running on x86_64-unknown-linux-gnu
[01:12:46] 
[01:12:46] note: compiler flags: -Z threads=1 -Z ui-testing -Z unstable-options -C prefer-dynamic -C rpath -C debuginfo=0
[01:12:46] 
[01:12:46] ------------------------------------------
[01:12:46] 
[01:12:46] 
---
[01:12:46] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:521:22
[01:12:46] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:12:46] 
[01:12:46] 
[01:12:46] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:12:46] 
[01:12:46] 
[01:12:46] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:12:46] Build completed unsuccessfully in 0:04:48
[01:12:46] Build completed unsuccessfully in 0:04:48
[01:12:46] make: *** [check] Error 1
[01:12:46] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1c90cfc8
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri May 24 17:49:52 UTC 2019
---
travis_time:end:013f5c72:start=1558720193657793014,finish=1558720193665143156,duration=7350142
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:2b19c078
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:02c53682
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

oli-obk · 2019-05-24T17:54:50Z

@bors r-

rust-highfive · 2019-05-24T20:35:50Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:181305f0:start=1558725773589662470,finish=1558725774342713073,duration=753050603
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
    99% |████████████████████████████████| 542kB 54.6MB/s eta 0:00:01
    100% |████████████████████████████████| 552kB 21.1MB/s 
Requirement already satisfied: PyYAML<=3.13,>=3.10 in /usr/lib/python2.7/dist-packages (from awscli) (3.11)
Collecting botocore==1.12.156 (from awscli)
  Downloading https://files.pythonhosted.org/packages/f5/aa/79fc47ccc3c7d0f36aafb9d85091d7d8a8f10d8ad24ccf3a89cf126b9f4e/botocore-1.12.156-py2.py3-none-any.whl (5.4MB)
    0% |▏                               | 20kB 22.7MB/s eta 0:00:01
    0% |▏                               | 30kB 28.1MB/s eta 0:00:01
    0% |▎                               | 40kB 31.2MB/s eta 0:00:01
    0% |▎                               | 51kB 34.1MB/s eta 0:00:01
---
[01:10:49] .................................................................................................... 2700/5578
[01:10:53] .................................................................................................... 2800/5578
[01:10:57] .................................................................................................... 2900/5578
[01:11:01] .................................................................................................... 3000/5578
[01:11:04] ......................F............................................................................. 3100/5578
[01:11:12] .................................................................................................... 3300/5578
[01:11:15] ...........i........................................................................................ 3400/5578
[01:11:19] .....................................................................................ii...i..ii..... 3500/5578
[01:11:22] .................................................................................................... 3600/5578
---
[01:12:39] failures:
[01:12:39] 
[01:12:39] ---- [ui] ui/issues/issue-6991.rs stdout ----
[01:12:39] 
[01:12:39] error: test compilation failed although it shouldn't!
[01:12:39] status: exit code: 101
[01:12:39] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-6991.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-6991" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-6991/auxiliary" "-A" "unused"
[01:12:39] ------------------------------------------
[01:12:39] 
[01:12:39] ------------------------------------------
[01:12:39] stderr:
[01:12:39] stderr:
[01:12:39] ------------------------------------------
[01:12:39] error: internal compiler error: src/librustc_mir/interpret/place.rs:604: eval_place_to_mplace called on (*(x: &usize))
[01:12:39] thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:637:9
[01:12:39] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:12:39] error: aborting due to previous error
[01:12:39] 
[01:12:39] 
[01:12:39] 
[01:12:39] note: the compiler unexpectedly panicked. this is a bug.
[01:12:39] 
[01:12:39] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:12:39] 
[01:12:39] note: rustc 1.36.0-dev running on x86_64-unknown-linux-gnu
[01:12:39] 
[01:12:39] note: compiler flags: -Z threads=1 -Z ui-testing -Z unstable-options -C prefer-dynamic -C rpath -C debuginfo=0
[01:12:39] 
[01:12:39] ------------------------------------------
[01:12:39] 
[01:12:39] 
---
[01:12:39] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:521:22
[01:12:39] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:12:39] 
[01:12:39] 
[01:12:39] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:12:39] 
[01:12:39] 
[01:12:39] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:12:39] Build completed unsuccessfully in 0:04:41
[01:12:39] Build completed unsuccessfully in 0:04:41
[01:12:39] make: *** [check] Error 1
[01:12:39] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1d37ad37
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri May 24 20:35:44 UTC 2019
---
travis_time:end:0cd448d6:start=1558730146249856522,finish=1558730146254500936,duration=4644414
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0c51d749
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0c884f22
travis_time:start:0c884f22
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:000db380
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

src/librustc_mir/interpret/place.rs

rust-highfive · 2019-05-24T21:12:40Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:106bdfd0:start=1558731282935856944,finish=1558731283705403293,duration=769546349
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
    99% |████████████████████████████████| 542kB 76.0MB/s eta 0:00:01
    100% |████████████████████████████████| 552kB 23.0MB/s 
Requirement already satisfied: PyYAML<=3.13,>=3.10 in /usr/lib/python2.7/dist-packages (from awscli) (3.11)
Collecting botocore==1.12.156 (from awscli)
  Downloading https://files.pythonhosted.org/packages/f5/aa/79fc47ccc3c7d0f36aafb9d85091d7d8a8f10d8ad24ccf3a89cf126b9f4e/botocore-1.12.156-py2.py3-none-any.whl (5.4MB)
    0% |▏                               | 20kB 26.0MB/s eta 0:00:01
    0% |▏                               | 30kB 28.2MB/s eta 0:00:01
    0% |▎                               | 40kB 31.5MB/s eta 0:00:01
    0% |▎                               | 51kB 34.2MB/s eta 0:00:01
---

[00:05:05] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:05:05] tidy error: /checkout/src/librustc_mir/interpret/place.rs:604: line longer than 100 chars
[00:05:10] some tidy checks failed
[00:05:10] 
[00:05:10] 
[00:05:10] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:05:10] 
[00:05:10] 
[00:05:10] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:05:10] Build completed unsuccessfully in 0:01:17
[00:05:10] Build completed unsuccessfully in 0:01:17
[00:05:10] Makefile:67: recipe for target 'tidy' failed
[00:05:10] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:2155b69a
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri May 24 21:00:04 UTC 2019
---
travis_time:end:0061dfa0:start=1558731605122301064,finish=1558731605126848312,duration=4547248
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0c2bc148
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:09f52671
travis_time:start:09f52671
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:18ea1db5
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

src/librustc_mir/interpret/place.rs

oli-obk · 2019-05-24T22:05:37Z

@bors r+

bors · 2019-05-24T22:05:39Z

📌 Commit e38b399 has been approved by oli-obk

@oli-obk

…, r=oli-obk Make eval_place_to_op iterate instead of recurse r? @oli-obk

@ghost

Rollup of 6 pull requests Successful merges: - rust-lang#61092 (Make sanitize_place iterate instead of recurse) - rust-lang#61093 (Make borrow_of_local_data iterate instead of recurse) - rust-lang#61094 (Make find_local iterate instead of recurse) - rust-lang#61099 (Make ignore_borrow iterate instead of recurse) - rust-lang#61103 (Make find iterate instead of recurse) - rust-lang#61104 (Make eval_place_to_op iterate instead of recurse) Failed merges: r? @ghost

src/librustc_mir/interpret/operand.rs

@ghost

Rollup of 6 pull requests Successful merges: - #61092 (Make sanitize_place iterate instead of recurse) - #61093 (Make borrow_of_local_data iterate instead of recurse) - #61094 (Make find_local iterate instead of recurse) - #61099 (Make ignore_borrow iterate instead of recurse) - #61103 (Make find iterate instead of recurse) - #61104 (Make eval_place_to_op iterate instead of recurse) Failed merges: r? @ghost

rust-highfive assigned oli-obk May 23, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 23, 2019

spastorino force-pushed the eval-place-to-op-iterate branch from 849b0c2 to 3dccf83 Compare May 24, 2019 16:04

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 24, 2019

Centril added a commit to Centril/rust that referenced this pull request May 24, 2019

Rollup merge of rust-lang#61104 - spastorino:eval-place-to-op-iterate…

a699337

…, r=oli-obk Make eval_place_to_op iterate instead of recurse r? @oli-obk

Centril mentioned this pull request May 24, 2019

Rollup of 13 pull requests #61127

Closed

Centril added a commit to Centril/rust that referenced this pull request May 24, 2019

Rollup merge of rust-lang#61104 - spastorino:eval-place-to-op-iterate…

76e7a57

…, r=oli-obk Make eval_place_to_op iterate instead of recurse r? @oli-obk

Centril mentioned this pull request May 24, 2019

Rollup of 13 pull requests #61128

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 24, 2019

spastorino force-pushed the eval-place-to-op-iterate branch 2 times, most recently from e012973 to dbe2ff4 Compare May 24, 2019 19:11

Avoid catch-all arm, use Base(PlaceBase::Static(_))

8173feb

spastorino force-pushed the eval-place-to-op-iterate branch from dbe2ff4 to ed43280 Compare May 24, 2019 19:13

spastorino force-pushed the eval-place-to-op-iterate branch from ed43280 to c6b5e3f Compare May 24, 2019 20:40

oli-obk reviewed May 24, 2019

View reviewed changes

src/librustc_mir/interpret/place.rs Outdated Show resolved Hide resolved

spastorino force-pushed the eval-place-to-op-iterate branch from c6b5e3f to 2c12271 Compare May 24, 2019 20:50

spastorino mentioned this pull request May 24, 2019

Make eval_place iterate instead of recurse #61120

Merged

spastorino force-pushed the eval-place-to-op-iterate branch from 2c12271 to 9617d49 Compare May 24, 2019 21:25

oli-obk requested changes May 24, 2019

View reviewed changes

src/librustc_mir/interpret/place.rs Outdated Show resolved Hide resolved

src/librustc_mir/interpret/place.rs Outdated Show resolved Hide resolved

spastorino added 2 commits May 24, 2019 23:57

Make eval_place_to_mplace take PlaceBase::Static

6d7a362

Make eval_place_to_op iterate instead of recurse

e38b399

spastorino force-pushed the eval-place-to-op-iterate branch from 9617d49 to e38b399 Compare May 24, 2019 21:58

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 24, 2019

Centril added a commit to Centril/rust that referenced this pull request May 25, 2019

Rollup merge of rust-lang#61104 - spastorino:eval-place-to-op-iterate…

1cd3ddd

…, r=oli-obk Make eval_place_to_op iterate instead of recurse r? @oli-obk

Centril mentioned this pull request May 25, 2019

Rollup of 6 pull requests #61151

Merged

RalfJung reviewed May 25, 2019

View reviewed changes

src/librustc_mir/interpret/operand.rs Show resolved Hide resolved

bors merged commit e38b399 into rust-lang:master May 25, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make eval_place_to_op iterate instead of recurse #61104

Make eval_place_to_op iterate instead of recurse #61104

spastorino commented May 23, 2019

rust-highfive commented May 23, 2019

oli-obk commented May 24, 2019

bors commented May 24, 2019

rust-highfive commented May 24, 2019

oli-obk commented May 24, 2019

rust-highfive commented May 24, 2019

rust-highfive commented May 24, 2019

oli-obk commented May 24, 2019

bors commented May 24, 2019

Make eval_place_to_op iterate instead of recurse #61104

Make eval_place_to_op iterate instead of recurse #61104

Conversation

spastorino commented May 23, 2019

rust-highfive commented May 23, 2019

oli-obk commented May 24, 2019

bors commented May 24, 2019

rust-highfive commented May 24, 2019

oli-obk commented May 24, 2019

rust-highfive commented May 24, 2019

rust-highfive commented May 24, 2019

oli-obk commented May 24, 2019

bors commented May 24, 2019