is_union returns ty to avoid computing it twice #61261
Merged
+24
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
oli-obk
approved these changes
May 28, 2019
Centril
reviewed
May 28, 2019
spastorino
force-pushed
the
is-union-return-ty
branch
from
23a0b13
to
57b520a
Compare
Centril
reviewed
May 28, 2019
spastorino
force-pushed
the
is-union-return-ty
branch
from
63d1c4d
to
1388ec0
Compare
Centril
approved these changes
May 28, 2019
spastorino
force-pushed
the
is-union-return-ty
branch
from
1388ec0
to
bb94fc0
Compare
|
Have also squashed the two last commits into one because it did not make sense to split those. |
|
@bors r+ |
|
📌 Commit bb94fc0 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 29, 2019
…i-obk is_union returns ty to avoid computing it twice r? @oli-obk
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 29, 2019
…i-obk is_union returns ty to avoid computing it twice r? @oli-obk
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 29, 2019
…i-obk is_union returns ty to avoid computing it twice r? @oli-obk
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 29, 2019
…i-obk is_union returns ty to avoid computing it twice r? @oli-obk
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 29, 2019
…i-obk is_union returns ty to avoid computing it twice r? @oli-obk
oli-obk
added a commit
to oli-obk/rust
that referenced
this pull request
May 29, 2019
…i-obk is_union returns ty to avoid computing it twice r? @oli-obk
bors
added a commit
that referenced
this pull request
May 29, 2019
Rollup of 7 pull requests Successful merges: - #60549 (do not print panic message on doctest failures) - #60885 (strip synstructure consts from compiler docs) - #61217 (Account for short-hand init structs when suggesting conversion) - #61261 (is_union returns ty to avoid computing it twice) - #61293 (Print const generics properly in rustdoc) - #61310 (split libcore::mem into multiple files) - #61313 (Simplify Set1::insert) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @oli-obk