Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LLVM instruction stats and other (obsolete) codegen stats. #61297

Merged
merged 3 commits into from May 29, 2019

Conversation

Projects
None yet
4 participants
@eddyb
Copy link
Member

commented May 28, 2019

Both -Z count_llvm_insns and -Z codegen-stats are removed, as (AFAIK) they have been of little use in the last few years, especially after the transition to MIR->LLVM codegen.

Other than for the LLVM instruction counts, -Z codegen-stats has long been obsoleted anyway.

r? @nagisa cc @rust-lang/compiler

@nagisa

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

📌 Commit 7fa97c0 has been approved by nagisa

Centril added a commit to Centril/rust that referenced this pull request May 29, 2019

Rollup merge of rust-lang#61297 - eddyb:forsaken-stats, r=nagisa
Remove LLVM instruction stats and other (obsolete) codegen stats.

Both `-Z count_llvm_insns` and `-Z codegen-stats` are removed, as (AFAIK) they have been of little use in the last few years, especially after the transition to MIR->LLVM codegen.

Other than for the LLVM instruction counts, `-Z codegen-stats` has long been obsoleted anyway.

r? @nagisa cc @rust-lang/compiler

Centril added a commit to Centril/rust that referenced this pull request May 29, 2019

Rollup merge of rust-lang#61297 - eddyb:forsaken-stats, r=nagisa
Remove LLVM instruction stats and other (obsolete) codegen stats.

Both `-Z count_llvm_insns` and `-Z codegen-stats` are removed, as (AFAIK) they have been of little use in the last few years, especially after the transition to MIR->LLVM codegen.

Other than for the LLVM instruction counts, `-Z codegen-stats` has long been obsoleted anyway.

r? @nagisa cc @rust-lang/compiler

bors added a commit that referenced this pull request May 29, 2019

Auto merge of #61305 - Centril:rollup-t39m00m, r=Centril
Rollup of 11 pull requests

Successful merges:

 - #58975 (Implement `iter::Sum` and `iter::Product` for `Option`)
 - #60542 (Add Step::sub_usize)
 - #60555 (Implement nth_back for RChunks(Exact)(Mut))
 - #60766 (Weak::into_raw)
 - #61048 (Feature/nth back chunks)
 - #61191 (librustc_errors: Move annotation collection to own impl)
 - #61235 (Stabilize bufreader_buffer feature)
 - #61249 (Rename Place::local to Place::local_or_deref_local)
 - #61291 (Avoid unneeded bug!() call)
 - #61294 (Rename `TraitOrImpl` to `Assoc` and `trait_or_impl` to `assoc`.)
 - #61297 (Remove LLVM instruction stats and other (obsolete) codegen stats.)

Failed merges:

r? @ghost

@bors bors merged commit 7fa97c0 into rust-lang:master May 29, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@eddyb eddyb deleted the eddyb:forsaken-stats branch May 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.