Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/nth back chunks #61048

Merged
merged 11 commits into from May 29, 2019

Conversation

Projects
None yet
5 participants
@wizAmit
Copy link
Contributor

commented May 22, 2019

A succinct implementation for nth_back on chunks. Thank you @timvermeulen for the guidance.

r? @timvermeulen

@amit.chandra and others added some commits Apr 26, 2019

wip nth_back on chunks
Signed-off-by: wizAmit <amitforfriends_dns@yahoo.com>
hopefully working nth_back on chunks
Signed-off-by: wizAmit <amitforfriends_dns@yahoo.com>
wip nth_back on chunks
Signed-off-by: wizAmit <amitforfriends_dns@yahoo.com>
hopefully working nth_back on chunks
Signed-off-by: wizAmit <amitforfriends_dns@yahoo.com>
wip nth_back on chunks
Signed-off-by: wizAmit <amitforfriends_dns@yahoo.com>
hopefully working nth_back on chunks
Signed-off-by: wizAmit <amitforfriends_dns@yahoo.com>
wip nth_back on chunks
Signed-off-by: wizAmit <amitforfriends_dns@yahoo.com>
@timvermeulen

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

Looks good to me, although I don't have permission to approve PRs here. 🙂

Since the implementations for ChunksExact/ChunksMut/ChunksExactMut are so similar, wanna give those a try too?

@wizAmit

This comment has been minimized.

Copy link
Contributor Author

commented May 22, 2019

Ya.. will do that in a separate PR... Thanks a lot!!

@wizAmit wizAmit closed this May 22, 2019

@wizAmit wizAmit reopened this May 22, 2019

@Centril

This comment has been minimized.

Copy link
Member

commented May 25, 2019

@scottmcm

This comment has been minimized.

Copy link
Member

commented May 29, 2019

Thanks for including good tests!

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

📌 Commit bcfd1f3 has been approved by scottmcm

Centril added a commit to Centril/rust that referenced this pull request May 29, 2019

Rollup merge of rust-lang#61048 - wizAmit:feature/nth_back_chunks, r=…
…scottmcm

Feature/nth back chunks

A succinct implementation for nth_back on chunks. Thank you @timvermeulen for the guidance.

r? @timvermeulen

Centril added a commit to Centril/rust that referenced this pull request May 29, 2019

Rollup merge of rust-lang#61048 - wizAmit:feature/nth_back_chunks, r=…
…scottmcm

Feature/nth back chunks

A succinct implementation for nth_back on chunks. Thank you @timvermeulen for the guidance.

r? @timvermeulen

bors added a commit that referenced this pull request May 29, 2019

Auto merge of #61305 - Centril:rollup-t39m00m, r=Centril
Rollup of 11 pull requests

Successful merges:

 - #58975 (Implement `iter::Sum` and `iter::Product` for `Option`)
 - #60542 (Add Step::sub_usize)
 - #60555 (Implement nth_back for RChunks(Exact)(Mut))
 - #60766 (Weak::into_raw)
 - #61048 (Feature/nth back chunks)
 - #61191 (librustc_errors: Move annotation collection to own impl)
 - #61235 (Stabilize bufreader_buffer feature)
 - #61249 (Rename Place::local to Place::local_or_deref_local)
 - #61291 (Avoid unneeded bug!() call)
 - #61294 (Rename `TraitOrImpl` to `Assoc` and `trait_or_impl` to `assoc`.)
 - #61297 (Remove LLVM instruction stats and other (obsolete) codegen stats.)

Failed merges:

r? @ghost

@bors bors merged commit bcfd1f3 into rust-lang:master May 29, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.