Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #61983

Merged
merged 13 commits into from
Jun 20, 2019
Merged

Rollup of 4 pull requests #61983

merged 13 commits into from
Jun 20, 2019

Commits on May 24, 2019

  1. Configuration menu
    Copy the full SHA
    97a6c93 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2019

  1. Add custom nth_back for Skip

    acrrd committed May 29, 2019
    Configuration menu
    Copy the full SHA
    e80a375 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2019

  1. Configuration menu
    Copy the full SHA
    f7ecf1c View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2019

  1. improve indentation

    Electron-libre committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    2191c1d View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2019

  1. Configuration menu
    Copy the full SHA
    c917ba3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    70e52f8 View commit details
    Browse the repository at this point in the history
  3. fix indentation

    Electron-libre committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    b72b1ac View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    887feee View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    673c3fc View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2019

  1. Rollup merge of rust-lang#60454 - acrrd:issues/54054_skip, r=scottmcm

    Add custom nth_back to Skip
    
    Implementation of nth_back for Skip.
    Part of rust-lang#54054
    Centril committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    3e08f1b View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#60772 - timvermeulen:slice_iter_nth_back, r…

    …=scottmcm
    
    Implement nth_back for slice::{Iter, IterMut}
    
    Part of rust-lang#54054.
    
    I implemented `nth_back` as straightforwardly as I could, and then slightly changed `nth` to match `nth_back`. I believe I did so correctly, but please double-check 🙂
    
    I also added the helper methods `zst_shrink`, `next_unchecked`, and `next_back_unchecked` to get rid of some duplicated code. These changes hopefully make this code easier to understand for new contributors like me.
    
    I noticed the `is_empty!` and `len!` macros which sole purpose seems to be inlining, according to the comment right above them, but the `is_empty` and `len` methods are already marked with `#[inline(always)]`. Does that mean we could replace these macros with method calls, without affecting anything? I'd love to get rid of them.
    Centril committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    2e7e131 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#61782 - Electron-libre:suggest_tuple_struct…

    …_syntax, r=estebank
    
    suggest tuple struct syntax
    
    refs rust-lang#57242
    Centril committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    2ead007 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#61968 - eddyb:hir-noclone, r=petrochenkov

    rustc: disallow cloning HIR nodes.
    
    Besides being inefficient, cloning also risks creating broken HIR (without properly recreating all the IDs and whatnot, in which case you might as well reconstruct the entire node without ever `Clone`-ing anything).
    
    We detect *some* detrimental situations (based on the occurrence of `HirId`s, I believe?), but it's better to statically disallow it, IMO.
    
    One of the examples that is fixed by this PR is `tcx.hir().fn_decl{,_by_hir_id}`, which was cloning an entire `hir::FnDecl` *every single time it was called*.
    
    r? @petrochenkov cc @rust-lang/compiler
    Centril committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    942a7fe View commit details
    Browse the repository at this point in the history