Trigger unused_attribute lint on #[cfg_attr($pred,)]
#62047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
estebank
approved these changes
Jun 22, 2019
| --> $DIR/cfg-attr-empty-is-unused.rs:10:1 | ||
| | | ||
| LL | #[cfg_attr(TRUE,)] | ||
| | ^^^^^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
Why does this one trigger?
There was a problem hiding this comment.
Whether it matches or not, it still has no effect because the list of attributes to expand to is empty. :)
|
@bors r+ rollup |
|
📌 Commit af710c9 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 22, 2019
…bank Trigger `unused_attribute` lint on `#[cfg_attr($pred,)]` Lint on `#[cfg_attr($pred,)]` as decided in rust-lang#54881 (comment). Closes rust-lang#54881. r? @estebank
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 22, 2019
…bank Trigger `unused_attribute` lint on `#[cfg_attr($pred,)]` Lint on `#[cfg_attr($pred,)]` as decided in rust-lang#54881 (comment). Closes rust-lang#54881. r? @estebank
bors
added a commit
that referenced
this pull request
Jun 23, 2019
Rollup of 5 pull requests Successful merges: - #62047 (Trigger `unused_attribute` lint on `#[cfg_attr($pred,)]`) - #62049 (Fix one missing `dyn`.) - #62051 (Lint empty `#[derive()]` as unused attribute.) - #62057 (Deny explicit_outlives_requirements in the compiler) - #62068 (Fix meta-variable binding errors in macros) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint on
#[cfg_attr($pred,)]as decided in #54881 (comment).Closes #54881.
r? @estebank