Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HirIdification: almost there #62091

Merged
merged 6 commits into from
Jun 25, 2019
Merged

Conversation

ljedrz
Copy link
Contributor

@ljedrz ljedrz commented Jun 24, 2019

I'm beginning to run out of stuff to HirIdify 😉.

This time I targeted mainly hir::map::{find, get_parent_node}, but a few other bits got changed too.

r? @Zoxc

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 24, 2019
@Zoxc
Copy link
Contributor

Zoxc commented Jun 24, 2019

I'm beginning to run out of stuff to HirIdify

Not the worst problem to have =P

@bors delegate+

@bors
Copy link
Contributor

bors commented Jun 24, 2019

✌️ @ljedrz can now approve this pull request

@ljedrz
Copy link
Contributor Author

ljedrz commented Jun 24, 2019

@bors r=Zoxc

@bors
Copy link
Contributor

bors commented Jun 24, 2019

📌 Commit 87438a1 has been approved by Zoxc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2019
@bors
Copy link
Contributor

bors commented Jun 25, 2019

⌛ Testing commit 87438a1 with merge dbfeb9da46149eb475c6e5bc0c27b12d3a1b661a...

@bors
Copy link
Contributor

bors commented Jun 25, 2019

💔 Test failed - checks-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 25, 2019
@rust-highfive
Copy link
Collaborator

The job test-various of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:45:47] test time::tests::system_time_elapsed ... ok
[01:45:47] test time::tests::system_time_math ... ok
[01:45:48] test thread::tests::test_park_timeout_unpark_called_other_thread ... ok
[01:45:55] test sync::mpsc::tests::stress_recv_timeout_two_threads ... ok
[01:46:45] test process::tests::uid_works ... test process::tests::uid_works has been running for over 60 seconds
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril
Copy link
Contributor

Centril commented Jun 25, 2019

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 25, 2019
… r=Zoxc

HirIdification: almost there

I'm beginning to run out of stuff to HirIdify 😉.

This time I targeted mainly `hir::map::{find, get_parent_node}`, but a few other bits got changed too.

r? @Zoxc
bors added a commit that referenced this pull request Jun 25, 2019
Rollup of 7 pull requests

Successful merges:

 - #61814 (Fix an ICE with uninhabited consts)
 - #61987 (rustc: produce AST instead of HIR from `hir::lowering::Resolver` methods.)
 - #62055 (Fix error counting)
 - #62078 (Remove built-in derive macros `Send` and `Sync`)
 - #62085 (Add test for issue-38591)
 - #62091 (HirIdification: almost there)
 - #62096 (Implement From<Local> for Place and PlaceBase)

Failed merges:

r? @ghost
@bors bors merged commit 87438a1 into rust-lang:master Jun 25, 2019
@ljedrz ljedrz deleted the hiridification_almost_there branch June 26, 2019 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants