Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove built-in derive macros Send and Sync #62078

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Remove built-in derive macros Send and Sync #62078

merged 1 commit into from
Jun 25, 2019

Conversation

petrochenkov
Copy link
Contributor

Closes #62050

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 23, 2019
@varkor
Copy link
Member

varkor commented Jun 23, 2019

r=me when Travis passes.

@petrochenkov
Copy link
Contributor Author

@bors r=varkor rollup

@bors
Copy link
Contributor

bors commented Jun 23, 2019

📌 Commit e1d871e has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 24, 2019
@Centril
Rollup merge of rust-lang#62078 - petrochenkov:nosendync2, r=varkor
5015430 
Remove built-in derive macros `Send` and `Sync`

Closes rust-lang#62050
@Centril Centril mentioned this pull request Jun 24, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jun 25, 2019
@Centril
Rollup merge of rust-lang#62078 - petrochenkov:nosendync2, r=varkor
61fae23 
Remove built-in derive macros `Send` and `Sync`

Closes rust-lang#62050
@Centril Centril mentioned this pull request Jun 25, 2019
Merged
bors added a commit that referenced this pull request Jun 25, 2019
@bors
Auto merge of #62119 - Centril:rollup-el20wu0, r=Centril
5f9c044 
Rollup of 7 pull requests

Successful merges:

 - #61814 (Fix an ICE with uninhabited consts)
 - #61987 (rustc: produce AST instead of HIR from `hir::lowering::Resolver` methods.)
 - #62055 (Fix error counting)
 - #62078 (Remove built-in derive macros `Send` and `Sync`)
 - #62085 (Add test for issue-38591)
 - #62091 (HirIdification: almost there)
 - #62096 (Implement From<Local> for Place and PlaceBase)

Failed merges:

r? @ghost
@bors bors merged commit e1d871e into rust-lang:master Jun 25, 2019
@petrochenkov petrochenkov deleted the nosendync2 branch July 1, 2019 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@varkor varkor

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Built-in derive macros Send and Sync exist
4 participants
@petrochenkov @rust-highfive @varkor @bors