Fix code block information icon position #62238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
T-rustdoc
|
As usual, small fix, a few days passed and still no comments so I'll just r+ it... I'll add the corresponding test in rust-docs-test-ui repository. @bors: r=rustdoc rollup |
|
📌 Commit e861efd has been approved by |
bors
added
S-waiting-on-bors
|
@bors r- Can you post a before/after screenshot for actual bulleted/numbered lists? |
bors
added
S-waiting-on-author
|
Never mind, i just tested this myself. In the future, please refrain from approving your own PRs, no matter how small. If you have several small PRs waiting for review, please ping me directly, on Discord, so i can read through them. I have too many GitHub notifications now to keep up with everything. @bors r+ |
|
📌 Commit e861efd has been approved by |
bors
added
S-waiting-on-bors
|
The before was in the linked issue. And sure, will do that next time! |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 5, 2019
…mation-icon-pos, r=QuietMisdreavus Fix code block information icon position Fixes rust-lang#62118. A screenshot of the fix: <img width="720" alt="Screenshot 2019-06-29 at 18 28 59" src="https://user-images.githubusercontent.com/3050060/60386900-edb23b80-9a9b-11e9-9f4f-0f343674348c.png"> r? @rust-lang/rustdoc
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 5, 2019
…mation-icon-pos, r=QuietMisdreavus Fix code block information icon position Fixes rust-lang#62118. A screenshot of the fix: <img width="720" alt="Screenshot 2019-06-29 at 18 28 59" src="https://user-images.githubusercontent.com/3050060/60386900-edb23b80-9a9b-11e9-9f4f-0f343674348c.png"> r? @rust-lang/rustdoc
bors
added a commit
that referenced
this pull request
Jul 5, 2019
Rollup of 10 pull requests Successful merges: - #62123 ( Remove needless lifetimes (std)) - #62150 (Implement mem::{zeroed,uninitialized} in terms of MaybeUninit.) - #62169 (Derive which queries to save using the proc macro) - #62238 (Fix code block information icon position) - #62292 (Move `async || ...` closures into `#![feature(async_closure)]`) - #62323 (Clarify unaligned fields in ptr::{read,write}_unaligned) - #62324 (Reduce reliance on `await!(...)` macro) - #62371 (Add tracking issue for Box::into_pin) - #62383 (Improve error span for async type inference error) - #62388 (Break out of the correct number of scopes in loops) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62118.
A screenshot of the fix:
r? @rust-lang/rustdoc