Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error span for async type inference error #62383

Merged
merged 1 commit into from Jul 5, 2019

Conversation

Projects
None yet
4 participants
@Aaron1011
Copy link
Contributor

commented Jul 4, 2019

Fixes #62382

Previously, we would point at the spawn of the 'await' expression,
instead of the actual expression with an unknown type.

Improve error span for async type inference error
Fixes #62382

Previously, we would point at the spawn of the 'await' expression,
instead of the actual expression with an unknown type.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 4, 2019

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@varkor

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2019

📌 Commit 779308a has been approved by varkor

Centril added a commit to Centril/rust that referenced this pull request Jul 5, 2019

Rollup merge of rust-lang#62383 - Aaron1011:fix/async-error-span, r=v…
…arkor

Improve error span for async type inference error

Fixes rust-lang#62382

Previously, we would point at the spawn of the 'await' expression,
instead of the actual expression with an unknown type.

bors added a commit that referenced this pull request Jul 5, 2019

Auto merge of #62399 - Centril:rollup-du8hsoo, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #62123 ( Remove needless lifetimes (std))
 - #62150 (Implement mem::{zeroed,uninitialized} in terms of MaybeUninit.)
 - #62169 (Derive which queries to save using the proc macro)
 - #62238 (Fix code block information icon position)
 - #62292 (Move `async || ...` closures into `#![feature(async_closure)]`)
 - #62323 (Clarify unaligned fields in ptr::{read,write}_unaligned)
 - #62324 (Reduce reliance on `await!(...)` macro)
 - #62331 (Fix leak when early returning out of `box` syntax)
 - #62371 (Add tracking issue for Box::into_pin)
 - #62383 (Improve error span for async type inference error)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Jul 5, 2019

Rollup merge of rust-lang#62383 - Aaron1011:fix/async-error-span, r=v…
…arkor

Improve error span for async type inference error

Fixes rust-lang#62382

Previously, we would point at the spawn of the 'await' expression,
instead of the actual expression with an unknown type.

bors added a commit that referenced this pull request Jul 5, 2019

Auto merge of #62407 - Centril:rollup-g0zmff7, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #62123 ( Remove needless lifetimes (std))
 - #62150 (Implement mem::{zeroed,uninitialized} in terms of MaybeUninit.)
 - #62169 (Derive which queries to save using the proc macro)
 - #62238 (Fix code block information icon position)
 - #62292 (Move `async || ...` closures into `#![feature(async_closure)]`)
 - #62323 (Clarify unaligned fields in ptr::{read,write}_unaligned)
 - #62324 (Reduce reliance on `await!(...)` macro)
 - #62371 (Add tracking issue for Box::into_pin)
 - #62383 (Improve error span for async type inference error)
 - #62388 (Break out of the correct number of scopes in loops)

Failed merges:

r? @ghost

@bors bors merged commit 779308a into rust-lang:master Jul 5, 2019

3 checks passed

pr Build #20190704.58 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.